[GitHub] jerrypeng commented on a change in pull request #1828: instance worker health check

jerrypeng commented on a change in pull request #1828: instance worker health check URL: https://github.com/apache/incubator-pulsar/pull/1828#discussion_r189782719 ## File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/JavaInstanceMain.java

[GitHub] jerrypeng commented on issue #1828: instance worker health check

jerrypeng commented on issue #1828: instance worker health check URL: https://github.com/apache/incubator-pulsar/pull/1828#issuecomment-390867958 @srkukarni @sijie please review This is an automated message from the Apache

[GitHub] jerrypeng opened a new pull request #1828: instance worker health check

jerrypeng opened a new pull request #1828: instance worker health check URL: https://github.com/apache/incubator-pulsar/pull/1828 Implement implement periodic health checks from instance to worker to ensure there aren't any orphaned instance processes running

[GitHub] merlimat commented on issue #1820: Use exact dependency version in LICENSE file and use check-binary-license to enforce

merlimat commented on issue #1820: Use exact dependency version in LICENSE file and use check-binary-license to enforce URL: https://github.com/apache/incubator-pulsar/pull/1820#issuecomment-390865612 retest this please This

[GitHub] merlimat closed pull request #1824: Example Pulsar Function configs in binary distribution

merlimat closed pull request #1824: Example Pulsar Function configs in binary distribution URL: https://github.com/apache/incubator-pulsar/pull/1824 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] merlimat commented on issue #1827: Added option for custom loggers in C++ and C APIs

merlimat commented on issue #1827: Added option for custom loggers in C++ and C APIs URL: https://github.com/apache/incubator-pulsar/pull/1827#issuecomment-390864432 retest this please This is an automated message from the

[incubator-pulsar] branch master updated: Build responses when returning from web service (#1823)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 920b778 Build responses when

[GitHub] merlimat closed pull request #1823: Build responses when returning from web service

merlimat closed pull request #1823: Build responses when returning from web service URL: https://github.com/apache/incubator-pulsar/pull/1823 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] merlimat opened a new pull request #1827: Added option for custom loggers in C++ and C APIs

merlimat opened a new pull request #1827: Added option for custom loggers in C++ and C APIs URL: https://github.com/apache/incubator-pulsar/pull/1827 ### Motivation In many cases, the supplied Log4CXX logger for C++ is not practical or convenient for users. For examples,

[GitHub] sijie commented on issue #1823: Build responses when returning from web service

sijie commented on issue #1823: Build responses when returning from web service URL: https://github.com/apache/incubator-pulsar/pull/1823#issuecomment-390833678 retest this please This is an automated message from the Apache

[GitHub] lucperkins commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command

lucperkins commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command URL: https://github.com/apache/incubator-pulsar/pull/1670#issuecomment-390743116 retest this please This is an

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-390793348 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] srkukarni commented on issue #1750: Show stacktrace when Function fails

srkukarni commented on issue #1750: Show stacktrace when Function fails URL: https://github.com/apache/incubator-pulsar/pull/1750#issuecomment-390763492 @jaoki sounds good! This is an automated message from the Apache Git

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-390756140 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-390276898 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-389739626 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] jaoki commented on issue #1750: Show stacktrace when Function fails

jaoki commented on issue #1750: Show stacktrace when Function fails URL: https://github.com/apache/incubator-pulsar/pull/1750#issuecomment-390752654 @srkukarni @sijie I'd love to close this out but it has been a bit busy. Would it be OK if I come back in a couple of weeks?

[GitHub] lucperkins opened a new pull request #1824: Example Pulsar Function configs in binary distribution

lucperkins opened a new pull request #1824: Example Pulsar Function configs in binary distribution URL: https://github.com/apache/incubator-pulsar/pull/1824 This PR moves the example Pulsar Function configs currently in the `conf` folder (where I don't think they really fit) into the

[GitHub] lucperkins commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command

lucperkins commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command URL: https://github.com/apache/incubator-pulsar/pull/1670#issuecomment-390743116 retest this please This is an

[GitHub] sijie commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command

sijie commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command URL: https://github.com/apache/incubator-pulsar/pull/1670#issuecomment-390733224 @lucperkins do you mind rebasing this PR?

[GitHub] turboT4 commented on issue #1822: JNI error while trying to execute bin/pulsar standalone

turboT4 commented on issue #1822: JNI error while trying to execute bin/pulsar standalone URL: https://github.com/apache/incubator-pulsar/issues/1822#issuecomment-390733218 Thanks for the reply @merlimat , I'm trying to run Pulsar on macOS Sierra and Java version 1.8.0_121.

[GitHub] merlimat commented on issue #1822: JNI error while trying to execute bin/pulsar standalone

merlimat commented on issue #1822: JNI error while trying to execute bin/pulsar standalone URL: https://github.com/apache/incubator-pulsar/issues/1822#issuecomment-390732524 Hi @turboT4, can you specify which pulsar version and which environment OS / Java version?

[GitHub] mgodave opened a new pull request #1823: Build responses when returning from web service

mgodave opened a new pull request #1823: Build responses when returning from web service URL: https://github.com/apache/incubator-pulsar/pull/1823 The responses are not being built and the server is returning a 500 instead of the intended status code.

[GitHub] jai1 commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected

jai1 commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r189657171 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyConnectionPool.java

[GitHub] srkukarni commented on issue #1750: Show stacktrace when Function fails

srkukarni commented on issue #1750: Show stacktrace when Function fails URL: https://github.com/apache/incubator-pulsar/pull/1750#issuecomment-390675839 @jaoki could you please address my comments? This is an automated

[GitHub] massakam commented on issue #1821: Closing client when Proxyconnection is disconnected

massakam commented on issue #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#issuecomment-390631332 Don't we have to close `dnsResolver`?

[GitHub] massakam commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected

massakam commented on a change in pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#discussion_r189561590 ## File path:

[GitHub] turboT4 opened a new issue #1822: JNI error while trying to execute bin/pulsar standalone

turboT4 opened a new issue #1822: JNI error while trying to execute bin/pulsar standalone URL: https://github.com/apache/incubator-pulsar/issues/1822 Hey guys, I'm new to Pulsar and just downloaded the latest version, tried to execute it and got this error. `Error: A JNI

[GitHub] sijie commented on issue #1743: ByteBuffer schema

sijie commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-390585662 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command

sijie commented on issue #1670: Check for tenant and namespace for pulsar-admin functions list command URL: https://github.com/apache/incubator-pulsar/pull/1670#issuecomment-390582850 @jerrypeng @srkukarni please review this PR?

[GitHub] sijie commented on issue #1816: Removed internal shading

sijie commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-390582609 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] sijie closed pull request #1798: S3ManagedLedgerOffloader should require region or endpoint

sijie closed pull request #1798: S3ManagedLedgerOffloader should require region or endpoint URL: https://github.com/apache/incubator-pulsar/pull/1798 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: S3ManagedLedgerOffloader should require region or endpoint (#1798)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 505677a S3ManagedLedgerOffloader

[incubator-pulsar] branch master updated: Expose offload deletion lag in broker configuration (#1805)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 069efdb Expose offload deletion lag

[GitHub] sijie commented on issue #1807: In S3 offloader, dont use InputStream#available for stream length

sijie commented on issue #1807: In S3 offloader, dont use InputStream#available for stream length URL: https://github.com/apache/incubator-pulsar/pull/1807#issuecomment-390581504 @ivankelly can you rebase this PR? This is an

[incubator-pulsar] branch master updated: Used OrderedScheduler for ledger offload (#1808)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fae2343 Used OrderedScheduler for

[GitHub] sijie commented on issue #1809: S3 offloader doesn't allow block size < 5MB

sijie commented on issue #1809: S3 offloader doesn't allow block size < 5MB URL: https://github.com/apache/incubator-pulsar/pull/1809#issuecomment-390581137 retest this please This is an automated message from the Apache Git

[GitHub] sijie closed pull request #1810: Store offloaded data object size in index

sijie closed pull request #1810: Store offloaded data object size in index URL: https://github.com/apache/incubator-pulsar/pull/1810 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Store offloaded data object size in index (#1810)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 79b0e28 Store offloaded data object

[GitHub] sijie closed pull request #1811: Improve logging when we fail to bind on server ports

sijie closed pull request #1811: Improve logging when we fail to bind on server ports URL: https://github.com/apache/incubator-pulsar/pull/1811 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: adding update functionality to sources and sinks (#1813)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7f97bde adding update functionality

[GitHub] sijie closed issue #1614: Itermittent test timeout on PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition

sijie closed issue #1614: Itermittent test timeout on PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition URL: https://github.com/apache/incubator-pulsar/issues/1614 This is an automated message from the

[GitHub] sijie closed pull request #1818: Fixed race condition in consumer event listener

sijie closed pull request #1818: Fixed race condition in consumer event listener URL: https://github.com/apache/incubator-pulsar/pull/1818 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jai1 opened a new pull request #1821: Closing client when Proxyconnection is disconnected

jai1 opened a new pull request #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821 Currently, client.close() is not called when ProxyConnection becomes inactive which leads to leaking unused connections. Since the