[GitHub] zhaijack commented on issue #1841: Fix flaky test with s3 backend

2018-05-23 Thread GitBox
zhaijack commented on issue #1841: Fix flaky test with s3 backend URL: https://github.com/apache/incubator-pulsar/pull/1841#issuecomment-391592460 Thanks @merlimat for pointing this out. This is an automated message from the

[GitHub] zhaijack opened a new pull request #1841: Fix flaky test with s3 backend

2018-05-23 Thread GitBox
zhaijack opened a new pull request #1841: Fix flaky test with s3 backend URL: https://github.com/apache/incubator-pulsar/pull/1841 There is a flaky test in s3 backend, which reported: ``` expected [false] but found [true]

[GitHub] sijie closed pull request #1840: Minor code cleanup in JavaInstanceRunnable

2018-05-23 Thread GitBox
sijie closed pull request #1840: Minor code cleanup in JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1840 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Minor code cleanup in JavaInstanceRunnable (#1840)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4e7748b Minor code cleanup in

[GitHub] sijie closed pull request #1816: Removed internal shading

2018-05-23 Thread GitBox
sijie closed pull request #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Removed internal shading (#1816)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0f970e3 Removed internal shading

[GitHub] srkukarni opened a new pull request #1839: Check if producer is not null before closing

2018-05-23 Thread GitBox
srkukarni opened a new pull request #1839: Check if producer is not null before closing URL: https://github.com/apache/incubator-pulsar/pull/1839 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ###

[GitHub] sijie commented on issue #1816: Removed internal shading

2018-05-23 Thread GitBox
sijie commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-391540264 Nice finding at zookeeper server! @merlimat This is an automated message from the

[GitHub] srkukarni commented on issue #1816: Removed internal shading

2018-05-23 Thread GitBox
srkukarni commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-391529155 retest this please This is an automated message from the Apache Git Service. To

[incubator-pulsar] branch master updated: Remove reference to consumers in client map when unsubscribing (#1836)

2018-05-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3988ca3 Remove reference to

[GitHub] merlimat closed pull request #1836: Remove reference to consumers in client map when unsubscribing

2018-05-23 Thread GitBox
merlimat closed pull request #1836: Remove reference to consumers in client map when unsubscribing URL: https://github.com/apache/incubator-pulsar/pull/1836 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat commented on issue #1836: Remove reference to consumers in client map when unsubscribing

2018-05-23 Thread GitBox
merlimat commented on issue #1836: Remove reference to consumers in client map when unsubscribing URL: https://github.com/apache/incubator-pulsar/pull/1836#issuecomment-391507996 retest this please This is an automated

[GitHub] merlimat commented on a change in pull request #1838: [WIP] Pulsar Go client docs

2018-05-23 Thread GitBox
merlimat commented on a change in pull request #1838: [WIP] Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838#discussion_r190400331 ## File path: site/_data/popovers.yaml ## @@ -92,6 +92,9 @@ pulsar: pulsar-functions: q: What are Pulsar

[GitHub] mgodave commented on issue #1816: Removed internal shading

2018-05-23 Thread GitBox
mgodave commented on issue #1816: Removed internal shading URL: https://github.com/apache/incubator-pulsar/pull/1816#issuecomment-391492812 retest this please This is an automated message from the Apache Git Service. To

[incubator-pulsar] branch master updated: fixing problem of functions that have an array as input or output (#1837)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a2ca79d fixing problem of functions

[GitHub] dsambandam closed issue #1835: Topics definition missing as part of Pulsar-admin CLI

2018-05-23 Thread GitBox
dsambandam closed issue #1835: Topics definition missing as part of Pulsar-admin CLI URL: https://github.com/apache/incubator-pulsar/issues/1835 This is an automated message from the Apache Git Service. To respond to the

[GitHub] dsambandam commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI

2018-05-23 Thread GitBox
dsambandam commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI URL: https://github.com/apache/incubator-pulsar/issues/1835#issuecomment-391462715 That works..thank you! This is an automated

[GitHub] jai1 commented on issue #1821: Closing client when Proxyconnection is disconnected

2018-05-23 Thread GitBox
jai1 commented on issue #1821: Closing client when Proxyconnection is disconnected URL: https://github.com/apache/incubator-pulsar/pull/1821#issuecomment-391461116 retest this please This is an automated message from the

[GitHub] lucperkins opened a new pull request #1838: [WIP] Pulsar Go client docs

2018-05-23 Thread GitBox
lucperkins opened a new pull request #1838: [WIP] Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] jerrypeng opened a new pull request #1837: fixing problem of functions that have an array as input or output

2018-05-23 Thread GitBox
jerrypeng opened a new pull request #1837: fixing problem of functions that have an array as input or output URL: https://github.com/apache/incubator-pulsar/pull/1837 This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #1837: fixing problem of functions that have an array as input or output

2018-05-23 Thread GitBox
jerrypeng commented on issue #1837: fixing problem of functions that have an array as input or output URL: https://github.com/apache/incubator-pulsar/pull/1837#issuecomment-391450651 @srkukarni @sijie please review This is

[GitHub] merlimat opened a new pull request #1836: Remove reference to consumers in client map when unsubscribing

2018-05-23 Thread GitBox
merlimat opened a new pull request #1836: Remove reference to consumers in client map when unsubscribing URL: https://github.com/apache/incubator-pulsar/pull/1836 ### Motivation Unlike in the case of `Consumer.close()`, when calling `Consumer.unsubscribe()` the consumer reference

[GitHub] sijie commented on issue #1466: Topic compaction documentation

2018-05-23 Thread GitBox
sijie commented on issue #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#issuecomment-391446309 @ivankelly can you review this? This is an automated message from the Apache Git

[GitHub] sijie closed pull request #1815: Resolve the flaky test ReplicatorTest.testCloseReplicatorStartProducer

2018-05-23 Thread GitBox
sijie closed pull request #1815: Resolve the flaky test ReplicatorTest.testCloseReplicatorStartProducer URL: https://github.com/apache/incubator-pulsar/pull/1815 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-pulsar] branch master updated: Resolve the flaky test ReplicatorTest.testCloseReplicatorStartProducer (#1815)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e8c8c37 Resolve the flaky test

[GitHub] sijie closed pull request #1825: Change docs versions

2018-05-23 Thread GitBox
sijie closed pull request #1825: Change docs versions URL: https://github.com/apache/incubator-pulsar/pull/1825 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-pulsar] branch master updated: Change docs versions (#1825)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9bf943f Change docs versions (#1825)

[GitHub] sijie closed pull request #1829: Integration test for s3offload

2018-05-23 Thread GitBox
sijie closed pull request #1829: Integration test for s3offload URL: https://github.com/apache/incubator-pulsar/pull/1829 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Integration test for s3offload (#1829)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fdb35d4 Integration test for

[GitHub] sijie closed pull request #1834: Added Homebrew recipe for C++ client library

2018-05-23 Thread GitBox
sijie closed pull request #1834: Added Homebrew recipe for C++ client library URL: https://github.com/apache/incubator-pulsar/pull/1834 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Added Homebrew recipe for C++ client library (#1834)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3e09628 Added Homebrew recipe for C++

[GitHub] sijie closed pull request #1833: adding worker to instance health check

2018-05-23 Thread GitBox
sijie closed pull request #1833: adding worker to instance health check URL: https://github.com/apache/incubator-pulsar/pull/1833 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: adding worker to instance health check (#1833)

2018-05-23 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new c6c34f5 adding worker to instance

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

2018-05-23 Thread GitBox
lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-391440229 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] merlimat commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI

2018-05-23 Thread GitBox
merlimat commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI URL: https://github.com/apache/incubator-pulsar/issues/1835#issuecomment-391430841 @dsambandam In 1.22 CLI tool we have 2 subcommands `pulsar-admin persistent` and `pulsar-admin non-persistent` to

[GitHub] dsambandam commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI

2018-05-23 Thread GitBox
dsambandam commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI URL: https://github.com/apache/incubator-pulsar/issues/1835#issuecomment-391424521 Hi @merlimat - Documentation looks fine but am not able to produce any messages to the topic with the standalone

[GitHub] merlimat commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI

2018-05-23 Thread GitBox
merlimat commented on issue #1835: Topics definition missing as part of Pulsar-admin CLI URL: https://github.com/apache/incubator-pulsar/issues/1835#issuecomment-391421577 Hi @dsambandam. The website is already updated with the docs for release 2.0 which is imminent. In 2.0 we have

[incubator-pulsar] branch master updated: Use our own minimal S3Mock rather than findify S3Mock (#1806)

2018-05-23 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b0b0891 Use our own minimal S3Mock

[GitHub] merlimat closed pull request #1806: Use our own minimal S3Mock rather than findify S3Mock

2018-05-23 Thread GitBox
merlimat closed pull request #1806: Use our own minimal S3Mock rather than findify S3Mock URL: https://github.com/apache/incubator-pulsar/pull/1806 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] dsambandam opened a new issue #1835: Topics definition missing as part of Pulsar-admin CLI

2018-05-23 Thread GitBox
dsambandam opened a new issue #1835: Topics definition missing as part of Pulsar-admin CLI URL: https://github.com/apache/incubator-pulsar/issues/1835 Expected behavior I am trying to test Pulsar Standalone installation version 1.22.0 in CENTOS Ver#7 and ran into problems