[GitHub] jerrypeng commented on issue #1845: Functions schema integration

2018-05-25 Thread GitBox
jerrypeng commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-392213345 Yup I agree with @srkukarni This is an automated message from the Apache Git

[GitHub] jerrypeng commented on a change in pull request #1845: Functions schema integration

2018-05-25 Thread GitBox
jerrypeng commented on a change in pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r191030350 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java

[GitHub] jerrypeng commented on a change in pull request #1845: Functions schema integration

2018-05-25 Thread GitBox
jerrypeng commented on a change in pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r191030390 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java

[GitHub] jerrypeng commented on issue #1845: Functions schema integration

2018-05-25 Thread GitBox
jerrypeng commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-392213345 Yup I agree with @srkukarni This is an automated message from the Apache Git

[GitHub] sijie closed pull request #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
sijie closed pull request #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Update pulsar netty/grpc dependencies (#1844)

2018-05-25 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9e88b4d Update pulsar netty/grpc

[GitHub] srkukarni commented on issue #1845: Functions schema integration

2018-05-25 Thread GitBox
srkukarni commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-392179231 Most of the changes in this pr touch producer/consumer. Plus there are a bunch of other changes necessary for functions that are not there

[GitHub] merlimat commented on a change in pull request #1845: Functions schema integration

2018-05-25 Thread GitBox
merlimat commented on a change in pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r190985761 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerBuilder.java ## @@ -94,6

[GitHub] sijie commented on issue #1845: Functions schema integration

2018-05-25 Thread GitBox
sijie commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-392140302 @srkukarni @jerrypeng please review This is an automated message from the Apache

[GitHub] sijie closed pull request #1843: If left unspecified, function tenants and namespaces should have the same behavior as topics

2018-05-25 Thread GitBox
sijie closed pull request #1843: If left unspecified, function tenants and namespaces should have the same behavior as topics URL: https://github.com/apache/incubator-pulsar/pull/1843 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] sijie commented on a change in pull request #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
sijie commented on a change in pull request #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844#discussion_r190972630 ## File path: pom.xml ## @@ -121,9 +121,9 @@ flexible messaging model and an intuitive client API.

[GitHub] sijie commented on a change in pull request #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
sijie commented on a change in pull request #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844#discussion_r190964637 ## File path: pom.xml ## @@ -121,9 +121,9 @@ flexible messaging model and an intuitive client API.

[GitHub] merlimat commented on a change in pull request #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
merlimat commented on a change in pull request #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844#discussion_r190954166 ## File path: pom.xml ## @@ -121,9 +121,9 @@ flexible messaging model and an intuitive client API.

[GitHub] merlimat commented on a change in pull request #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
merlimat commented on a change in pull request #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844#discussion_r190953327 ## File path: pom.xml ## @@ -121,9 +121,9 @@ flexible messaging model and an intuitive client API.

[GitHub] mgodave opened a new pull request #1845: Functions schema integration

2018-05-25 Thread GitBox
mgodave opened a new pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845 Unify SerDe and Schema. Allow SerDe/Schema to be used when creating PulsarSink and PulsarSource.

[GitHub] XiaoZYang commented on issue #133: delayed message other than delivered right away

2018-05-25 Thread GitBox
XiaoZYang commented on issue #133: delayed message other than delivered right away URL: https://github.com/apache/incubator-pulsar/issues/133#issuecomment-392103785 Cool, that sounds interesting ! This is an automated

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190840650 ## File path: site/docs/latest/cookbooks/compaction.md ## @@ -0,0 +1,113 @@ +--- +title: Topic compaction

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190843762 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -522,18 +541,55 @@ while

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190840793 ## File path: site/docs/latest/cookbooks/compaction.md ## @@ -0,0 +1,113 @@ +--- +title: Topic compaction

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190840343 ## File path: site/docs/latest/cookbooks/compaction.md ## @@ -0,0 +1,113 @@ +--- +title: Topic compaction

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190843622 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -522,18 +541,55 @@ while

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190841526 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -522,18 +541,55 @@ while

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190840491 ## File path: site/docs/latest/cookbooks/compaction.md ## @@ -0,0 +1,113 @@ +--- +title: Topic compaction

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190843936 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -522,18 +541,55 @@ while

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190833328 ## File path: site/docs/latest/cookbooks/compaction.md ## @@ -0,0 +1,113 @@ +--- +title: Topic compaction

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190841330 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -522,18 +541,55 @@ while

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190841826 ## File path: site/docs/latest/getting-started/ConceptsAndArchitecture.md ## @@ -522,18 +541,55 @@ while

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190832046 ## File path: site/_data/cli/pulsar.yaml ## @@ -65,6 +65,9 @@ commands: options: - flags: -t,

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190832676 ## File path: site/docs/latest/cookbooks/compaction.md ## @@ -0,0 +1,113 @@ +--- +title: Topic compaction

[GitHub] ivankelly commented on a change in pull request #1466: Topic compaction documentation

2018-05-25 Thread GitBox
ivankelly commented on a change in pull request #1466: Topic compaction documentation URL: https://github.com/apache/incubator-pulsar/pull/1466#discussion_r190833665 ## File path: site/docs/latest/cookbooks/compaction.md ## @@ -0,0 +1,113 @@ +--- +title: Topic compaction

[incubator-pulsar] branch asf-site updated: Updated site at revision e249493

2018-05-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new c7a7db4 Updated site at revision

[GitHub] sijie commented on issue #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
sijie commented on issue #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844#issuecomment-391959885 I am also updating the bk dependencies. and will use 4.7.1 in this PR. so hold on merging this until bk's change is merged.

[GitHub] sijie commented on issue #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
sijie commented on issue #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844#issuecomment-391959671 @srkukarni @jerrypeng ^^ This is an automated message from the Apache Git

[GitHub] sijie opened a new pull request #1844: Update pulsar netty/grpc dependencies

2018-05-25 Thread GitBox
sijie opened a new pull request #1844: Update pulsar netty/grpc dependencies URL: https://github.com/apache/incubator-pulsar/pull/1844 *Motivation* apache/pulsar#1816 breaks the pulsar functions running in process mode. This because it removes the shading and introduces the