[GitHub] sijie commented on issue #1886: Underreplicated ledgers did not refresh when bookie was recovered

sijie commented on issue #1886: Underreplicated ledgers did not refresh when bookie was recovered URL: https://github.com/apache/incubator-pulsar/issues/1886#issuecomment-393759060 how many ledgers are marked as underreplicated? and what is the amount of data?

[GitHub] srkukarni commented on issue #1884: Made the logging file names uniform accross threaded and process modes

srkukarni commented on issue #1884: Made the logging file names uniform accross threaded and process modes URL: https://github.com/apache/incubator-pulsar/pull/1884#issuecomment-393755334 retest this please This is an

[GitHub] bardock opened a new issue #1886: Underreplicated ledgers did not refresh when bookie was recovered

bardock opened a new issue #1886: Underreplicated ledgers did not refresh when bookie was recovered URL: https://github.com/apache/incubator-pulsar/issues/1886 Some bookies were down for about 2 hours and their ledgers were marked as underreplicated. When bookies went up again, the list

[GitHub] srkukarni commented on issue #1884: Made the logging file names uniform accross threaded and process modes

srkukarni commented on issue #1884: Made the logging file names uniform accross threaded and process modes URL: https://github.com/apache/incubator-pulsar/pull/1884#issuecomment-393750778 retest this please This is an

[GitHub] jerrypeng commented on issue #1885: allow users to specify message timeout for functions

jerrypeng commented on issue #1885: allow users to specify message timeout for functions URL: https://github.com/apache/incubator-pulsar/pull/1885#issuecomment-393731450 @srkukarni please review This is an automated

[GitHub] jerrypeng opened a new pull request #1885: allow users to specify message timeout for functions

jerrypeng opened a new pull request #1885: allow users to specify message timeout for functions URL: https://github.com/apache/incubator-pulsar/pull/1885 To support various types of processing guarantees This is an

[GitHub] srkukarni commented on issue #1884: Made the logging file names uniform accross threaded and process modes

srkukarni commented on issue #1884: Made the logging file names uniform accross threaded and process modes URL: https://github.com/apache/incubator-pulsar/pull/1884#issuecomment-393728885 @sijie @jerrypeng This is an

[GitHub] srkukarni opened a new pull request #1884: Made the logging file names uniform accross threaded and process modes

srkukarni opened a new pull request #1884: Made the logging file names uniform accross threaded and process modes URL: https://github.com/apache/incubator-pulsar/pull/1884 ### Motivation Explain here the context, and why you're making that change. What is the problem you're

[GitHub] jerrypeng commented on issue #1880: removing allowing users set subscription type

jerrypeng commented on issue #1880: removing allowing users set subscription type URL: https://github.com/apache/incubator-pulsar/pull/1880#issuecomment-393727769 retest this please This is an automated message from the

[incubator-pulsar] branch master updated: [functions] Dont shade log4j2 in java runtime instance (#1881)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fc3c1b3 [functions] Dont shade

[GitHub] jerrypeng closed pull request #1881: [functions] Dont shade log4j2 in java runtime instance

jerrypeng closed pull request #1881: [functions] Dont shade log4j2 in java runtime instance URL: https://github.com/apache/incubator-pulsar/pull/1881 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] srkukarni commented on issue #1883: All user supplied arguments have to be properly typed

srkukarni commented on issue #1883: All user supplied arguments have to be properly typed URL: https://github.com/apache/incubator-pulsar/pull/1883#issuecomment-393721014 @jerrypeng This is an automated message from the

[GitHub] srkukarni commented on issue #1883: All user supplied arguments have to be properly typed

srkukarni commented on issue #1883: All user supplied arguments have to be properly typed URL: https://github.com/apache/incubator-pulsar/pull/1883#issuecomment-393721035 @sijie This is an automated message from the Apache

[GitHub] srkukarni opened a new pull request #1883: All user supplied arguments have to be properly typed

srkukarni opened a new pull request #1883: All user supplied arguments have to be properly typed URL: https://github.com/apache/incubator-pulsar/pull/1883 ### Motivation This is to avoid any kind of exceptions while using python pulsar libraries which expect variables to be typed

[GitHub] merlimat opened a new pull request #1882: Fixed event time metadata on batched messages

merlimat opened a new pull request #1882: Fixed event time metadata on batched messages URL: https://github.com/apache/incubator-pulsar/pull/1882 ### Motivation When messages are being published in batches, the event time is not reflected correctly. This is also more important

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-393697376 retest this please This is an automated message from the Apache Git Service. To respond

[incubator-pulsar] branch master updated: If tenant/namespace are not specified, infer public/default (#1879)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ec535b6 If tenant/namespace are

[GitHub] jerrypeng closed pull request #1879: If tenant/namespace are not specified, infer public/default

jerrypeng closed pull request #1879: If tenant/namespace are not specified, infer public/default URL: https://github.com/apache/incubator-pulsar/pull/1879 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Make sure that output_bytes are of type bytes (#1878)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4a5bd6c Make sure that

[GitHub] jerrypeng closed pull request #1878: Make sure that output_bytes are of type bytes

jerrypeng closed pull request #1878: Make sure that output_bytes are of type bytes URL: https://github.com/apache/incubator-pulsar/pull/1878 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] srkukarni commented on issue #1881: [functions] Dont shade log4j2 in java runtime instance

srkukarni commented on issue #1881: [functions] Dont shade log4j2 in java runtime instance URL: https://github.com/apache/incubator-pulsar/pull/1881#issuecomment-393708541 retest this please This is an automated message from

[GitHub] jerrypeng commented on issue #1880: removing allowing users set subscription type

jerrypeng commented on issue #1880: removing allowing users set subscription type URL: https://github.com/apache/incubator-pulsar/pull/1880#issuecomment-393700185 retest this please This is an automated message from the

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-391073380 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1743: ByteBuffer schema

lucperkins commented on issue #1743: ByteBuffer schema URL: https://github.com/apache/incubator-pulsar/pull/1743#issuecomment-391440229 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] lucperkins commented on issue #1838: Pulsar Go client docs

lucperkins commented on issue #1838: Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838#issuecomment-393697231 retest this please This is an automated message from the Apache Git Service. To

[GitHub] sijie opened a new pull request #1881: [functions] Dont shade log4j2 in java runtime instance

sijie opened a new pull request #1881: [functions] Dont shade log4j2 in java runtime instance URL: https://github.com/apache/incubator-pulsar/pull/1881 *Motivation* #1849 shade the dependencies in java instance uber jar. However it shades the log4j2, which causes functions

[GitHub] jerrypeng closed pull request #1869: adding CmdFunctions unit tests and clean up

jerrypeng closed pull request #1869: adding CmdFunctions unit tests and clean up URL: https://github.com/apache/incubator-pulsar/pull/1869 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: adding CmdFunctions unit tests and clean up (#1869)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 866bbec adding CmdFunctions unit

[GitHub] jerrypeng opened a new pull request #1880: removing allowing users set subscription type

jerrypeng opened a new pull request #1880: removing allowing users set subscription type URL: https://github.com/apache/incubator-pulsar/pull/1880 To simply using functions, we will not allow users to set the subscription type

[GitHub] jerrypeng commented on issue #1880: removing allowing users set subscription type

jerrypeng commented on issue #1880: removing allowing users set subscription type URL: https://github.com/apache/incubator-pulsar/pull/1880#issuecomment-393681395 @srkukarni please review This is an automated message from

[GitHub] sijie commented on a change in pull request #1869: adding CmdFunctions unit tests and clean up

sijie commented on a change in pull request #1869: adding CmdFunctions unit tests and clean up URL: https://github.com/apache/incubator-pulsar/pull/1869#discussion_r192238194 ## File path: pulsar-client-tools-test/src/test/java/org/apache/pulsar/admin/cli/CmdFunctionsTest.java

[GitHub] jerrypeng commented on issue #1869: adding CmdFunctions unit tests and clean up

jerrypeng commented on issue #1869: adding CmdFunctions unit tests and clean up URL: https://github.com/apache/incubator-pulsar/pull/1869#issuecomment-393638216 retest this please This is an automated message from the Apache

[GitHub] srkukarni commented on issue #1879: If tenant/namespace are not specified, infer public/default

srkukarni commented on issue #1879: If tenant/namespace are not specified, infer public/default URL: https://github.com/apache/incubator-pulsar/pull/1879#issuecomment-393635877 @sijie @jerrypeng This is an automated message

[GitHub] srkukarni opened a new pull request #1879: If tenant/namespace are not specified, infer public/default

srkukarni opened a new pull request #1879: If tenant/namespace are not specified, infer public/default URL: https://github.com/apache/incubator-pulsar/pull/1879 ### Motivation For a bunch of functions/sources/sinks commands, if user does not specify tenant/namespace, we infer them

[GitHub] srkukarni commented on issue #1878: Make sure that output_bytes are of type bytes

srkukarni commented on issue #1878: Make sure that output_bytes are of type bytes URL: https://github.com/apache/incubator-pulsar/pull/1878#issuecomment-393628438 @sijie @jerrypeng This is an automated message from the

[GitHub] srkukarni opened a new pull request #1878: Make sure that output_bytes are of type bytes

srkukarni opened a new pull request #1878: Make sure that output_bytes are of type bytes URL: https://github.com/apache/incubator-pulsar/pull/1878 ### Motivation User Defined Serde's might behave unexpectedly, so convert the output of serde to bytes before writing to pulsar

[GitHub] Audace commented on issue #1875: Problems with Persistent Topic stats

Audace commented on issue #1875: Problems with Persistent Topic stats URL: https://github.com/apache/incubator-pulsar/issues/1875#issuecomment-393619284 Ah that’s helpful. So in that case if the consumer receives 1000 messages in a batch, it will be 0.0 until all 1000 are processed and

[incubator-pulsar] branch master updated: When offloading to S3 add version information (#1876)

This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 77d936e When offloading to S3 add

[GitHub] sijie closed pull request #1876: When offloading to S3 add version information

sijie closed pull request #1876: When offloading to S3 add version information URL: https://github.com/apache/incubator-pulsar/pull/1876 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] merlimat commented on issue #1875: Problems with Persistent Topic stats

merlimat commented on issue #1875: Problems with Persistent Topic stats URL: https://github.com/apache/incubator-pulsar/issues/1875#issuecomment-393615109 @Audace I cannot see this problem here. Stats are looking correct to me. Just try to do a simple test: from 3 different consoles,

[incubator-pulsar] branch master updated: Fix REST APIs provided by Pulsar proxy (#1862)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 13ad7a6 Fix REST APIs provided by

[GitHub] merlimat closed pull request #1862: Fix REST APIs provided by Pulsar proxy

merlimat closed pull request #1862: Fix REST APIs provided by Pulsar proxy URL: https://github.com/apache/incubator-pulsar/pull/1862 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Audace commented on issue #1875: Problems with Persistent Topic stats

Audace commented on issue #1875: Problems with Persistent Topic stats URL: https://github.com/apache/incubator-pulsar/issues/1875#issuecomment-393604518 This occurs on a per consumer basis. When a consumer first subscribes to a topic, their `msgRateOut` is correctly transmitted and

[GitHub] Audace commented on issue #1875: Problems with Persistent Topic stats

Audace commented on issue #1875: Problems with Persistent Topic stats URL: https://github.com/apache/incubator-pulsar/issues/1875#issuecomment-393604518 This occurs for on a consumer basis. When a consumer first subscribes to a topic, their `msgRateOut` is correctly transmitted and

[incubator-pulsar] branch master updated: CLI for offload (#1865)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 06f9e2d CLI for offload (#1865)

[GitHub] merlimat closed pull request #1865: CLI for offload

merlimat closed pull request #1865: CLI for offload URL: https://github.com/apache/incubator-pulsar/pull/1865 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-pulsar] branch master updated: Disable verbose on git maven plugin (#1877)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6896f8c Disable verbose on git maven

[GitHub] merlimat closed pull request #1877: Disable verbose on git maven plugin

merlimat closed pull request #1877: Disable verbose on git maven plugin URL: https://github.com/apache/incubator-pulsar/pull/1877 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on a change in pull request #1858: Cpp client: add readCompacted in consumer config

merlimat commented on a change in pull request #1858: Cpp client: add readCompacted in consumer config URL: https://github.com/apache/incubator-pulsar/pull/1858#discussion_r192163363 ## File path: pulsar-client-cpp/tests/ConsumerConfigurationTest.cc ## @@ -0,0 +1,105 @@

[GitHub] jerrypeng closed pull request #1874: fix for python config validation

jerrypeng closed pull request #1874: fix for python config validation URL: https://github.com/apache/incubator-pulsar/pull/1874 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: fix for python config validation (#1874)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a1ffa7f fix for python config

[GitHub] ivankelly commented on a change in pull request #1865: CLI for offload

ivankelly commented on a change in pull request #1865: CLI for offload URL: https://github.com/apache/incubator-pulsar/pull/1865#discussion_r192134097 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java ## @@ -614,6 +618,93 @@ void

[GitHub] ivankelly commented on a change in pull request #1865: CLI for offload

ivankelly commented on a change in pull request #1865: CLI for offload URL: https://github.com/apache/incubator-pulsar/pull/1865#discussion_r192133939 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java ## @@ -614,6 +618,93 @@ void

[GitHub] ivankelly opened a new pull request #1877: Disable verbose on git maven plugin

ivankelly opened a new pull request #1877: Disable verbose on git maven plugin URL: https://github.com/apache/incubator-pulsar/pull/1877 It's very noisy. This is an automated message from the Apache Git Service. To

[GitHub] ivankelly opened a new pull request #1876: When offloading to S3 add version information

ivankelly opened a new pull request #1876: When offloading to S3 add version information URL: https://github.com/apache/incubator-pulsar/pull/1876 When we offload ledgers to S3, we create 2 objects, an index and a data object. This patch adds version information for the format, the

[GitHub] massakam commented on issue #1862: Fix REST APIs provided by Pulsar proxy

massakam commented on issue #1862: Fix REST APIs provided by Pulsar proxy URL: https://github.com/apache/incubator-pulsar/pull/1862#issuecomment-393554800 > Finally, I think we should fix this issue for 2.0.1 patch release, since right now the proxy would fail to start if the broker url is

[GitHub] massakam commented on issue #1862: Fix REST APIs provided by Pulsar proxy

massakam commented on issue #1862: Fix REST APIs provided by Pulsar proxy URL: https://github.com/apache/incubator-pulsar/pull/1862#issuecomment-393554360 @merlimat Modified AdminProxyHandler to handle HTTP connection in the same way as Pulsar wire protocol. Would you review again?

[GitHub] Audace opened a new issue #1875: Problems with Persistent Topic stats

Audace opened a new issue #1875: Problems with Persistent Topic stats URL: https://github.com/apache/incubator-pulsar/issues/1875 Expected behavior Every 60 seconds, I expect an API requests to the stats endpoint to reflect refreshed statistics. Furthermore, I expect both the

[GitHub] massakam commented on issue #1862: Fix REST APIs provided by Pulsar proxy

massakam commented on issue #1862: Fix REST APIs provided by Pulsar proxy URL: https://github.com/apache/incubator-pulsar/pull/1862#issuecomment-393451429 Uhm... it makes sense. I will reconsider the way to solve this problem.