[GitHub] jerrypeng commented on a change in pull request #2120: shading dependencies in pulsar client

2018-07-09 Thread GitBox
jerrypeng commented on a change in pull request #2120: shading dependencies in pulsar client URL: https://github.com/apache/incubator-pulsar/pull/2120#discussion_r201219257 ## File path: pulsar-client-shaded/pom.xml ## @@ -217,6 +220,10 @@ org.objenesis

[GitHub] jerrypeng commented on issue #2124: patching CmdSources and adding unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2124: patching CmdSources and adding unit tests URL: https://github.com/apache/incubator-pulsar/pull/2124#issuecomment-403701034 retest this please This is an automated message from the Apache

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-09 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-403677886 retest this please This is an automated

[GitHub] merlimat commented on a change in pull request #2120: shading dependencies in pulsar client

2018-07-09 Thread GitBox
merlimat commented on a change in pull request #2120: shading dependencies in pulsar client URL: https://github.com/apache/incubator-pulsar/pull/2120#discussion_r201199590 ## File path: pulsar-client-shaded/pom.xml ## @@ -217,6 +220,10 @@ org.objenesis

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-09 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-403667638 retest this please This is an

[GitHub] yush1ga closed pull request #2115: Fix Creation of ClientOptions in Go Documentation

2018-07-09 Thread GitBox
yush1ga closed pull request #2115: Fix Creation of ClientOptions in Go Documentation URL: https://github.com/apache/incubator-pulsar/pull/2115 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: add { in creation of ClientOptions (#2115)

2018-07-09 Thread yushiga
This is an automated email from the ASF dual-hosted git repository. yushiga pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a92ac3d add { in creation of

[GitHub] jerrypeng opened a new pull request #2124: patching CmdSources and adding unit tests

2018-07-09 Thread GitBox
jerrypeng opened a new pull request #2124: patching CmdSources and adding unit tests URL: https://github.com/apache/incubator-pulsar/pull/2124 Patching some bugs in the source CLI and also adding extensive unit tests This is

[GitHub] jerrypeng commented on issue #2120: shading dependencies in pulsar client

2018-07-09 Thread GitBox
jerrypeng commented on issue #2120: shading dependencies in pulsar client URL: https://github.com/apache/incubator-pulsar/pull/2120#issuecomment-403664891 retest this please This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #2120: shading dependencies in pulsar client

2018-07-09 Thread GitBox
jerrypeng commented on issue #2120: shading dependencies in pulsar client URL: https://github.com/apache/incubator-pulsar/pull/2120#issuecomment-403662301 retest this please This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #2120: shading dependencies in pulsar client

2018-07-09 Thread GitBox
jerrypeng commented on issue #2120: shading dependencies in pulsar client URL: https://github.com/apache/incubator-pulsar/pull/2120#issuecomment-403662216 retest this please This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #2120: shading dependencies in pulsar client

2018-07-09 Thread GitBox
jerrypeng commented on issue #2120: shading dependencies in pulsar client URL: https://github.com/apache/incubator-pulsar/pull/2120#issuecomment-403661301 retest this please This is an automated message from the Apache Git

[GitHub] rdhabalia commented on issue #1462: Delayed acks impl

2018-07-09 Thread GitBox
rdhabalia commented on issue #1462: Delayed acks impl URL: https://github.com/apache/incubator-pulsar/pull/1462#issuecomment-403660668 > The code should already be sending 1 single ack if the broker is < 2.0 : I see, I missed it to check. I think the issue is that I have

[GitHub] jerrypeng closed pull request #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng closed pull request #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: patching CmdSink and adding extensive unit tests (#2107)

2018-07-09 Thread jerrypeng
This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8b206c3 patching CmdSink and

[GitHub] merlimat commented on issue #1462: Delayed acks impl

2018-07-09 Thread GitBox
merlimat commented on issue #1462: Delayed acks impl URL: https://github.com/apache/incubator-pulsar/pull/1462#issuecomment-403657386 @rdhabalia I did the test by using : * Broker 1.22.1 * Producer 1.22 (perf-producer) * Consumer from master (2.2-SNAPSHOT) (perf-consumer)

[GitHub] aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore

2018-07-09 Thread GitBox
aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore URL: https://github.com/apache/incubator-pulsar/pull/2123#issuecomment-403657198 retest this please This is an automated message from the Apache

[GitHub] hrsakai commented on issue #2086: Add std=c99 to CMAKE_C_FLAGS to avoid compile error with gcc-4.8

2018-07-09 Thread GitBox
hrsakai commented on issue #2086: Add std=c99 to CMAKE_C_FLAGS to avoid compile error with gcc-4.8 URL: https://github.com/apache/incubator-pulsar/pull/2086#issuecomment-403656917 retest this please This is an automated

[GitHub] nkurihar commented on issue #2115: Fix Creation of ClientOptions in Go Documentation

2018-07-09 Thread GitBox
nkurihar commented on issue #2115: Fix Creation of ClientOptions in Go Documentation URL: https://github.com/apache/incubator-pulsar/pull/2115#issuecomment-403656458 retest this please This is an automated message from the

[GitHub] aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore

2018-07-09 Thread GitBox
aahmed-se commented on issue #2123: Add pulsar python wheelhouse to gitignore URL: https://github.com/apache/incubator-pulsar/pull/2123#issuecomment-403654946 please retest this This is an automated message from the Apache

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403652306 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1462: Delayed acks impl

2018-07-09 Thread GitBox
merlimat commented on issue #1462: Delayed acks impl URL: https://github.com/apache/incubator-pulsar/pull/1462#issuecomment-403645453 @rdhabalia The code should already be sending 1 single ack if the broker is < 2.0 :

[GitHub] aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-09 Thread GitBox
aahmed-se commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-403643909 Implemented autocloseable This is an

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403643826 retest this please This is an automated message from the

[GitHub] aahmed-se commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-09 Thread GitBox
aahmed-se commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r201171034 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403642226 retest this please This is an automated message from the

[GitHub] aahmed-se opened a new pull request #2123: Add pulsar python to gitignore

2018-07-09 Thread GitBox
aahmed-se opened a new pull request #2123: Add pulsar python to gitignore URL: https://github.com/apache/incubator-pulsar/pull/2123 wheelhouse directory should be added to gitignore. This is an automated message from the

[incubator-pulsar] branch master updated: Make it possible to set idle WebSocket session timeout period (#2118)

2018-07-09 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b113e90 Make it possible to set idle

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403640322 retest this please This is an automated message from the

[GitHub] zubchenok commented on issue #2122: Allow configuring backoff strategy on clients

2018-07-09 Thread GitBox
zubchenok commented on issue #2122: Allow configuring backoff strategy on clients URL: https://github.com/apache/incubator-pulsar/issues/2122#issuecomment-403639775 When it happens during bundles movement to another broker, it will be much better to wait until the correspondent bundles

[GitHub] merlimat commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-09 Thread GitBox
merlimat commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r201165169 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java

[GitHub] sijie opened a new issue #2122: Allow configuring backoff strategy on clients

2018-07-09 Thread GitBox
sijie opened a new issue #2122: Allow configuring backoff strategy on clients URL: https://github.com/apache/incubator-pulsar/issues/2122 *Problem* Currently the backoff strategy on pulsar clients are hardcoded with 100ms backoff. The backoff settings are too aggressive when you

[GitHub] merlimat commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-09 Thread GitBox
merlimat commented on a change in pull request #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#discussion_r201165271 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarStandalone.java

[GitHub] sijie opened a new issue #2121: Improve logging around "Namespace not served by this instance"

2018-07-09 Thread GitBox
sijie opened a new issue #2121: Improve logging around "Namespace not served by this instance" URL: https://github.com/apache/incubator-pulsar/issues/2121 *Namespace not served by this instance* is a bit confusing. it should be something like "namespace bundles not served by this

[incubator-pulsar] branch master updated: change ID() to Payload (#2117)

2018-07-09 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new cd35677 change ID() to Payload

[GitHub] merlimat closed pull request #2117: Fix Output In Pulsar Go Client Documentation

2018-07-09 Thread GitBox
merlimat closed pull request #2117: Fix Output In Pulsar Go Client Documentation URL: https://github.com/apache/incubator-pulsar/pull/2117 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] jerrypeng opened a new pull request #2120: shading dependencies in pulsar client

2018-07-09 Thread GitBox
jerrypeng opened a new pull request #2120: shading dependencies in pulsar client URL: https://github.com/apache/incubator-pulsar/pull/2120 Minimizing the number of dependencies in Pulsar client by shading them This is an

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403615988 retest this please This is an automated message from the

[GitHub] rdhabalia closed pull request #2113: derive worker-host and id at runtime if not provided

2018-07-09 Thread GitBox
rdhabalia closed pull request #2113: derive worker-host and id at runtime if not provided URL: https://github.com/apache/incubator-pulsar/pull/2113 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: derive worker-host and id at runtime if not provided (#2113)

2018-07-09 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7047146 derive worker-host and id

[GitHub] sijie commented on issue #2025: [WiP] Allow non-pesistent topics to be retrieved along with persistent ones from the "GetTopicsOfNamespace" method

2018-07-09 Thread GitBox
sijie commented on issue #2025: [WiP] Allow non-pesistent topics to be retrieved along with persistent ones from the "GetTopicsOfNamespace" method URL: https://github.com/apache/incubator-pulsar/pull/2025#issuecomment-403604892 @merlimat @jiazhai can you review this PR and give @gordeevbr

[GitHub] sijie commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar

2018-07-09 Thread GitBox
sijie commented on issue #2080: Extract out common code from standalone and build Embedded Pulsar URL: https://github.com/apache/incubator-pulsar/pull/2080#issuecomment-403604085 @jerrypeng @merlimat can you guys review this?

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403596474 retest this please This is an automated message from the

[GitHub] rdhabalia removed a comment on issue #2112: Function: REST and CLI to get list of workers in cluster

2018-07-09 Thread GitBox
rdhabalia removed a comment on issue #2112: Function: REST and CLI to get list of workers in cluster URL: https://github.com/apache/incubator-pulsar/pull/2112#issuecomment-403586889 retest this please This is an automated

[GitHub] rdhabalia commented on issue #2112: Function: REST and CLI to get list of workers in cluster

2018-07-09 Thread GitBox
rdhabalia commented on issue #2112: Function: REST and CLI to get list of workers in cluster URL: https://github.com/apache/incubator-pulsar/pull/2112#issuecomment-403586889 retest this please This is an automated message

[GitHub] rdhabalia commented on issue #2113: derive worker-host and id at runtime if not provided

2018-07-09 Thread GitBox
rdhabalia commented on issue #2113: derive worker-host and id at runtime if not provided URL: https://github.com/apache/incubator-pulsar/pull/2113#issuecomment-403585701 retest this please This is an automated message from

[GitHub] rdhabalia removed a comment on issue #2113: derive worker-host and id at runtime if not provided

2018-07-09 Thread GitBox
rdhabalia removed a comment on issue #2113: derive worker-host and id at runtime if not provided URL: https://github.com/apache/incubator-pulsar/pull/2113#issuecomment-403585701 retest this please This is an automated

[GitHub] jerrypeng removed a comment on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng removed a comment on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403570995 rebuild this please This is an automated message

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403573676 retest this please This is an automated message from the

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403570995 rebuild this please This is an automated message from the

[GitHub] merlimat commented on issue #2117: Fix Output In Pulsar Go Client Documentation

2018-07-09 Thread GitBox
merlimat commented on issue #2117: Fix Output In Pulsar Go Client Documentation URL: https://github.com/apache/incubator-pulsar/pull/2117#issuecomment-403539776 retest this please This is an automated message from the Apache

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403532922 retest this please This is an automated message from the

[GitHub] jerrypeng removed a comment on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng removed a comment on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403532830 retest please This is an automated message from

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403532830 retest please This is an automated message from the Apache

[GitHub] ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer URL: https://github.com/apache/incubator-pulsar/pull/2103#discussion_r200952616 ## File path:

[GitHub] ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer URL: https://github.com/apache/incubator-pulsar/pull/2103#discussion_r200950535 ## File path:

[GitHub] ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer URL: https://github.com/apache/incubator-pulsar/pull/2103#discussion_r200954861 ## File path:

[GitHub] ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer URL: https://github.com/apache/incubator-pulsar/pull/2103#discussion_r200955734 ## File path:

[GitHub] ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2103: Issue 1433: Expose batch flushAsync() and flush() methods in Producer URL: https://github.com/apache/incubator-pulsar/pull/2103#discussion_r200953979 ## File path:

[GitHub] sijie opened a new issue #2119: TopicPatternSubscription doesn't work through proxy

2018-07-09 Thread GitBox
sijie opened a new issue #2119: TopicPatternSubscription doesn't work through proxy URL: https://github.com/apache/incubator-pulsar/issues/2119 Expected behavior pattern subscription should work with proxy Actual behavior pattern subscription doesn't work

[GitHub] sijie commented on issue #2119: TopicPatternSubscription doesn't work through proxy

2018-07-09 Thread GitBox
sijie commented on issue #2119: TopicPatternSubscription doesn't work through proxy URL: https://github.com/apache/incubator-pulsar/issues/2119#issuecomment-403438281 It is caught by a cluster-mode integration test. This

[GitHub] massakam opened a new pull request #2118: Make it possible to set idle WebSocket session timeout period

2018-07-09 Thread GitBox
massakam opened a new pull request #2118: Make it possible to set idle WebSocket session timeout period URL: https://github.com/apache/incubator-pulsar/pull/2118 ### Motivation WebSocket session is automatically closed when the idle state lasts 5 minutes (default value of jetty).

[GitHub] aahmed-se commented on issue #2101: [WIP] Migrate compaction test to testcontainers

2018-07-09 Thread GitBox
aahmed-se commented on issue #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-403423400 Almost done with the migration gotten rid of the arquillian dependencies tests are not passing yet so have to debug a bit.

[GitHub] ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r200939801 ## File path:

[GitHub] ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r200938995 ## File path:

[GitHub] ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers

2018-07-09 Thread GitBox
ivankelly commented on a change in pull request #2101: [WIP] Migrate compaction test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r200940135 ## File path:

[GitHub] k2la commented on issue #2117: Fix Output In Pulsar Go Client Documentation

2018-07-09 Thread GitBox
k2la commented on issue #2117: Fix Output In Pulsar Go Client Documentation URL: https://github.com/apache/incubator-pulsar/pull/2117#issuecomment-403400335 retest this please This is an automated message from the Apache Git

[GitHub] rdhabalia commented on issue #1462: Delayed acks impl

2018-07-09 Thread GitBox
rdhabalia commented on issue #1462: Delayed acks impl URL: https://github.com/apache/incubator-pulsar/pull/1462#issuecomment-403400100 @merlimat any update on it? This is an automated message from the Apache Git Service. To

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403396972 retest this please This is an automated message from the

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403390941 retest this please This is an automated message from the

[GitHub] sijie commented on issue #2111: Release resources for ZLib inflater/deflater when not used

2018-07-09 Thread GitBox
sijie commented on issue #2111: Release resources for ZLib inflater/deflater when not used URL: https://github.com/apache/incubator-pulsar/pull/2111#issuecomment-403391107 retest this please This is an automated message from

[incubator-pulsar] branch master updated: Make ack timeout work in asynchronous implementation of C++ consumer (#2087)

2018-07-09 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d81cd38 Make ack timeout work in

[GitHub] sijie closed pull request #2087: Make ack timeout work in asynchronous implementation of C++ consumer

2018-07-09 Thread GitBox
sijie closed pull request #2087: Make ack timeout work in asynchronous implementation of C++ consumer URL: https://github.com/apache/incubator-pulsar/pull/2087 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] k2la opened a new pull request #2117: Fix Output In Pulsar Go Client Documentation

2018-07-09 Thread GitBox
k2la opened a new pull request #2117: Fix Output In Pulsar Go Client Documentation URL: https://github.com/apache/incubator-pulsar/pull/2117 ### Motivation In http://pulsar.incubator.apache.org/docs/latest/clients/go/#Produceroperations , ``` producer.SendAsync(ctx,

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403382378 retest this please This is an automated message from the

[GitHub] jerrypeng removed a comment on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng removed a comment on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403382315 retest please This is an automated message from

[GitHub] jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests

2018-07-09 Thread GitBox
jerrypeng commented on issue #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#issuecomment-403382315 retest please This is an automated message from the Apache

[GitHub] k2la commented on issue #2115: Fix Creation of ClientOptions in Go Documentation

2018-07-09 Thread GitBox
k2la commented on issue #2115: Fix Creation of ClientOptions in Go Documentation URL: https://github.com/apache/incubator-pulsar/pull/2115#issuecomment-403373065 retest this please This is an automated message from the Apache