[GitHub] srkukarni closed pull request #2427: Fix InputTopic Submission for Creating Sink

2018-08-22 Thread GitBox
srkukarni closed pull request #2427: Fix InputTopic Submission for Creating Sink URL: https://github.com/apache/incubator-pulsar/pull/2427 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Fix InputTopic Submission for Creating Sink (#2427)

2018-08-22 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4694e6e Fix InputTopic Submission

[GitHub] srkukarni commented on issue #2427: Fix InputTopic Submission for Creating Sink

2018-08-22 Thread GitBox
srkukarni commented on issue #2427: Fix InputTopic Submission for Creating Sink URL: https://github.com/apache/incubator-pulsar/pull/2427#issuecomment-415266096 run integration tests This is an automated message from the

[GitHub] srkukarni commented on issue #2427: Fix InputTopic Submission for Creating Sink

2018-08-22 Thread GitBox
srkukarni commented on issue #2427: Fix InputTopic Submission for Creating Sink URL: https://github.com/apache/incubator-pulsar/pull/2427#issuecomment-415266032 run java8 tests This is an automated message from the Apache Git

[GitHub] jerrypeng opened a new pull request #2428: Package Presto with Pulsar for SQL integration

2018-08-22 Thread GitBox
jerrypeng opened a new pull request #2428: Package Presto with Pulsar for SQL integration URL: https://github.com/apache/incubator-pulsar/pull/2428 ### Motivation We would like a way for users to easily try out Pulsar Sql currently powered by Presto. To do so, lets package presto

[GitHub] aahmed-se opened a new pull request #2427: Fix InputTopic Submission for Creating Sink

2018-08-22 Thread GitBox
aahmed-se opened a new pull request #2427: Fix InputTopic Submission for Creating Sink URL: https://github.com/apache/incubator-pulsar/pull/2427 ### Motivation This fixes the input topic validation for submitting new sink functions.

[GitHub] rdhabalia commented on a change in pull request #2426: Added cli commands to get function cluster related information

2018-08-22 Thread GitBox
rdhabalia commented on a change in pull request #2426: Added cli commands to get function cluster related information URL: https://github.com/apache/incubator-pulsar/pull/2426#discussion_r212151326 ## File path:

[GitHub] rdhabalia commented on a change in pull request #2426: Added cli commands to get function cluster related information

2018-08-22 Thread GitBox
rdhabalia commented on a change in pull request #2426: Added cli commands to get function cluster related information URL: https://github.com/apache/incubator-pulsar/pull/2426#discussion_r212151116 ## File path:

[GitHub] rdhabalia commented on a change in pull request #2426: Added cli commands to get function cluster related information

2018-08-22 Thread GitBox
rdhabalia commented on a change in pull request #2426: Added cli commands to get function cluster related information URL: https://github.com/apache/incubator-pulsar/pull/2426#discussion_r212151001 ## File path:

[GitHub] srkukarni opened a new pull request #2426: Added cli commands to get function cluster related information

2018-08-22 Thread GitBox
srkukarni opened a new pull request #2426: Added cli commands to get function cluster related information URL: https://github.com/apache/incubator-pulsar/pull/2426 ### Motivation Info like all workers in the cluster, cluster leader and function-assigments already had a endpoint,

[GitHub] srkukarni closed pull request #2421: Fix bug during user publish

2018-08-22 Thread GitBox
srkukarni closed pull request #2421: Fix bug during user publish URL: https://github.com/apache/incubator-pulsar/pull/2421 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Fix bug during user publish (#2421)

2018-08-22 Thread sanjeevrk
This is an automated email from the ASF dual-hosted git repository. sanjeevrk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 001445c Fix bug during user

[GitHub] merlimat opened a new pull request #2425: Standalone bookie should always advertise 'localhost' when running in docker container

2018-08-22 Thread GitBox
merlimat opened a new pull request #2425: Standalone bookie should always advertise 'localhost' when running in docker container URL: https://github.com/apache/incubator-pulsar/pull/2425 ### Motivation When pulsar standalone runs in normal mode, the bookie advertises itself with

[GitHub] jiazhai commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders

2018-08-22 Thread GitBox
jiazhai commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders URL: https://github.com/apache/incubator-pulsar/pull/2393#issuecomment-415208201 rerun integration tests This is an automated message

[GitHub] jiazhai commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders

2018-08-22 Thread GitBox
jiazhai commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders URL: https://github.com/apache/incubator-pulsar/pull/2393#issuecomment-415208136 @sijie lgtm. Seems There was an error in integration test.

[GitHub] sijie commented on issue #246: Android lambda exceptions for client

2018-08-22 Thread GitBox
sijie commented on issue #246: Android lambda exceptions for client URL: https://github.com/apache/incubator-pulsar/issues/246#issuecomment-415195148 the minimal requirement for java is java8. and there is a websocket proxy, so you can use websocket api.

[GitHub] sijie closed issue #246: Android lambda exceptions for client

2018-08-22 Thread GitBox
sijie closed issue #246: Android lambda exceptions for client URL: https://github.com/apache/incubator-pulsar/issues/246 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie closed issue #268: Intermittent SIGSEGV in RocksDB jnilib

2018-08-22 Thread GitBox
sijie closed issue #268: Intermittent SIGSEGV in RocksDB jnilib URL: https://github.com/apache/incubator-pulsar/issues/268 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #268: Intermittent SIGSEGV in RocksDB jnilib

2018-08-22 Thread GitBox
sijie commented on issue #268: Intermittent SIGSEGV in RocksDB jnilib URL: https://github.com/apache/incubator-pulsar/issues/268#issuecomment-415194814 the rocksdb version has been upgraded to latest rocksdb stable release. so close the issue for now. if it occurs, please open a new

[GitHub] sijie closed issue #324: high publish latency of Pulsar on HDD

2018-08-22 Thread GitBox
sijie closed issue #324: high publish latency of Pulsar on HDD URL: https://github.com/apache/incubator-pulsar/issues/324 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #324: high publish latency of Pulsar on HDD

2018-08-22 Thread GitBox
sijie commented on issue #324: high publish latency of Pulsar on HDD URL: https://github.com/apache/incubator-pulsar/issues/324#issuecomment-415193527 it seems that the question is answered. so close it now. please reopen it if there are more information provided.

[GitHub] sijie closed issue #411: Bookkeeper OOM

2018-08-22 Thread GitBox
sijie closed issue #411: Bookkeeper OOM URL: https://github.com/apache/incubator-pulsar/issues/411 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL

[GitHub] sijie commented on issue #411: Bookkeeper OOM

2018-08-22 Thread GitBox
sijie commented on issue #411: Bookkeeper OOM URL: https://github.com/apache/incubator-pulsar/issues/411#issuecomment-415191939 I think the question here is answered. Close this issue. We can open a new issue if we need to introduce the off-heap entry index map.

[GitHub] rdhabalia opened a new pull request #2424: Support heartbeat function for worker

2018-08-22 Thread GitBox
rdhabalia opened a new pull request #2424: Support heartbeat function for worker URL: https://github.com/apache/incubator-pulsar/pull/2424 ### Motivation We want to setup a sanity-test for each worker by submitting a function and perform a heartbeat test for the worker. We have

[GitHub] srkukarni commented on issue #2421: Fix bug during user publish

2018-08-22 Thread GitBox
srkukarni commented on issue #2421: Fix bug during user publish URL: https://github.com/apache/incubator-pulsar/pull/2421#issuecomment-415135472 run integration tests This is an automated message from the Apache Git Service.

[GitHub] srkukarni commented on a change in pull request #2421: Fix bug during user publish

2018-08-22 Thread GitBox
srkukarni commented on a change in pull request #2421: Fix bug during user publish URL: https://github.com/apache/incubator-pulsar/pull/2421#discussion_r212049015 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/ContextImpl.java

[incubator-pulsar] branch master updated: Fix: authorization while redirecting function admin call (#2416)

2018-08-22 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new cc60027 Fix: authorization while

[GitHub] rdhabalia closed pull request #2416: Fix: authorization while redirecting function admin call

2018-08-22 Thread GitBox
rdhabalia closed pull request #2416: Fix: authorization while redirecting function admin call URL: https://github.com/apache/incubator-pulsar/pull/2416 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders

2018-08-22 Thread GitBox
sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders URL: https://github.com/apache/incubator-pulsar/pull/2393#issuecomment-415120430 run integration tests This is an automated message from

[GitHub] merlimat closed pull request #2412: Allow to configure number of IO and managed ledger threads

2018-08-22 Thread GitBox
merlimat closed pull request #2412: Allow to configure number of IO and managed ledger threads URL: https://github.com/apache/incubator-pulsar/pull/2412 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Allow to configure number of IO and managed ledger threads (#2412)

2018-08-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ef37890 Allow to configure number of

[GitHub] merlimat closed pull request #2420: [client] add properties to producer for cpp & python client

2018-08-22 Thread GitBox
merlimat closed pull request #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: [client] add properties to producer for cpp & python client (#2420)

2018-08-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 834104b [client] add properties to

[GitHub] sijie commented on issue #2400: PIP-22: Dead Letter Topic

2018-08-22 Thread GitBox
sijie commented on issue #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#issuecomment-415092990 run java8 tests This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #2406: Fix flake in DiscoveryServiceTest (#1081)

2018-08-22 Thread GitBox
sijie commented on issue #2406: Fix flake in DiscoveryServiceTest (#1081) URL: https://github.com/apache/incubator-pulsar/pull/2406#issuecomment-415092501 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #2412: Allow to configure number of IO and managed ledger threads

2018-08-22 Thread GitBox
sijie commented on issue #2412: Allow to configure number of IO and managed ledger threads URL: https://github.com/apache/incubator-pulsar/pull/2412#issuecomment-415090834 run cpp tests This is an automated message from the

[GitHub] sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders

2018-08-22 Thread GitBox
sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders URL: https://github.com/apache/incubator-pulsar/pull/2393#issuecomment-415090383 run integration tests This is an automated message from

[GitHub] sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders

2018-08-22 Thread GitBox
sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders URL: https://github.com/apache/incubator-pulsar/pull/2393#issuecomment-414988559 @ivankelly @jiazhai please take a look at this PR This

[GitHub] sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders

2018-08-22 Thread GitBox
sijie commented on issue #2393: [tiered storage] Use NAR plugin to package offloaders URL: https://github.com/apache/incubator-pulsar/pull/2393#issuecomment-414987507 the integration tests were broken due to an empty driver name. 419b4784ba50c945a187a2192a4c1745920b95ea is the fix. This

[GitHub] sijie closed pull request #2419: [documentation] cherry-pick deploy-kubernetes documentation changes

2018-08-22 Thread GitBox
sijie closed pull request #2419: [documentation] cherry-pick deploy-kubernetes documentation changes URL: https://github.com/apache/incubator-pulsar/pull/2419 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: [documentation] cherry-pick deploy-kubernetes documentation changes (#2419)

2018-08-22 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new def32dd [documentation] cherry-pick

[GitHub] sijie commented on issue #2420: [client] add properties to producer for cpp & python client

2018-08-22 Thread GitBox
sijie commented on issue #2420: [client] add properties to producer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2420#issuecomment-414975009 @merlimat I addressed your comment. can you review it again?

[GitHub] sijie closed pull request #2423: [client] add properties to consumer for cpp & python client

2018-08-22 Thread GitBox
sijie closed pull request #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: [client] add properties to consumer for cpp & python client (#2423)

2018-08-22 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new eb897a8 [client] add properties to

[GitHub] codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic

2018-08-22 Thread GitBox
codelipenghui commented on a change in pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#discussion_r211872776 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/utils/Quorum.java ## @@ -0,0 +1,59 @@ +/** + *

[GitHub] sijie commented on issue #2400: PIP-22: Dead Letter Topic

2018-08-22 Thread GitBox
sijie commented on issue #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#issuecomment-414936483 overall looks good to me. @merlimat can you take a look at this? This is an

[GitHub] sijie commented on issue #2423: [client] add properties to consumer for cpp & python client

2018-08-22 Thread GitBox
sijie commented on issue #2423: [client] add properties to consumer for cpp & python client URL: https://github.com/apache/incubator-pulsar/pull/2423#issuecomment-414934284 @merlimat these two are independent PRs. either can go first.