[GitHub] merlimat closed pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-06 Thread GitBox
merlimat closed pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-06 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-419186303 It doesn't seem we're using `zookeeper-shell` tool in helm charts in `branch-2.1`. Let's merge this and backport to 2.1 and figure out

[GitHub] sijie closed pull request #2531: Typo in CSR generation docs (#2530)

2018-09-06 Thread GitBox
sijie closed pull request #2531: Typo in CSR generation docs (#2530) URL: https://github.com/apache/incubator-pulsar/pull/2531 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign p

[GitHub] sijie commented on issue #2531: Typo in CSR generation docs (#2530)

2018-09-06 Thread GitBox
sijie commented on issue #2531: Typo in CSR generation docs (#2530) URL: https://github.com/apache/incubator-pulsar/pull/2531#issuecomment-419185734 @ivankelly sorry I misread it. This is an automated message from the Apache G

[GitHub] sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419175699 > The current setting in github is to only allow the option to do "squash & rebase", so at least this is already en

[GitHub] merlimat commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
merlimat commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419171912 > Second, manage the commit message. when you click 'squash and merge' button, if you don't pay attention to c

[GitHub] sijie commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
sijie commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215680876 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env python

[GitHub] sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
sijie commented on issue #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#issuecomment-419144820 > In short, I think the root cause of the mess is not lack of tools but lack of clear policies. agreed. that

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215662458 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] sijie commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
sijie commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215659430 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env python

[GitHub] ivankelly commented on issue #2531: Typo in CSR generation docs (#2530)

2018-09-06 Thread GitBox
ivankelly commented on issue #2531: Typo in CSR generation docs (#2530) URL: https://github.com/apache/incubator-pulsar/pull/2531#issuecomment-419126414 @sijie I did. Are you asking if it's possible to do so? This is an automa

[GitHub] sijie commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
sijie commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215658513 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env python

[GitHub] merlimat closed issue #2521: Go client reader hang when processing backlog of ~6M messages

2018-09-06 Thread GitBox
merlimat closed issue #2521: Go client reader hang when processing backlog of ~6M messages URL: https://github.com/apache/incubator-pulsar/issues/2521 This is an automated message from the Apache Git Service. To respond to t

[GitHub] merlimat closed pull request #2527: [go] Ensure producer/consumer/reader keep a ref of client instance so it won't be finalized

2018-09-06 Thread GitBox
merlimat closed pull request #2527: [go] Ensure producer/consumer/reader keep a ref of client instance so it won't be finalized URL: https://github.com/apache/incubator-pulsar/pull/2527 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is display

[GitHub] merlimat closed pull request #2524: Reintroduce Aerospike connector

2018-09-06 Thread GitBox
merlimat closed pull request #2524: Reintroduce Aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2524 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pu

[GitHub] blutack commented on issue #2521: Go client reader hang when processing backlog of ~6M messages

2018-09-06 Thread GitBox
blutack commented on issue #2521: Go client reader hang when processing backlog of ~6M messages URL: https://github.com/apache/incubator-pulsar/issues/2521#issuecomment-419033519 That was impressively quick for a tricky bug! I can confirm the fix works at my end. --

[GitHub] ivankelly commented on issue #2531: Typo in CSR generation docs (#2530)

2018-09-06 Thread GitBox
ivankelly commented on issue #2531: Typo in CSR generation docs (#2530) URL: https://github.com/apache/incubator-pulsar/pull/2531#issuecomment-419023106 @peterbecker This is an automated message from the Apache Git Service. T

[GitHub] ivankelly opened a new pull request #2531: Typo in CSR generation docs (#2530)

2018-09-06 Thread GitBox
ivankelly opened a new pull request #2531: Typo in CSR generation docs (#2530) URL: https://github.com/apache/incubator-pulsar/pull/2531 The output file for CSR generation was .cert.pem rather than .csr.pem, which causes confusion. It should be .csr.pem --

[GitHub] ivankelly commented on issue #2530: Documentation issue: wrong file name in TLS instructions

2018-09-06 Thread GitBox
ivankelly commented on issue #2530: Documentation issue: wrong file name in TLS instructions URL: https://github.com/apache/incubator-pulsar/issues/2530#issuecomment-419021338 @peterbecker you're right. Will update. This is

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215535871 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215529911 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215531360 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215531397 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215533437 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215530698 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215531427 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-06 Thread GitBox
ivankelly commented on a change in pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526#discussion_r215530786 ## File path: dev/pulsar-merge-pr.py ## @@ -0,0 +1,699 @@ +#!/usr/bin/env py

[GitHub] sijie commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-06 Thread GitBox
sijie commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-419003115 @merlimat I think this change will break all the deployment scripts using `bin/pulsar zookeeper-shell`. see apache/bookkeeper#1660 --

[GitHub] sijie closed pull request #2506: TopicPatterns are now supported by python functions

2018-09-06 Thread GitBox
sijie closed pull request #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] peterbecker commented on issue #2530: Documentation issue: wrong file name in TLS instructions

2018-09-06 Thread GitBox
peterbecker commented on issue #2530: Documentation issue: wrong file name in TLS instructions URL: https://github.com/apache/incubator-pulsar/issues/2530#issuecomment-419002201 The page you link is the TLS auth page. Mine is the encryption one. You can follow the link on the page you lin

[GitHub] sijie closed pull request #2528: better way to estimate object size for sql

2018-09-06 Thread GitBox
sijie closed pull request #2528: better way to estimate object size for sql URL: https://github.com/apache/incubator-pulsar/pull/2528 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] sijie commented on issue #2524: Reintroduce Aerospike connector

2018-09-06 Thread GitBox
sijie commented on issue #2524: Reintroduce Aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2524#issuecomment-419001383 run cpp tests This is an automated message from the Apache Git Service. To respon

[GitHub] sijie commented on issue #2520: web rest api

2018-09-06 Thread GitBox
sijie commented on issue #2520: web rest api URL: https://github.com/apache/incubator-pulsar/issues/2520#issuecomment-418999348 @congbobo184 oh I see. that's a bug on loading swagger ui. will investigate how to address the issue. ---

[GitHub] sijie commented on issue #2530: Documentation issue: wrong file name in TLS instructions

2018-09-06 Thread GitBox
sijie commented on issue #2530: Documentation issue: wrong file name in TLS instructions URL: https://github.com/apache/incubator-pulsar/issues/2530#issuecomment-418998910 @peterbecker I think you are using an old website link, can you try using the instructions here: https://pulsar.incu

[GitHub] sijie commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-06 Thread GitBox
sijie commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-418997462 @rdhabalia @merlimat please review this. we need to include this for 2.2 release. This

[GitHub] jerrypeng commented on issue #2528: better way to estimate object size for sql

2018-09-05 Thread GitBox
jerrypeng commented on issue #2528: better way to estimate object size for sql URL: https://github.com/apache/incubator-pulsar/pull/2528#issuecomment-418968538 rerun cpp tests This is an automated message from the Apache Git

[GitHub] srkukarni commented on issue #2523: Fix validator logic to differentiate between serializer and deserializer

2018-09-05 Thread GitBox
srkukarni commented on issue #2523: Fix validator logic to differentiate between serializer and deserializer URL: https://github.com/apache/incubator-pulsar/pull/2523#issuecomment-418957602 run java8 tests This is an automate

[GitHub] peterbecker opened a new issue #2530: Documentation issue: wrong file name in TLS instructions

2018-09-05 Thread GitBox
peterbecker opened a new issue #2530: Documentation issue: wrong file name in TLS instructions URL: https://github.com/apache/incubator-pulsar/issues/2530 Expected behavior Following the instructions for generating a server certificate at https://pulsar.incubator.apache.org/doc

[GitHub] congbobo184 commented on issue #2520: web rest api

2018-09-05 Thread GitBox
congbobo184 commented on issue #2520: web rest api URL: https://github.com/apache/incubator-pulsar/issues/2520#issuecomment-418935516 When you enter the rest api page and click on the interface in the left topic of the persistent topic, then jump to the description of the non-persistent i

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418931818 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] codelipenghui commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.

2018-09-05 Thread GitBox
codelipenghui commented on issue #2471: PIP-23: Pulsar Java Client Interceptors. URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-418930758 @sijie Thanks. This is an automated message from the Apache Git

[GitHub] srkukarni commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-05 Thread GitBox
srkukarni commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-418909996 @sijie I believe there are already tests to test the pattern based consumer. Thus not sure if a new one is needed for thi

[GitHub] srkukarni commented on issue #2409: Added HDFS Sink

2018-09-05 Thread GitBox
srkukarni commented on issue #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-418901605 run integration tests This is an automated message from the Apache Git Service. To respond to

[GitHub] srkukarni commented on issue #2409: Added HDFS Sink

2018-09-05 Thread GitBox
srkukarni commented on issue #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-418901522 run integration test This is an automated message from the Apache Git Service. To respond to

[GitHub] merlimat opened a new pull request #2529: Added cmake install for lib and headers

2018-09-05 Thread GitBox
merlimat opened a new pull request #2529: Added cmake install for lib and headers URL: https://github.com/apache/incubator-pulsar/pull/2529 ### Motivation Added `install` target to do local install for C++ client lib T

[GitHub] jerrypeng opened a new pull request #2528: better way to estimate object size for sql

2018-09-05 Thread GitBox
jerrypeng opened a new pull request #2528: better way to estimate object size for sql URL: https://github.com/apache/incubator-pulsar/pull/2528 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] sijie closed issue #1511: PIP-17 : Tiered storage (Master Issue)

2018-09-05 Thread GitBox
sijie closed issue #1511: PIP-17 : Tiered storage (Master Issue) URL: https://github.com/apache/incubator-pulsar/issues/1511 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] sijie commented on issue #1511: PIP-17 : Tiered storage (Master Issue)

2018-09-05 Thread GitBox
sijie commented on issue #1511: PIP-17 : Tiered storage (Master Issue) URL: https://github.com/apache/incubator-pulsar/issues/1511#issuecomment-418893895 Tiered Storage has been implemented by multiple pull requests linked above.

[GitHub] sijie commented on issue #1650: Documentation of admin REST API is missing body parameters

2018-09-05 Thread GitBox
sijie commented on issue #1650: Documentation of admin REST API is missing body parameters URL: https://github.com/apache/incubator-pulsar/issues/1650#issuecomment-418892959 most of the REST apis except functions are updated in the new website. functions are tricky because it is using pro

[GitHub] sijie commented on issue #1737: Bookies at 100% CPU

2018-09-05 Thread GitBox
sijie commented on issue #1737: Bookies at 100% CPU URL: https://github.com/apache/incubator-pulsar/issues/1737#issuecomment-418892507 I think the 100% cpu usage is related to deleteRange. the change is merged to bk 4.7.2 and will be included in pulsar 2.1.1 and 2.2.0 releases. --

[GitHub] sijie closed issue #1737: Bookies at 100% CPU

2018-09-05 Thread GitBox
sijie closed issue #1737: Bookies at 100% CPU URL: https://github.com/apache/incubator-pulsar/issues/1737 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the U

[GitHub] sijie commented on issue #1875: Problems with Persistent Topic stats

2018-09-05 Thread GitBox
sijie commented on issue #1875: Problems with Persistent Topic stats URL: https://github.com/apache/incubator-pulsar/issues/1875#issuecomment-418892259 @merlimat can you take a look at @Audace 's last comment? This is an aut

[GitHub] sijie commented on issue #1916: Intermittent failure in integration test TestS3Offload.testPublishOffloadAndConsumeViaCLI

2018-09-05 Thread GitBox
sijie commented on issue #1916: Intermittent failure in integration test TestS3Offload.testPublishOffloadAndConsumeViaCLI URL: https://github.com/apache/incubator-pulsar/issues/1916#issuecomment-418892082 it is probably related to apache jenkins environment. --

[GitHub] sijie closed issue #1916: Intermittent failure in integration test TestS3Offload.testPublishOffloadAndConsumeViaCLI

2018-09-05 Thread GitBox
sijie closed issue #1916: Intermittent failure in integration test TestS3Offload.testPublishOffloadAndConsumeViaCLI URL: https://github.com/apache/incubator-pulsar/issues/1916 This is an automated message from the Apache Git

[GitHub] sijie closed issue #1933: Provide Embedded Pulsar Runner

2018-09-05 Thread GitBox
sijie closed issue #1933: Provide Embedded Pulsar Runner URL: https://github.com/apache/incubator-pulsar/issues/1933 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] sijie commented on issue #1933: Provide Embedded Pulsar Runner

2018-09-05 Thread GitBox
sijie commented on issue #1933: Provide Embedded Pulsar Runner URL: https://github.com/apache/incubator-pulsar/issues/1933#issuecomment-418891804 This has been implemented by #2080 This is an automated message from the Apache

[GitHub] sijie commented on issue #1949: Zookeeper won't start on IPV6 machines - UnknownHostException

2018-09-05 Thread GitBox
sijie commented on issue #1949: Zookeeper won't start on IPV6 machines - UnknownHostException URL: https://github.com/apache/incubator-pulsar/issues/1949#issuecomment-418891450 Closed the issue since IPV6 is not supported right now. #954 is tracking for adding the support. -

[GitHub] sijie closed issue #1949: Zookeeper won't start on IPV6 machines - UnknownHostException

2018-09-05 Thread GitBox
sijie closed issue #1949: Zookeeper won't start on IPV6 machines - UnknownHostException URL: https://github.com/apache/incubator-pulsar/issues/1949 This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat removed a comment on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat removed a comment on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418886597 run java test This is an automated message from the Apache Gi

[GitHub] merlimat removed a comment on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat removed a comment on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418891137 run java tests This is an automated message from the Apache G

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418891239 run java8 tests This is an automated message from the Apache Git Servi

[GitHub] merlimat removed a comment on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat removed a comment on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418891186 run java8 test This is an automated message from the Apache G

[GitHub] srkukarni commented on issue #2523: Fix validator logic to differentiate between serializer and deserializer

2018-09-05 Thread GitBox
srkukarni commented on issue #2523: Fix validator logic to differentiate between serializer and deserializer URL: https://github.com/apache/incubator-pulsar/pull/2523#issuecomment-418891249 run java8 tests This is an automate

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418891186 run java8 test This is an automated message from the Apache Git Servic

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418891137 run java tests This is an automated message from the Apache Git Servic

[GitHub] merlimat closed pull request #2513: [documentation] Add instructions for contributing c++/python code changes

2018-09-05 Thread GitBox
merlimat closed pull request #2513: [documentation] Add instructions for contributing c++/python code changes URL: https://github.com/apache/incubator-pulsar/pull/2513 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the s

[GitHub] merlimat commented on issue #2525: fixed zookeeper name references in helm charts.

2018-09-05 Thread GitBox
merlimat commented on issue #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525#issuecomment-418890902 @danielccyr @cckellogg Can you take a look as well? This is a

[GitHub] merlimat opened a new pull request #2527: [go] Ensure producer/consumer/reader keep a ref of client instance so it won't be finalized

2018-09-05 Thread GitBox
merlimat opened a new pull request #2527: [go] Ensure producer/consumer/reader keep a ref of client instance so it won't be finalized URL: https://github.com/apache/incubator-pulsar/pull/2527 ### Motivation As reported in #2521, there's an issue with Go client reader that makes it s

[GitHub] sijie commented on issue #2520: web rest api

2018-09-05 Thread GitBox
sijie commented on issue #2520: web rest api URL: https://github.com/apache/incubator-pulsar/issues/2520#issuecomment-418889783 @congbobo184 can you clarify what kind of error are you seeing? This is an automated message from

[GitHub] aahmed-se commented on issue #2524: Reintroduce Aerospike connector

2018-09-05 Thread GitBox
aahmed-se commented on issue #2524: Reintroduce Aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2524#issuecomment-41439 I have removed the exlcusions block This is an automated message from the Apa

[GitHub] aahmed-se commented on a change in pull request #2524: Reintroduce Aerospike connector

2018-09-05 Thread GitBox
aahmed-se commented on a change in pull request #2524: Reintroduce Aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2524#discussion_r215431552 ## File path: pulsar-io/aerospike/pom.xml ## @@ -0,0 +1,75 @@ + +http://maven.apache.org/POM/4.0.0"; xmln

[GitHub] sijie commented on a change in pull request #2524: Reintroduce Aerospike connector

2018-09-05 Thread GitBox
sijie commented on a change in pull request #2524: Reintroduce Aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2524#discussion_r215431140 ## File path: pulsar-io/aerospike/pom.xml ## @@ -0,0 +1,75 @@ + +http://maven.apache.org/POM/4.0.0"; xmlns:xs

[GitHub] sijie closed pull request #2471: PIP-23: Pulsar Java Client Interceptors.

2018-09-05 Thread GitBox
sijie closed pull request #2471: PIP-23: Pulsar Java Client Interceptors. URL: https://github.com/apache/incubator-pulsar/pull/2471 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.

2018-09-05 Thread GitBox
sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors. URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-418886897 @codelipenghui I just merged the interceptors change. Great work! This i

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418886597 run java test This is an automated message from the Apache Git Service

[GitHub] srkukarni commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-05 Thread GitBox
srkukarni commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-418877842 run java8 tests This is an automated message from the Ap

[GitHub] sijie opened a new pull request #2526: [dev] provide a python merge script for merging pull requests

2018-09-05 Thread GitBox
sijie opened a new pull request #2526: [dev] provide a python merge script for merging pull requests URL: https://github.com/apache/incubator-pulsar/pull/2526 ### Motivation Currently we don't have a good tool on managing the merge process for pull requests. Labels and milestone

[GitHub] srkukarni commented on issue #2523: Fix validator logic to differentiate between serializer and deserializer

2018-09-05 Thread GitBox
srkukarni commented on issue #2523: Fix validator logic to differentiate between serializer and deserializer URL: https://github.com/apache/incubator-pulsar/pull/2523#issuecomment-418876379 run java8 tests This is an automate

[GitHub] srkukarni commented on issue #2409: Added HDFS Sink

2018-09-05 Thread GitBox
srkukarni commented on issue #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-418872175 run integration tests This is an automated message from the Apache Git Service. To respond to

[GitHub] vli02 opened a new pull request #2525: fixed zookeeper name references in helm charts.

2018-09-05 Thread GitBox
vli02 opened a new pull request #2525: fixed zookeeper name references in helm charts. URL: https://github.com/apache/incubator-pulsar/pull/2525 ### Motivation zookeeper failed to start because of wrong ZOOKEEPER_SERVERS was set. ### Modifications Changed the reference

[GitHub] ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#discussion_r215406824 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarZKDowngrade

[GitHub] aahmed-se opened a new pull request #2524: Reintroduce Aerospike connector

2018-09-05 Thread GitBox
aahmed-se opened a new pull request #2524: Reintroduce Aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2524 The licensing issue with aerospike client has been resolved with a new version release,, we are now introducing the connector again.

[GitHub] sijie commented on issue #2456: Remove Aerospike Connector

2018-09-05 Thread GitBox
sijie commented on issue #2456: Remove Aerospike Connector URL: https://github.com/apache/incubator-pulsar/pull/2456#issuecomment-418839300 @BrianNichols thank you for pointing this out. we will revert the change and use `aerospike-client-bc` ---

[GitHub] srkukarni opened a new pull request #2523: Fix validator logic to differentiate between serializer and deserializer

2018-09-05 Thread GitBox
srkukarni opened a new pull request #2523: Fix validator logic to differentiate between serializer and deserializer URL: https://github.com/apache/incubator-pulsar/pull/2523 ### Motivation Explain here the context, and why you're making that change. What is the problem you're tryi

[GitHub] vli02 commented on issue #2522: Wrong zookeeper server names are used in zookeeper helm charts.

2018-09-05 Thread GitBox
vli02 commented on issue #2522: Wrong zookeeper server names are used in zookeeper helm charts. URL: https://github.com/apache/incubator-pulsar/issues/2522#issuecomment-418838240 The name of zookeeper is deployed as: ```"{{ template "pulsar.fullname" . }}-{{ .Values.zookeeper.component

[GitHub] sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.

2018-09-05 Thread GitBox
sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors. URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-418838129 run java8 tests This is an automated message from the Apache Git Service

[GitHub] vli02 opened a new issue #2522: Wrong zookeeper server names are used in zookeeper helm charts.

2018-09-05 Thread GitBox
vli02 opened a new issue #2522: Wrong zookeeper server names are used in zookeeper helm charts. URL: https://github.com/apache/incubator-pulsar/issues/2522 Expected behavior By using kubernetes/helm deployment, expect zookeeper to start successfully and the other services can c

[GitHub] srkukarni commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-05 Thread GitBox
srkukarni commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-418836181 run java8 tests This is an automated message from the Ap

[GitHub] BrianNichols edited a comment on issue #2456: Remove Aerospike Connector

2018-09-05 Thread GitBox
BrianNichols edited a comment on issue #2456: Remove Aerospike Connector URL: https://github.com/apache/incubator-pulsar/pull/2456#issuecomment-418828788 Aerospike Java client 4.1.11 adds the ability to switch between GNU and Bouncy Castle crypto libraries at compile time. Bouncy Castle ha

[GitHub] BrianNichols commented on issue #2456: Remove Aerospike Connector

2018-09-05 Thread GitBox
BrianNichols commented on issue #2456: Remove Aerospike Connector URL: https://github.com/apache/incubator-pulsar/pull/2456#issuecomment-418828788 Aerospike Java client 4.1.11 adds the ability to switch between GNU and Bouncy Castle crypto libraries at compile time. Bouncy Castle has a MIT-

[GitHub] srkukarni closed pull request #2512: Misc Cleanups

2018-09-05 Thread GitBox
srkukarni closed pull request #2512: Misc Cleanups URL: https://github.com/apache/incubator-pulsar/pull/2512 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] rdhabalia closed pull request #2519: Delete temp file after submitting function

2018-09-05 Thread GitBox
rdhabalia closed pull request #2519: Delete temp file after submitting function URL: https://github.com/apache/incubator-pulsar/pull/2519 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] rdhabalia closed pull request #2517: Log and Return error-message on function-stats failure

2018-09-05 Thread GitBox
rdhabalia closed pull request #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] rdhabalia closed pull request #2518: Add CLI to get function status of a specific instance

2018-09-05 Thread GitBox
rdhabalia closed pull request #2518: Add CLI to get function status of a specific instance URL: https://github.com/apache/incubator-pulsar/pull/2518 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] srkukarni closed pull request #2514: Use SigKill to kill python process as opposed to sigterm which can be caught

2018-09-05 Thread GitBox
srkukarni closed pull request #2514: Use SigKill to kill python process as opposed to sigterm which can be caught URL: https://github.com/apache/incubator-pulsar/pull/2514 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for t

[GitHub] merlimat commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#discussion_r215342402 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarZKDowngradeT

[GitHub] merlimat commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#discussion_r215342223 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarZKDowngradeT

[GitHub] merlimat commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#discussion_r215341986 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarZKDowngradeT

[GitHub] ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#discussion_r215335019 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarZKDowngrade

[GitHub] ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#discussion_r215335271 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarZKDowngrade

<    2   3   4   5   6   7   8   9   10   11   >