[GitHub] ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
ivankelly commented on a change in pull request #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#discussion_r215334084 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/upgrade/PulsarZKDowngrade

[GitHub] srkukarni commented on issue #2514: Use SigKill to kill python process as opposed to sigterm which can be caught

2018-09-05 Thread GitBox
srkukarni commented on issue #2514: Use SigKill to kill python process as opposed to sigterm which can be caught URL: https://github.com/apache/incubator-pulsar/pull/2514#issuecomment-418787588 run integration tests This is a

[GitHub] srkukarni closed pull request #2502: Fix Handling of user defined nar sources/sinks

2018-09-05 Thread GitBox
srkukarni closed pull request #2502: Fix Handling of user defined nar sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/2502 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] merlimat commented on issue #2521: Go client reader hang when processing backlog of ~6M messages

2018-09-05 Thread GitBox
merlimat commented on issue #2521: Go client reader hang when processing backlog of ~6M messages URL: https://github.com/apache/incubator-pulsar/issues/2521#issuecomment-418758606 Thanks @blutack for the detailed repro steps. I'll try to get a fix asap. --

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-05 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418757934 run java tests This is an automated message from the Apache Git Servic

[GitHub] blutack commented on issue #2521: Go client reader hang when processing backlog of ~6M messages

2018-09-05 Thread GitBox
blutack commented on issue #2521: Go client reader hang when processing backlog of ~6M messages URL: https://github.com/apache/incubator-pulsar/issues/2521#issuecomment-418665185 Just to add to this, the hang occurs approx 1.6 - 1.7 seconds after creating the reader.

[GitHub] blutack opened a new issue #2521: Go client reader hang when processing backlog of ~6M messages

2018-09-05 Thread GitBox
blutack opened a new issue #2521: Go client reader hang when processing backlog of ~6M messages URL: https://github.com/apache/incubator-pulsar/issues/2521 Expected behavior The reader should read all topic messages and then continue to follow the topic Actual behav

[GitHub] congbobo184 opened a new issue #2520: web rest api

2018-09-05 Thread GitBox
congbobo184 opened a new issue #2520: web rest api URL: https://github.com/apache/incubator-pulsar/issues/2520 The persistent in Rest API connection errorใ€‚ This is an automated message from the Apache Git Service. To respond t

[GitHub] srkukarni commented on issue #2502: Fix Handling of user defined nar sources/sinks

2018-09-04 Thread GitBox
srkukarni commented on issue #2502: Fix Handling of user defined nar sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/2502#issuecomment-418607901 @sijie added an integration test This is an automated message

[GitHub] srkukarni commented on issue #2502: Fix Handling of user defined nar sources/sinks

2018-09-04 Thread GitBox
srkukarni commented on issue #2502: Fix Handling of user defined nar sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/2502#issuecomment-418607844 run cpp tests This is an automated message from the Apache Gi

[GitHub] rdhabalia commented on issue #2518: Add CLI to get function status of a specific instance

2018-09-04 Thread GitBox
rdhabalia commented on issue #2518: Add CLI to get function status of a specific instance URL: https://github.com/apache/incubator-pulsar/pull/2518#issuecomment-418601341 @srkukarni updated the change. > What about server side changes? Function already has [server side api](

[GitHub] rdhabalia commented on issue #2517: Log and Return error-message on function-stats failure

2018-09-04 Thread GitBox
rdhabalia commented on issue #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517#issuecomment-418600423 rerun java8 tests This is an automated message from t

[GitHub] rdhabalia removed a comment on issue #2517: Log and Return error-message on function-stats failure

2018-09-04 Thread GitBox
rdhabalia removed a comment on issue #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517#issuecomment-418600258 rerun cpp tests This is an automated message

[GitHub] rdhabalia removed a comment on issue #2517: Log and Return error-message on function-stats failure

2018-09-04 Thread GitBox
rdhabalia removed a comment on issue #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517#issuecomment-418600423 rerun java8 tests This is an automated messag

[GitHub] rdhabalia commented on issue #2517: Log and Return error-message on function-stats failure

2018-09-04 Thread GitBox
rdhabalia commented on issue #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517#issuecomment-418600258 rerun cpp tests This is an automated message from the

[GitHub] rdhabalia removed a comment on issue #2517: Log and Return error-message on function-stats failure

2018-09-04 Thread GitBox
rdhabalia removed a comment on issue #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517#issuecomment-418600193 rerun tests This is an automated message from

[GitHub] rdhabalia commented on issue #2517: Log and Return error-message on function-stats failure

2018-09-04 Thread GitBox
rdhabalia commented on issue #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517#issuecomment-418600193 rerun tests This is an automated message from the Apa

[GitHub] srkukarni commented on a change in pull request #2518: Add CLI to get function status of a specific instance

2018-09-04 Thread GitBox
srkukarni commented on a change in pull request #2518: Add CLI to get function status of a specific instance URL: https://github.com/apache/incubator-pulsar/pull/2518#discussion_r215128833 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java

[GitHub] srkukarni commented on issue #2514: Use SigKill to kill python process as opposed to sigterm which can be caught

2018-09-04 Thread GitBox
srkukarni commented on issue #2514: Use SigKill to kill python process as opposed to sigterm which can be caught URL: https://github.com/apache/incubator-pulsar/pull/2514#issuecomment-418590116 run integration tests This is a

[GitHub] rdhabalia opened a new pull request #2519: Delete temp file after submitting function

2018-09-04 Thread GitBox
rdhabalia opened a new pull request #2519: Delete temp file after submitting function URL: https://github.com/apache/incubator-pulsar/pull/2519 ### Motivation Right now, function-cli doesn't cleanup function-pkg after downloading from http-url. ### Modifications Delete

[GitHub] rdhabalia opened a new pull request #2518: Add CLI to get function status of a specific instance

2018-09-04 Thread GitBox
rdhabalia opened a new pull request #2518: Add CLI to get function status of a specific instance URL: https://github.com/apache/incubator-pulsar/pull/2518 ### Motivation Add CLI support to get status of specific function instance.

[GitHub] rdhabalia opened a new pull request #2517: Log and Return error-message on function-stats failure

2018-09-04 Thread GitBox
rdhabalia opened a new pull request #2517: Log and Return error-message on function-stats failure URL: https://github.com/apache/incubator-pulsar/pull/2517 ### Motivation Right now, for some-reason when get-function-status api call fails then , app-log doesn't log exception with fun

[GitHub] rdhabalia opened a new pull request #2516: Fix: get function status with auth enable

2018-09-04 Thread GitBox
rdhabalia opened a new pull request #2516: Fix: get function status with auth enable URL: https://github.com/apache/incubator-pulsar/pull/2516 ### Motivation Right now, function getstatus doesn't work with auth enable. ### Result get-function status cli will work with e

[GitHub] jerrypeng opened a new pull request #2515: support nested fields in Pulsar presto connector

2018-09-04 Thread GitBox
jerrypeng opened a new pull request #2515: support nested fields in Pulsar presto connector URL: https://github.com/apache/incubator-pulsar/pull/2515 ### Motivation Support nested fields in POJOs to be able to be queried by sql ---

[GitHub] srkukarni commented on issue #2514: Use SigKill to kill python process as opposed to sigterm which can be caught

2018-09-04 Thread GitBox
srkukarni commented on issue #2514: Use SigKill to kill python process as opposed to sigterm which can be caught URL: https://github.com/apache/incubator-pulsar/pull/2514#issuecomment-418564929 run cpp tests This is an automa

[GitHub] srkukarni commented on issue #2512: Misc Cleanups

2018-09-04 Thread GitBox
srkukarni commented on issue #2512: Misc Cleanups URL: https://github.com/apache/incubator-pulsar/pull/2512#issuecomment-418561459 run integration tests This is an automated message from the Apache Git Service. To respond to t

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-04 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418557602 @ivankelly @sijie Added integration test with ZK 3.5 snapshot and log

[GitHub] srkukarni opened a new pull request #2514: Use SigKill to kill python process as opposed to sigterm which can be caught

2018-09-04 Thread GitBox
srkukarni opened a new pull request #2514: Use SigKill to kill python process as opposed to sigterm which can be caught URL: https://github.com/apache/incubator-pulsar/pull/2514 ### Motivation Explain here the context, and why you're making that change. What is the problem you

[GitHub] sijie closed pull request #2497: [schema] implement generic schema/record for Schema.JSON

2018-09-04 Thread GitBox
sijie closed pull request #2497: [schema] implement generic schema/record for Schema.JSON URL: https://github.com/apache/incubator-pulsar/pull/2497 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] srkukarni opened a new pull request #2512: Misc Cleanups

2018-09-04 Thread GitBox
srkukarni opened a new pull request #2512: Misc Cleanups URL: https://github.com/apache/incubator-pulsar/pull/2512 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve. ### Modifications Describe the mo

[GitHub] sijie opened a new pull request #2513: [documentation] Add instructions for contributing c++/python code changes

2018-09-04 Thread GitBox
sijie opened a new pull request #2513: [documentation] Add instructions for contributing c++/python code changes URL: https://github.com/apache/incubator-pulsar/pull/2513 This is an automated message from the Apache Git

[GitHub] sijie opened a new pull request #2511: [documentation] Add section about licensing at contribution guide

2018-09-04 Thread GitBox
sijie opened a new pull request #2511: [documentation] Add section about licensing at contribution guide URL: https://github.com/apache/incubator-pulsar/pull/2511 This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #2510: Handle /managed-ledgers znode existence on cluster init (#2379)

2018-09-04 Thread GitBox
sijie commented on issue #2510: Handle /managed-ledgers znode existence on cluster init (#2379) URL: https://github.com/apache/incubator-pulsar/pull/2510#issuecomment-418531191 cherry-pick as bf4a50b in branch-2.1 This is

[GitHub] sijie commented on issue #2025: Allow non-pesistent topics to be retrieved along with persistent ones from the "GetTopicsOfNamespace" method

2018-09-04 Thread GitBox
sijie commented on issue #2025: Allow non-pesistent topics to be retrieved along with persistent ones from the "GetTopicsOfNamespace" method URL: https://github.com/apache/incubator-pulsar/pull/2025#issuecomment-418528212 @gordeevbr cool, thanks. I removed "[wip]". so other people know this

[GitHub] gordeevbr commented on issue #2025: [WiP] Allow non-pesistent topics to be retrieved along with persistent ones from the "GetTopicsOfNamespace" method

2018-09-04 Thread GitBox
gordeevbr commented on issue #2025: [WiP] Allow non-pesistent topics to be retrieved along with persistent ones from the "GetTopicsOfNamespace" method URL: https://github.com/apache/incubator-pulsar/pull/2025#issuecomment-418527695 @jiazhai @merlimat @sijie I have fixed old tests th

[GitHub] merlimat closed pull request #2510: Handle /managed-ledgers znode existence on cluster init (#2379)

2018-09-04 Thread GitBox
merlimat closed pull request #2510: Handle /managed-ledgers znode existence on cluster init (#2379) URL: https://github.com/apache/incubator-pulsar/pull/2510 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.

2018-09-04 Thread GitBox
sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors. URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-418527004 @codelipenghui I fixed ReplicatorTest and V1_ReplicatorTest. so the CI should be passing now. once the CI is passed, will merge it.

[GitHub] sijie commented on issue #2340: Cherry-pick GCS offloader documentation to new website

2018-09-04 Thread GitBox
sijie commented on issue #2340: Cherry-pick GCS offloader documentation to new website URL: https://github.com/apache/incubator-pulsar/issues/2340#issuecomment-418522474 This is fixed by #2364 This is an automated message fr

[GitHub] sijie closed issue #2340: Cherry-pick GCS offloader documentation to new website

2018-09-04 Thread GitBox
sijie closed issue #2340: Cherry-pick GCS offloader documentation to new website URL: https://github.com/apache/incubator-pulsar/issues/2340 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-04 Thread GitBox
sijie commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-418506210 @rdhabalia @merlimat can you help reviewing @codelipenghui 's pull request? This is an

[GitHub] sijie commented on issue #2508: PIP-22: Dead Letter Topic

2018-09-04 Thread GitBox
sijie commented on issue #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508#issuecomment-418505462 retest this please This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #2500: [schema] add schemas for primtive types

2018-09-04 Thread GitBox
sijie commented on issue #2500: [schema] add schemas for primtive types URL: https://github.com/apache/incubator-pulsar/pull/2500#issuecomment-418505286 retest this please This is an automated message from the Apache Git Servi

[GitHub] sijie commented on issue #2503: add auto ack and timeout configurable

2018-09-04 Thread GitBox
sijie commented on issue #2503: add auto ack and timeout configurable URL: https://github.com/apache/incubator-pulsar/pull/2503#issuecomment-418505083 run java8 tests This is an automated message from the Apache Git Service. T

[GitHub] sijie commented on issue #2409: Added HDFS Sink

2018-09-04 Thread GitBox
sijie commented on issue #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409#issuecomment-418504900 @srkukarni @merlimat can you review this PR and make sure we can land this in 2.2 release? This

[GitHub] sijie closed pull request #2440: Issue 2313: create a JDBC sink connector

2018-09-04 Thread GitBox
sijie closed pull request #2440: Issue 2313: create a JDBC sink connector URL: https://github.com/apache/incubator-pulsar/pull/2440 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] sijie commented on issue #2509: Don't initialize /managed-ledgers on client creation (#2379)

2018-09-04 Thread GitBox
sijie commented on issue #2509: Don't initialize /managed-ledgers on client creation (#2379) URL: https://github.com/apache/incubator-pulsar/pull/2509#issuecomment-418504238 cherry-pick as 8a4f5cc in branch-2.1 This is an aut

[GitHub] sijie commented on issue #2510: Handle /managed-ledgers znode existence on cluster init (#2379)

2018-09-04 Thread GitBox
sijie commented on issue #2510: Handle /managed-ledgers znode existence on cluster init (#2379) URL: https://github.com/apache/incubator-pulsar/pull/2510#issuecomment-418504311 run cpp tests This is an automated message from

[GitHub] sijie closed pull request #2509: Don't initialize /managed-ledgers on client creation (#2379)

2018-09-04 Thread GitBox
sijie closed pull request #2509: Don't initialize /managed-ledgers on client creation (#2379) URL: https://github.com/apache/incubator-pulsar/pull/2509 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] sijie commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts

2018-09-04 Thread GitBox
sijie commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts URL: https://github.com/apache/incubator-pulsar/pull/2487#issuecomment-418494023 cherry-picked as 113418d in branch-2.1 Th

[GitHub] merlimat closed pull request #2487: Ensure standalone service comes back quickly after ungraceful restarts

2018-09-04 Thread GitBox
merlimat closed pull request #2487: Ensure standalone service comes back quickly after ungraceful restarts URL: https://github.com/apache/incubator-pulsar/pull/2487 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] sijie commented on issue #2440: Issue 2313: create a JDBC sink connector

2018-09-04 Thread GitBox
sijie commented on issue #2440: Issue 2313: create a JDBC sink connector URL: https://github.com/apache/incubator-pulsar/pull/2440#issuecomment-418480681 run integration tests This is an automated message from the Apache Git S

[GitHub] sijie closed pull request #2434: Add pulsar flink sink connector

2018-09-04 Thread GitBox
sijie closed pull request #2434: Add pulsar flink sink connector URL: https://github.com/apache/incubator-pulsar/pull/2434 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] aahmed-se commented on issue #2504: [WIP] Add Presto Sql Test

2018-09-04 Thread GitBox
aahmed-se commented on issue #2504: [WIP] Add Presto Sql Test URL: https://github.com/apache/incubator-pulsar/pull/2504#issuecomment-418472398 We haven't determined on how to proceed yet , @jerrypeng just needs this to get started. I will make this WIP for now -

[GitHub] merlimat commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts

2018-09-04 Thread GitBox
merlimat commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts URL: https://github.com/apache/incubator-pulsar/pull/2487#issuecomment-418471238 @rdhabalia I believe that having z-node created and deleted in very different parts of the code makes i

[GitHub] sijie commented on issue #2504: Add Presto Sql Test

2018-09-04 Thread GitBox
sijie commented on issue #2504: Add Presto Sql Test URL: https://github.com/apache/incubator-pulsar/pull/2504#issuecomment-418470600 Please update the caption and description. This doesn't actually do any real tests on the SQL execution, it is just a sanity check if the presto worker is se

[GitHub] sijie commented on issue #2480: Allow to configure bookie settings when running in standalone mode

2018-09-04 Thread GitBox
sijie commented on issue #2480: Allow to configure bookie settings when running in standalone mode URL: https://github.com/apache/incubator-pulsar/pull/2480#issuecomment-418467525 cherry-picked as f5a01f7 in branch-2.1 This i

[GitHub] sijie closed pull request #2480: Allow to configure bookie settings when running in standalone mode

2018-09-04 Thread GitBox
sijie closed pull request #2480: Allow to configure bookie settings when running in standalone mode URL: https://github.com/apache/incubator-pulsar/pull/2480 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] sijie closed pull request #2482: Fix log4j conf

2018-09-04 Thread GitBox
sijie closed pull request #2482: Fix log4j conf URL: https://github.com/apache/incubator-pulsar/pull/2482 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a f

[GitHub] rdhabalia commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts

2018-09-04 Thread GitBox
rdhabalia commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts URL: https://github.com/apache/incubator-pulsar/pull/2487#issuecomment-418271067 @merlimat I still don't feel this is a good solution to address this problem because of two reasons. M

[GitHub] sijie commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts

2018-09-04 Thread GitBox
sijie commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts URL: https://github.com/apache/incubator-pulsar/pull/2487#issuecomment-418266534 retest this please This is an automated m

[GitHub] sijie commented on issue #2482: Fix log4j conf

2018-09-04 Thread GitBox
sijie commented on issue #2482: Fix log4j conf URL: https://github.com/apache/incubator-pulsar/pull/2482#issuecomment-418266432 retest this please This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] sijie commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-04 Thread GitBox
sijie commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418266324 run java8 tests This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #2480: Allow to configure bookie settings when running in standalone mode

2018-09-04 Thread GitBox
sijie commented on issue #2480: Allow to configure bookie settings when running in standalone mode URL: https://github.com/apache/incubator-pulsar/pull/2480#issuecomment-418266191 run integration tests This is an automated me

[GitHub] sijie commented on issue #2488: [functions] Don't set the state storage url if state is not enabled.

2018-09-04 Thread GitBox
sijie commented on issue #2488: [functions] Don't set the state storage url if state is not enabled. URL: https://github.com/apache/incubator-pulsar/pull/2488#issuecomment-418266116 cherry-picked 04c5c48 in branch-2.1 Thi

[GitHub] sijie closed pull request #2488: [functions] Don't set the state storage url if state is not enabled.

2018-09-04 Thread GitBox
sijie closed pull request #2488: [functions] Don't set the state storage url if state is not enabled. URL: https://github.com/apache/incubator-pulsar/pull/2488 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of p

[GitHub] sijie commented on issue #2400: PIP-22: Dead Letter Topic

2018-09-04 Thread GitBox
sijie commented on issue #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#issuecomment-418265592 Closed this PR and use #2508 for it. This is an automated message from the Apache Git S

[GitHub] sijie closed pull request #2400: PIP-22: Dead Letter Topic

2018-09-04 Thread GitBox
sijie closed pull request #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull reques

[GitHub] sijie commented on a change in pull request #2504: Add Presto Sql Test

2018-09-04 Thread GitBox
sijie commented on a change in pull request #2504: Add Presto Sql Test URL: https://github.com/apache/incubator-pulsar/pull/2504#discussion_r214807167 ## File path: tests/integration/pom.xml ## @@ -88,6 +88,12 @@ jackson-dataformat-yaml test + Rev

[GitHub] sijie commented on a change in pull request #2504: Add Presto Sql Test

2018-09-04 Thread GitBox
sijie commented on a change in pull request #2504: Add Presto Sql Test URL: https://github.com/apache/incubator-pulsar/pull/2504#discussion_r214807332 ## File path: tests/integration/src/test/java/org/apache/pulsar/tests/integration/presto/TestBasicPresto.java ## @@ -0,0 +

[GitHub] sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.

2018-09-04 Thread GitBox
sijie commented on issue #2471: PIP-23: Pulsar Java Client Interceptors. URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-418264034 run java8 tests This is an automated message from the Apache Git Service

[GitHub] codelipenghui commented on issue #2400: PIP-22: Dead Letter Topic

2018-09-03 Thread GitBox
codelipenghui commented on issue #2400: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2400#issuecomment-418249008 This PR can close now. I have a new [PR-2508](https://github.com/apache/incubator-pulsar/pull/2508) for PIP-22 Dead Letter Topic.

[GitHub] merlimat commented on issue #2471: PIP-23: Pulsar Java Client Interceptors.

2018-09-03 Thread GitBox
merlimat commented on issue #2471: PIP-23: Pulsar Java Client Interceptors. URL: https://github.com/apache/incubator-pulsar/pull/2471#issuecomment-418152309 @codelipenghui There is one test failing : https://builds.apache.org/job/pulsar_precommit_java8/3387/testReport/junit/org.apache.pulsa

[GitHub] srkukarni commented on issue #2480: Allow to configure bookie settings when running in standalone mode

2018-09-03 Thread GitBox
srkukarni commented on issue #2480: Allow to configure bookie settings when running in standalone mode URL: https://github.com/apache/incubator-pulsar/pull/2480#issuecomment-418147993 run cpp tests run java8 tests This is

[GitHub] srkukarni commented on issue #2488: [functions] Don't set the state storage url if state is not enabled.

2018-09-03 Thread GitBox
srkukarni commented on issue #2488: [functions] Don't set the state storage url if state is not enabled. URL: https://github.com/apache/incubator-pulsar/pull/2488#issuecomment-418148098 run integration tests This is an automa

[GitHub] srkukarni commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-03 Thread GitBox
srkukarni commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-418146569 run integration tests This is an automated message from

[GitHub] ivankelly opened a new pull request #2510: Handle /managed-ledgers znode existence on cluster init (#2379)

2018-09-03 Thread GitBox
ivankelly opened a new pull request #2510: Handle /managed-ledgers znode existence on cluster init (#2379) URL: https://github.com/apache/incubator-pulsar/pull/2510 ManagedLedger clients may create the /managed-ledger znode on boot, so if a broker starts before the metadata is initialize

[GitHub] ivankelly opened a new pull request #2509: Don't initialize /managed-ledgers on client creation (#2379)

2018-09-03 Thread GitBox
ivankelly opened a new pull request #2509: Don't initialize /managed-ledgers on client creation (#2379) URL: https://github.com/apache/incubator-pulsar/pull/2509 Normally the /managed-ledgers znode is created by the initialize-cluster-metadata command when a cluster is being turned up

[GitHub] codelipenghui opened a new pull request #2508: PIP-22: Dead Letter Topic

2018-09-03 Thread GitBox
codelipenghui opened a new pull request #2508: PIP-22: Dead Letter Topic URL: https://github.com/apache/incubator-pulsar/pull/2508 When consumer got messages from pulsar, It's difficult to ensure every message can be consume success. Pulsar support message redelivery feature by set acknowl

[GitHub] ivankelly commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-03 Thread GitBox
ivankelly commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-418028645 @merlimat why do you need a mounted volume? You can have more than one version of the pulsar software on a single container, so start

[GitHub] merlimat commented on issue #2488: [functions] Don't set the state storage url if state is not enabled.

2018-09-02 Thread GitBox
merlimat commented on issue #2488: [functions] Don't set the state storage url if state is not enabled. URL: https://github.com/apache/incubator-pulsar/pull/2488#issuecomment-417968024 run cpp tests This is an automated messa

[GitHub] merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-02 Thread GitBox
merlimat commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-417962879 @ivankelly I have looked into adding integration test. The main problem I think is that since we're using docker based approach for int

[GitHub] merlimat commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts

2018-09-02 Thread GitBox
merlimat commented on issue #2487: Ensure standalone service comes back quickly after ungraceful restarts URL: https://github.com/apache/incubator-pulsar/pull/2487#issuecomment-417960626 @sijie @rdhabalia Updated by adding no-op load manager for standalone case. --

[GitHub] merlimat commented on issue #2482: Fix log4j conf

2018-09-02 Thread GitBox
merlimat commented on issue #2482: Fix log4j conf URL: https://github.com/apache/incubator-pulsar/pull/2482#issuecomment-417960564 run cpp tests run java8 tests This is an automated message from the Apache Git Service. To r

[GitHub] merlimat commented on issue #2480: Allow to configure bookie settings when running in standalone mode

2018-09-02 Thread GitBox
merlimat commented on issue #2480: Allow to configure bookie settings when running in standalone mode URL: https://github.com/apache/incubator-pulsar/pull/2480#issuecomment-417960541 run cpp tests run java8 tests This is a

[GitHub] merlimat closed pull request #2491: Include pulsar python client dependencies in pulsar image

2018-09-02 Thread GitBox
merlimat closed pull request #2491: Include pulsar python client dependencies in pulsar image URL: https://github.com/apache/incubator-pulsar/pull/2491 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] srkukarni commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-01 Thread GitBox
srkukarni commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-417907769 run integration tests This is an automated message from

[GitHub] srkukarni commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-01 Thread GitBox
srkukarni commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-417891408 run integration tests This is an automated message from

[GitHub] pouledodue removed a comment on issue #2375: Support for delayed message delivery

2018-09-01 Thread GitBox
pouledodue removed a comment on issue #2375: Support for delayed message delivery URL: https://github.com/apache/incubator-pulsar/issues/2375#issuecomment-416288770 I so wait for this This is an automated message from the Ap

[GitHub] srkukarni commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-01 Thread GitBox
srkukarni commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-417877082 run integration tests This is an automated message from

[GitHub] srkukarni commented on issue #2502: Fix Handling of user defined nar sources/sinks

2018-09-01 Thread GitBox
srkukarni commented on issue #2502: Fix Handling of user defined nar sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/2502#issuecomment-417877063 run integration tests run java8 tests This is an automated

[GitHub] merlimat commented on issue #2491: Include pulsar python client dependencies in pulsar image

2018-09-01 Thread GitBox
merlimat commented on issue #2491: Include pulsar python client dependencies in pulsar image URL: https://github.com/apache/incubator-pulsar/pull/2491#issuecomment-417873962 run cpp tests run java8 tests This is an automa

[GitHub] merlimat closed pull request #2507: Fix typos

2018-09-01 Thread GitBox
merlimat closed pull request #2507: Fix typos URL: https://github.com/apache/incubator-pulsar/pull/2507 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a for

[GitHub] merlimat closed pull request #2505: Fix sql cli

2018-09-01 Thread GitBox
merlimat closed pull request #2505: Fix sql cli URL: https://github.com/apache/incubator-pulsar/pull/2505 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a f

[GitHub] srkukarni commented on a change in pull request #2502: Fix Handling of user defined nar sources/sinks

2018-09-01 Thread GitBox
srkukarni commented on a change in pull request #2502: Fix Handling of user defined nar sources/sinks URL: https://github.com/apache/incubator-pulsar/pull/2502#discussion_r214517272 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInsta

[GitHub] srkukarni commented on issue #2507: Fix typos

2018-09-01 Thread GitBox
srkukarni commented on issue #2507: Fix typos URL: https://github.com/apache/incubator-pulsar/pull/2507#issuecomment-417867857 run integration tests This is an automated message from the Apache Git Service. To respond to the m

[GitHub] pouledodue commented on issue #2506: TopicPatterns are now supported by python functions

2018-09-01 Thread GitBox
pouledodue commented on issue #2506: TopicPatterns are now supported by python functions URL: https://github.com/apache/incubator-pulsar/pull/2506#issuecomment-417867233 ๐Ÿ ๐Ÿ‘ This is an automated message from the Apache Git S

[GitHub] sijie commented on issue #2434: Add pulsar flink sink connector

2018-09-01 Thread GitBox
sijie commented on issue #2434: Add pulsar flink sink connector URL: https://github.com/apache/incubator-pulsar/pull/2434#issuecomment-417839043 run java8 tests This is an automated message from the Apache Git Service. To resp

[GitHub] sijie commented on issue #2473: Downgrading ZK to stable version 3.4.13

2018-09-01 Thread GitBox
sijie commented on issue #2473: Downgrading ZK to stable version 3.4.13 URL: https://github.com/apache/incubator-pulsar/pull/2473#issuecomment-417838922 retest this please This is an automated message from the Apache Git Servi

[GitHub] sijie commented on issue #2484: Fixed the issue 2481 by not to take PULSAR_MEM from env.

2018-09-01 Thread GitBox
sijie commented on issue #2484: Fixed the issue 2481 by not to take PULSAR_MEM from env. URL: https://github.com/apache/incubator-pulsar/pull/2484#issuecomment-417838881 cherry-pick as 588f6f2c5d32288e7404eb5049ac03dc0697 to branch-2.1 --

[GitHub] sijie closed pull request #2484: Fixed the issue 2481 by not to take PULSAR_MEM from env.

2018-09-01 Thread GitBox
sijie closed pull request #2484: Fixed the issue 2481 by not to take PULSAR_MEM from env. URL: https://github.com/apache/incubator-pulsar/pull/2484 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

<    3   4   5   6   7   8   9   10   11   12   >