Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-360004158
retest this please
This is an automated message from the Apache Git
Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-359979073
Oops! Just a typo! Thanks @merlimat!
This is an automated message
Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-359841921
@merlimat Thanks, added `make check-format`! Would you please rebuild the
Docker image?
Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-359823774
@merlimat Now using `clang-format-5.0`!
This is an automated message
Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-359289555
@merlimat @maskit Using `clang-format-5.0` is reasonable option. But, it is
better to arrange the both versions in CI and local
Licht-T commented on issue #1080: ENH: Apply `make format` into C++ client
URL: https://github.com/apache/incubator-pulsar/pull/1080#issuecomment-359285229
@maskit @merlimat @jai1 Thanks for your review!
Here is the new settings.
