[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187851866 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-14 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187852225 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-11 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187596277 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-11 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187597507 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-11 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187597119 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-11 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187597447 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187134438 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187073441 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187073606 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187073232 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187076087 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187069001 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187072157 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187070366 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/S3ManagedLedgerOff

[GitHub] ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader

2018-05-09 Thread GitBox
ivankelly commented on a change in pull request #1746: PIP-17: impl offload() for S3ManagedLedgerOffloader URL: https://github.com/apache/incubator-pulsar/pull/1746#discussion_r187075521 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/impl/BlockAwareSeg