[GitHub] ivankelly commented on issue #1669: PIP-17: provide DataBlockHeader and implementation

2018-05-02 Thread GitBox
ivankelly commented on issue #1669: PIP-17: provide DataBlockHeader and implementation URL: https://github.com/apache/incubator-pulsar/pull/1669#issuecomment-385912117 Weird. It looks like the test hangs on MessageIdTest for over 2 hours

[GitHub] ivankelly commented on issue #1669: PIP-17: provide DataBlockHeader and implementation

2018-05-02 Thread GitBox
ivankelly commented on issue #1669: PIP-17: provide DataBlockHeader and implementation URL: https://github.com/apache/incubator-pulsar/pull/1669#issuecomment-385912117 Weird. It looks like the test hangs on MessageIdTest for over 2 hours. Obviously nothing to do with this change though.

[GitHub] ivankelly commented on issue #1669: PIP-17: provide DataBlockHeader and implementation

2018-04-30 Thread GitBox
ivankelly commented on issue #1669: PIP-17: provide DataBlockHeader and implementation URL: https://github.com/apache/incubator-pulsar/pull/1669#issuecomment-385420445 @zhaijack lgtm. Will you add the master issue to the PR description, so it gets linked there.