[GitHub] jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface

2018-05-02 Thread GitBox
jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185603311 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/RuntimeSink.java

[GitHub] jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface

2018-05-02 Thread GitBox
jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185603124 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java

[GitHub] jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface

2018-05-02 Thread GitBox
jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185602904 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java

[GitHub] jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface

2018-05-02 Thread GitBox
jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185602874 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/sink/PulsarSink.java

[GitHub] jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface

2018-05-02 Thread GitBox
jerrypeng commented on a change in pull request #1708: Refactor functions to use Sink interface URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185602541 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java ## @@