[GitHub] mgodave commented on issue #1137: Schema registry

2018-04-09 Thread GitBox
mgodave commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-379797837 All changes are merged, this tracking ticket can be closed or merged. This is an automated

[GitHub] mgodave commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
mgodave commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365065103 sounds good. I can easily break this apart again. On Mon, Feb 12, 2018 at 2:07 PM, Ivan Kelly wrote: > Yes, github

[GitHub] mgodave commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
mgodave commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365061364 Yeah, I was thinking 1. Proto changes 2. Schema Registry 3. Default Implementation The funny thing is that this is how my branches were

[GitHub] mgodave commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
mgodave commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365060102 Noted On Mon, Feb 12, 2018 at 1:59 PM, Ivan Kelly wrote: > Even just having the proto (and compiled stuff) separate

[GitHub] mgodave commented on issue #1137: Schema registry

2018-02-12 Thread GitBox
mgodave commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365059450 I tried to do that before and I wasn't happy with how it worked out. I'll take another look. On Mon, Feb 12, 2018 at 1:54 PM, Ivan Kelly