sijie commented on a change in pull request #2107: patching CmdSink and adding extensive unit tests URL: https://github.com/apache/incubator-pulsar/pull/2107#discussion_r200828739
########## File path: pulsar-client-tools/pom.xml ########## @@ -86,6 +86,40 @@ </dependency> <!-- functions related dependencies (end) --> + + <dependency> + <groupId>${project.groupId}</groupId> + <artifactId>pulsar-io-cassandra</artifactId> + <version>${project.version}</version> + <scope>test</scope> + </dependency> + </dependencies> + <build> + <plugins> + <!-- this task is used for copy all python files together to provide a instance directory + for running python instance --> + <plugin> + <groupId>org.apache.maven.plugins</groupId> + <artifactId>maven-antrun-plugin</artifactId> + <executions> + <execution> + <phase>test-compile</phase> + <goals> + <goal>run</goal> + </goals> + <configuration> + <tasks> + <echo>building python instance</echo> Review comment: can you rename to something like "copy test sink package"? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services