sijie commented on a change in pull request #2611: Make dockerUtils use 
container name for test exec
URL: https://github.com/apache/incubator-pulsar/pull/2611#discussion_r218935033
 
 

 ##########
 File path: tests/integration/src/test/resources/log4j2.xml
 ##########
 @@ -0,0 +1,33 @@
+<?xml version="1.0" encoding="UTF-8"?>
 
 Review comment:
   why do we need this?
   
   the logging is already configured - 
https://github.com/apache/incubator-pulsar/blob/master/buildtools/src/main/resources/log4j2.xml
   
   you can enable logging to console by specifying 
`-DredirectTestOutputToFile=false`
   
   https://github.com/apache/incubator-pulsar/blob/master/pom.xml#L132
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to