yush1ga opened a new pull request #901: Introduce configuration converter URL: https://github.com/apache/incubator-pulsar/pull/901 ### Motivation Although `DiscoveryService`, `WebSocketProxy` and `PulsarProxy` have original configuration classes, these components convert these to `ServiceConfiguration`, which is broker's configuration class, in their `Service` classes. When some common settings are added to Service configuration, we have to change each `Service` class and it's inconvenient. ### Modifications - Added `convertFrom()` method to `ServiceConfiguration` which converts an implementation of`PulsarConfiguration` to `ServiceConfiguration`. ### Result We don't have to change `Service` classes every time we add common settings.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
