[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378468333 Seems still some test error, will fix it.

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378437218 Seems there was no conflict, lt should be well.

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378434122 retest this please This is an automated

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 seems CI build error could fix with #1489, may need retry after it merged

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 seems CI build error comes from #1489, may need retry after it merged

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 seems CI build error comes from #1489 This is

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 build error comes from #1489 This is an

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-377876972 @merlimat, thanks for the review. `PartitionedConsumerImpl` should be remove, but was wrongly get back when do

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-377453384 @merlimat Would you please help review this?

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-373986873 retest this please This is an automated

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-373984847 retest this please This is an automated

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-372509604 @merlimat @sijie Would you please help review this. Thanks.

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-372033986 retest this please This is an automated