[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 seems CI build error could fix with #1489, may need retry after it merged

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 seems CI build error comes from #1489, may need retry after it merged

[GitHub] coderfender opened a new issue #1490: Homebrew Package for apache-oulsar

2018-04-03 Thread GitBox
coderfender opened a new issue #1490: Homebrew Package for apache-oulsar URL: https://github.com/apache/incubator-pulsar/issues/1490 Expected behavior Tell us what should happen Actual behavior Tell us what happens instead Steps to reproduce

[GitHub] sijie commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor

2018-04-03 Thread GitBox
sijie commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor URL: https://github.com/apache/incubator-pulsar/pull/1489#issuecomment-378153429 retest this please This is an automated message from

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 seems CI build error comes from #1489 This is

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378147169 build error comes from #1489 This is an

[GitHub] merlimat commented on issue #1490: Linux/Homebrew Package for apache-oulsar

2018-04-03 Thread GitBox
merlimat commented on issue #1490: Linux/Homebrew Package for apache-oulsar URL: https://github.com/apache/incubator-pulsar/issues/1490#issuecomment-378306048 @coderfender Nice! For homebrew there was some work done here https://github.com/streamlio/homebrew-formulae/blob/master/pulsar.rb

[GitHub] merlimat commented on issue #1271: Message deduplication documentation

2018-04-03 Thread GitBox
merlimat commented on issue #1271: Message deduplication documentation URL: https://github.com/apache/incubator-pulsar/pull/1271#issuecomment-378319204 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1271: Message deduplication documentation

2018-04-03 Thread GitBox
merlimat commented on issue #1271: Message deduplication documentation URL: https://github.com/apache/incubator-pulsar/pull/1271#issuecomment-378319204 retest this please This is an automated message from the Apache Git

[GitHub] merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor

2018-04-03 Thread GitBox
merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor URL: https://github.com/apache/incubator-pulsar/pull/1489#issuecomment-378376262 retest this please This is an automated message from

[GitHub] merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor

2018-04-03 Thread GitBox
merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor URL: https://github.com/apache/incubator-pulsar/pull/1489#issuecomment-378376262 retest this please This is an automated message from

[GitHub] jai1 commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor

2018-04-03 Thread GitBox
jai1 commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor URL: https://github.com/apache/incubator-pulsar/pull/1489#issuecomment-378402380 retest this please This is an automated message from the

[GitHub] merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor

2018-04-03 Thread GitBox
merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor URL: https://github.com/apache/incubator-pulsar/pull/1489#issuecomment-378407272 > I guess we will always run into these issues as long as we keep pointing to SNAPSHOT jar. > Maybe we should

[GitHub] sijie commented on issue #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
sijie commented on issue #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492#issuecomment-378441045 @jai1 I think it is #1327 broke the admin tool. so a better fix is to fix PulsarAdminTool to construct PulsarAdminWithFunctions.

[GitHub] sijie commented on issue #1440: Update default values for a few publisher settings

2018-04-03 Thread GitBox
sijie commented on issue #1440: Update default values for a few publisher settings URL: https://github.com/apache/incubator-pulsar/pull/1440#issuecomment-378443928 @merlimat - rebased to latest master and updated javadocs

[incubator-pulsar] branch master updated: Refactored to reflect changes in BK for OrderedExecutor (#1489)

2018-04-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new d309b2c Refactored to reflect

[GitHub] merlimat closed pull request #1489: Refactored to reflect changes in BK for OrderedExecutor

2018-04-03 Thread GitBox
merlimat closed pull request #1489: Refactored to reflect changes in BK for OrderedExecutor URL: https://github.com/apache/incubator-pulsar/pull/1489 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat opened a new pull request #1491: Fixed test_producer_send_async in Python

2018-04-03 Thread GitBox
merlimat opened a new pull request #1491: Fixed test_producer_send_async in Python URL: https://github.com/apache/incubator-pulsar/pull/1491 Seen a couple of times: ``` == FAIL: test_producer_send_async

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378437218 Seems there was no conflict, lt should be well.

[GitHub] zhaijack opened a new issue #1493: bundle balance need also consider in-progress bundles

2018-04-03 Thread GitBox
zhaijack opened a new issue #1493: bundle balance need also consider in-progress bundles URL: https://github.com/apache/incubator-pulsar/issues/1493 If a lot of bundles assignment happens at the same time, besides the history bundle assignment, the in-pregress bundles assignment may also

[GitHub] merlimat commented on issue #1381: Schema registry 4/N

2018-04-03 Thread GitBox
merlimat commented on issue #1381: Schema registry 4/N URL: https://github.com/apache/incubator-pulsar/pull/1381#issuecomment-378411591 @mgodave please merge with master again and it should go through CI this time. This is

[GitHub] merlimat commented on issue #1488: Load manager should offload multiple bundles when overloaded

2018-04-03 Thread GitBox
merlimat commented on issue #1488: Load manager should offload multiple bundles when overloaded URL: https://github.com/apache/incubator-pulsar/pull/1488#issuecomment-378418126 @sijie @rdhabalia Updated This is an automated

[GitHub] merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor

2018-04-03 Thread GitBox
merlimat commented on issue #1489: Refactored to reflect changes in BK for OrderedExecutor URL: https://github.com/apache/incubator-pulsar/pull/1489#issuecomment-378408950 > can we add timestamp snapshot version for BK. We can, though I don't think it needs to be part of this PR

[GitHub] sijie closed pull request #1491: Fixed test_producer_send_async in Python

2018-04-03 Thread GitBox
sijie closed pull request #1491: Fixed test_producer_send_async in Python URL: https://github.com/apache/incubator-pulsar/pull/1491 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Fixed test_producer_send_async in Python (#1491)

2018-04-03 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b052669 Fixed

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378434122 retest this please This is an automated

[GitHub] jai1 opened a new pull request #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
jai1 opened a new pull request #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492 Currently in master: ``` ./bin/pulsar-admin class java.lang.reflect.InvocationTargetException: null ``` Reason is that in

[GitHub] jai1 commented on issue #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
jai1 commented on issue #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492#issuecomment-378469509 @sijie You are right #1327 broke the pulsar-admin Even after breaking my head for 2 hours I couldn't figure out a way of resolving

[GitHub] zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
zhaijack commented on issue #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365#issuecomment-378468333 Seems still some test error, will fix it.

[GitHub] jai1 opened a new pull request #1494: In Namespace.addClusters and Properties.addRoles changed dataType to Set

2018-04-03 Thread GitBox
jai1 opened a new pull request #1494: In Namespace.addClusters and Properties.addRoles changed dataType to Set URL: https://github.com/apache/incubator-pulsar/pull/1494 In a recent production incident, we noticed duplicate cluster names in Zookeeper on Namespace policies. I have

[GitHub] sijie commented on issue #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
sijie commented on issue #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492#issuecomment-378470439 Let me work on that This is an automated message from the Apache Git

[GitHub] zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-04-03 Thread GitBox
zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-378083616 retest this please

[GitHub] zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-04-03 Thread GitBox
zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-378470938 retest this please

[GitHub] jai1 commented on issue #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
jai1 commented on issue #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492#issuecomment-378478744 retest this please This is an automated message from the Apache Git

[GitHub] zhaijack commented on a change in pull request #1488: Load manager should offload multiple bundles when overloaded

2018-04-03 Thread GitBox
zhaijack commented on a change in pull request #1488: Load manager should offload multiple bundles when overloaded URL: https://github.com/apache/incubator-pulsar/pull/1488#discussion_r179025858 ## File path:

[GitHub] sijie commented on a change in pull request #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
sijie commented on a change in pull request #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492#discussion_r179026165 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/PulsarAdmin.java ##

[GitHub] sijie commented on a change in pull request #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
sijie commented on a change in pull request #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492#discussion_r179026091 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/PulsarAdmin.java ##

[GitHub] sijie commented on a change in pull request #1492: Removed Pulsar Functions from AdminTool

2018-04-03 Thread GitBox
sijie commented on a change in pull request #1492: Removed Pulsar Functions from AdminTool URL: https://github.com/apache/incubator-pulsar/pull/1492#discussion_r179026053 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/PulsarAdmin.java ##

[GitHub] merlimat closed pull request #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead

2018-04-03 Thread GitBox
merlimat closed pull request #1365: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead URL: https://github.com/apache/incubator-pulsar/pull/1365 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Delete PartitionedConsumerImpl, use TopicsConsumerImpl instead (#1365)

2018-04-03 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 1dd9c43 Delete

[GitHub] merlimat commented on a change in pull request #1494: In Namespace.addClusters and Properties.addRoles changed dataType to Set

2018-04-03 Thread GitBox
merlimat commented on a change in pull request #1494: In Namespace.addClusters and Properties.addRoles changed dataType to Set URL: https://github.com/apache/incubator-pulsar/pull/1494#discussion_r179027633 ## File path:

[GitHub] sijie commented on issue #1458: skip-all/clear-backlog doesn't work if bookkeeper is outage

2018-04-03 Thread GitBox
sijie commented on issue #1458: skip-all/clear-backlog doesn't work if bookkeeper is outage URL: https://github.com/apache/incubator-pulsar/issues/1458#issuecomment-378453193 @merlimat it seems #1461 doesn't actually address the problem. I am seeing 404. it seems to me that there is no

[GitHub] zhaijack opened a new pull request #1495: Add MultiTopicsConsumerImpl with leaked commit from partitionedConsumer

2018-04-03 Thread GitBox
zhaijack opened a new pull request #1495: Add MultiTopicsConsumerImpl with leaked commit from partitionedConsumer URL: https://github.com/apache/incubator-pulsar/pull/1495 ### Motivation MultiTopicsConsumerImpl leaked merge the change in partitionedConsumer in [PR1462]