[GitHub] sijie commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
sijie commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380008954 retest this please This is an automated message from the Apache Git Ser

[GitHub] yush1ga commented on issue #1352: Delete inactive subscriptions automatically

2018-04-10 Thread GitBox
yush1ga commented on issue #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-380010347 retest this please This is an automated message from the Apache Git

[GitHub] yush1ga commented on issue #1352: Delete inactive subscriptions automatically

2018-04-10 Thread GitBox
yush1ga commented on issue #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-380010347 retest this please This is an automated message from the Apache Git

[incubator-pulsar] branch asf-site updated: Updated site at revision dc9a9dc

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 00a6daf Updated site at revision

[GitHub] ivankelly commented on issue #1513: Managed ledger uses ReadHandle in read path

2018-04-10 Thread GitBox
ivankelly commented on issue #1513: Managed ledger uses ReadHandle in read path URL: https://github.com/apache/incubator-pulsar/pull/1513#issuecomment-380022561 retest this please // ManagedCursorTest.cursorPersistenceAsyncMarkDeleteSameThread --

[GitHub] sijie opened a new pull request #1535: (WIP) Introduce Short Topic Name

2018-04-10 Thread GitBox
sijie opened a new pull request #1535: (WIP) Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535 Short Topic Name can be 1) "//" or 2) "" This is an automated message from the Apache Git Se

[GitHub] sijie commented on issue #1535: (WIP) Introduce Short Topic Name

2018-04-10 Thread GitBox
sijie commented on issue #1535: (WIP) Introduce Short Topic Name URL: https://github.com/apache/incubator-pulsar/pull/1535#issuecomment-380032082 @merlimat - here the WIP for PIP-11. Can you check if this is what you were thinking? If so, I can continue in this direction. -

[GitHub] srkukarni commented on issue #1534: Implement Cassandra Sink

2018-04-10 Thread GitBox
srkukarni commented on issue #1534: Implement Cassandra Sink URL: https://github.com/apache/incubator-pulsar/pull/1534#issuecomment-380034457 retest this please This is an automated message from the Apache Git Service. To resp

[GitHub] srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380036927 retest this please This is an automated message from the Apache Git

[GitHub] sijie opened a new issue #1536: Add "default" tenant & "default" namespace

2018-04-10 Thread GitBox
sijie opened a new issue #1536: Add "default" tenant & "default" namespace URL: https://github.com/apache/incubator-pulsar/issues/1536 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380052303 retest this please This is an automated message from the Apache Git

[GitHub] massakam opened a new pull request #1537: Log warn message if exception occurs while WebSocket proxy is sending…

2018-04-10 Thread GitBox
massakam opened a new pull request #1537: Log warn message if exception occurs while WebSocket proxy is sending… URL: https://github.com/apache/incubator-pulsar/pull/1537 …/receiving message Currently, even if an exception occurs while a producer/consumer inside WebSocket proxy is s

[GitHub] srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380056517 retest this please This is an automated message from the Apache Git

[GitHub] massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending…

2018-04-10 Thread GitBox
massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending… URL: https://github.com/apache/incubator-pulsar/pull/1537#issuecomment-380065235 retest this please This is an automate

[GitHub] ivankelly commented on issue #1513: Managed ledger uses ReadHandle in read path

2018-04-10 Thread GitBox
ivankelly commented on issue #1513: Managed ledger uses ReadHandle in read path URL: https://github.com/apache/incubator-pulsar/pull/1513#issuecomment-380079263 retest this please // ManagedCursorTest.cursorPersistenceAsyncMarkDeleteSameThread again (passes locally) & c++ test timeout ---

[GitHub] massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending…

2018-04-10 Thread GitBox
massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending… URL: https://github.com/apache/incubator-pulsar/pull/1537#issuecomment-380094596 retest this please This is an automate

[GitHub] massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending…

2018-04-10 Thread GitBox
massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending… URL: https://github.com/apache/incubator-pulsar/pull/1537#issuecomment-380094596 retest this please This is an automate

[GitHub] massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending…

2018-04-10 Thread GitBox
massakam commented on issue #1537: Log warn message if exception occurs while WebSocket proxy is sending… URL: https://github.com/apache/incubator-pulsar/pull/1537#issuecomment-380116513 retest this please This is an automate

[GitHub] zhaijack opened a new pull request #1538: Add rate limit for client lookup request

2018-04-10 Thread GitBox
zhaijack opened a new pull request #1538: Add rate limit for client lookup request URL: https://github.com/apache/incubator-pulsar/pull/1538 ### Motivation Currently broker side has config `maxConcurrentLookupRequest`, and client side has config `concurrentLookupRequest `. If clien

[GitHub] srkukarni commented on issue #1534: Implement Cassandra Sink

2018-04-10 Thread GitBox
srkukarni commented on issue #1534: Implement Cassandra Sink URL: https://github.com/apache/incubator-pulsar/pull/1534#issuecomment-380144770 retest this please This is an automated message from the Apache Git Service. To resp

[GitHub] srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380144838 retest this please This is an automated message from the Apache Git

[GitHub] merlimat closed pull request #1513: Managed ledger uses ReadHandle in read path

2018-04-10 Thread GitBox
merlimat closed pull request #1513: Managed ledger uses ReadHandle in read path URL: https://github.com/apache/incubator-pulsar/pull/1513 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Managed ledger uses ReadHandle in read path (#1513)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ab67386 Managed ledger uses ReadHandl

[GitHub] merlimat commented on a change in pull request #1507: Using Pulsar as a message queue (cookbook)

2018-04-10 Thread GitBox
merlimat commented on a change in pull request #1507: Using Pulsar as a message queue (cookbook) URL: https://github.com/apache/incubator-pulsar/pull/1507#discussion_r180496422 ## File path: site/docs/latest/cookbooks/message-queue.md ## @@ -0,0 +1,89 @@ +--- +title: Using

[incubator-pulsar] branch master updated: Fix for FQFN flag (#1528)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9525047 Fix for FQFN flag (#1528) 952

[incubator-pulsar] branch master updated: Log warn message if exception occurs while WebSocket proxy is sending/receiving message (#1537)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f4300bd Log warn message if exception

[GitHub] merlimat closed pull request #1537: Log warn message if exception occurs while WebSocket proxy is sending…

2018-04-10 Thread GitBox
merlimat closed pull request #1537: Log warn message if exception occurs while WebSocket proxy is sending… URL: https://github.com/apache/incubator-pulsar/pull/1537 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] merlimat closed pull request #1528: Fix for FQFN flag

2018-04-10 Thread GitBox
merlimat closed pull request #1528: Fix for FQFN flag URL: https://github.com/apache/incubator-pulsar/pull/1528 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fr

[GitHub] merlimat commented on issue #1468: Documentation for non-persistent topics

2018-04-10 Thread GitBox
merlimat commented on issue #1468: Documentation for non-persistent topics URL: https://github.com/apache/incubator-pulsar/pull/1468#issuecomment-380184315 @rdhabalia Please take a look as well This is an automated message fro

[GitHub] merlimat commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic

2018-04-10 Thread GitBox
merlimat commented on issue #1527: Reduce un-necessary work when doing bundle lookup for partitioned topic URL: https://github.com/apache/incubator-pulsar/pull/1527#issuecomment-380185898 > Thanks. From the test logs, ownership acquire seems not take to much time, but loadNamespaceTopics t

[GitHub] lucperkins commented on a change in pull request #1507: Using Pulsar as a message queue (cookbook)

2018-04-10 Thread GitBox
lucperkins commented on a change in pull request #1507: Using Pulsar as a message queue (cookbook) URL: https://github.com/apache/incubator-pulsar/pull/1507#discussion_r180510283 ## File path: site/docs/latest/cookbooks/message-queue.md ## @@ -0,0 +1,89 @@ +--- +title: Usi

[GitHub] merlimat opened a new pull request #1539: Fixed flaky test in managed ledger close path

2018-04-10 Thread GitBox
merlimat opened a new pull request #1539: Fixed flaky test in managed ledger close path URL: https://github.com/apache/incubator-pulsar/pull/1539 ### Motivation After recent changed, the managed ledger test with closing while add entry operations were happening became flaky. Fixed t

[GitHub] lucperkins commented on issue #1011: Managed ledger admin docs (WIP)

2018-04-10 Thread GitBox
lucperkins commented on issue #1011: Managed ledger admin docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1011#issuecomment-380200101 I'm going to close this for now and potentially re-open at a later date. I don't envision working on this within the next few weeks. Best to

[GitHub] lucperkins closed pull request #1011: Managed ledger admin docs (WIP)

2018-04-10 Thread GitBox
lucperkins closed pull request #1011: Managed ledger admin docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1011 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig

2018-04-10 Thread GitBox
lucperkins commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-380207479 I think the underlying issue here is that using a Protobuf definition as a source of truth for configuration management is a

[GitHub] ivankelly opened a new pull request #1540: Compaction sets read compacted flag when reading

2018-04-10 Thread GitBox
ivankelly opened a new pull request #1540: Compaction sets read compacted flag when reading URL: https://github.com/apache/incubator-pulsar/pull/1540 Previously compaction would read the whole backlog again, even though what was in the compacted topic ledger was sufficient for its pur

[GitHub] merlimat opened a new pull request #1541: Forget to recycle MessageMetadata protobuf object

2018-04-10 Thread GitBox
merlimat opened a new pull request #1541: Forget to recycle MessageMetadata protobuf object URL: https://github.com/apache/incubator-pulsar/pull/1541 ### Motivation `MessageMetadata` protobuf object was not not being put back into recycler pool.

[GitHub] jerrypeng commented on issue #1531: remove unnecessary proto def in FunctionsConfig

2018-04-10 Thread GitBox
jerrypeng commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-380215913 @lucperkins I have discussed with @sijie @srkukarni, we are going to create another class for functions that is user facing a

[GitHub] ivankelly opened a new pull request #1542: LedgerOffloader interface for ManagedLedger

2018-04-10 Thread GitBox
ivankelly opened a new pull request #1542: LedgerOffloader interface for ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1542 An interface which can be used for offloading ledgers to longterm storage. Master issue #1511 -

[GitHub] ivankelly commented on issue #1543: offloadPrefix interface for ManagedLedger

2018-04-10 Thread GitBox
ivankelly commented on issue #1543: offloadPrefix interface for ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1543#issuecomment-380217494 @zhaijack This is an automated message from the Apache Git Service

[GitHub] ivankelly opened a new pull request #1543: offloadPrefix interface for ManagedLedger

2018-04-10 Thread GitBox
ivankelly opened a new pull request #1543: offloadPrefix interface for ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1543 Method to offload a prefix of a managed ledger to longterm storage. Depends on a LedgerOffloader having been provided to the ManagedLedgerCon

[GitHub] ivankelly commented on issue #1542: LedgerOffloader interface for ManagedLedger

2018-04-10 Thread GitBox
ivankelly commented on issue #1542: LedgerOffloader interface for ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1542#issuecomment-380217780 @zhaijack This is an automated message from the Apache Git Servi

[GitHub] ivankelly commented on issue #1542: LedgerOffloader interface for ManagedLedger

2018-04-10 Thread GitBox
ivankelly commented on issue #1542: LedgerOffloader interface for ManagedLedger URL: https://github.com/apache/incubator-pulsar/pull/1542#issuecomment-380217830 retest this please // ManagedLedgerBkTest.managedLedgerClosed Thi

[incubator-pulsar] branch master updated: Fixed flaky test in managed ledger close path (#1539)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b22769b Fixed flaky test in managed l

[GitHub] merlimat closed pull request #1539: Fixed flaky test in managed ledger close path

2018-04-10 Thread GitBox
merlimat closed pull request #1539: Fixed flaky test in managed ledger close path URL: https://github.com/apache/incubator-pulsar/pull/1539 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Compaction sets read compacted flag when reading (#1540)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 770ddf0 Compaction sets read compacte

[GitHub] merlimat closed pull request #1540: Compaction sets read compacted flag when reading

2018-04-10 Thread GitBox
merlimat closed pull request #1540: Compaction sets read compacted flag when reading URL: https://github.com/apache/incubator-pulsar/pull/1540 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] lucperkins commented on issue #1431: Additional checks for Pulsar Function jar submission

2018-04-10 Thread GitBox
lucperkins commented on issue #1431: Additional checks for Pulsar Function jar submission URL: https://github.com/apache/incubator-pulsar/pull/1431#issuecomment-380262139 retest this please This is an automated message from t

[GitHub] lucperkins commented on issue #1431: Additional checks for Pulsar Function jar submission

2018-04-10 Thread GitBox
lucperkins commented on issue #1431: Additional checks for Pulsar Function jar submission URL: https://github.com/apache/incubator-pulsar/pull/1431#issuecomment-380265577 retest this please This is an automated message from t

[GitHub] sijie closed pull request #1534: Implement Cassandra Sink

2018-04-10 Thread GitBox
sijie closed pull request #1534: Implement Cassandra Sink URL: https://github.com/apache/incubator-pulsar/pull/1534 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[incubator-pulsar] branch master updated: Implement Cassandra Sink (#1534)

2018-04-10 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 4f3ac36 Implement Cassandra Sink (#153

[GitHub] yush1ga commented on issue #1352: Delete inactive subscriptions automatically

2018-04-10 Thread GitBox
yush1ga commented on issue #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-380274796 retest this please This is an automated message from the Apache Git

[GitHub] yush1ga commented on issue #1352: Delete inactive subscriptions automatically

2018-04-10 Thread GitBox
yush1ga commented on issue #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-380274796 retest this please This is an automated message from the Apache Git

[GitHub] srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
srkukarni commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380277808 retest this please This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
jerrypeng commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380278950 retest this please This is an automated message from the Apache Git

[GitHub] merlimat opened a new pull request #1544: Fix for cursorPersistenceAsyncMarkDeleteSameThread

2018-04-10 Thread GitBox
merlimat opened a new pull request #1544: Fix for cursorPersistenceAsyncMarkDeleteSameThread URL: https://github.com/apache/incubator-pulsar/pull/1544 ### Motivation In #1539 there was an attempt to fix the `ManagedCursorTest.cursorPersistenceAsyncMarkDeleteSameThread()` test. One

[incubator-pulsar] branch master updated: Pulsar Functions triggering overview (#1503)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 884b1d1 Pulsar Functions triggering o

[GitHub] sijie commented on issue #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
sijie commented on issue #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533#issuecomment-380282031 retest this please This is an automated message from the Apache Git Ser

[GitHub] merlimat closed pull request #1503: Pulsar Functions triggering overview

2018-04-10 Thread GitBox
merlimat closed pull request #1503: Pulsar Functions triggering overview URL: https://github.com/apache/incubator-pulsar/pull/1503 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] srkukarni opened a new pull request #1545: Added Aerospike Sink

2018-04-10 Thread GitBox
srkukarni opened a new pull request #1545: Added Aerospike Sink URL: https://github.com/apache/incubator-pulsar/pull/1545 ### Motivation Added Aerospike Sink to the Pulsar Connect framework ### Modifications Describe the modifications you've done. ### Result

[GitHub] srkukarni commented on issue #1545: Added Aerospike Sink

2018-04-10 Thread GitBox
srkukarni commented on issue #1545: Added Aerospike Sink URL: https://github.com/apache/incubator-pulsar/pull/1545#issuecomment-380284965 @merlimat @sijie This is an automated message from the Apache Git Service. To respo

[GitHub] merlimat closed pull request #1544: Fix for cursorPersistenceAsyncMarkDeleteSameThread

2018-04-10 Thread GitBox
merlimat closed pull request #1544: Fix for cursorPersistenceAsyncMarkDeleteSameThread URL: https://github.com/apache/incubator-pulsar/pull/1544 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[incubator-pulsar] branch master updated: Fix for cursorPersistenceAsyncMarkDeleteSameThread (#1544)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ede7ffe Fix for cursorPersistenceAsyn

[GitHub] rdhabalia opened a new pull request #1546: Fix: handle failure of topic stat update

2018-04-10 Thread GitBox
rdhabalia opened a new pull request #1546: Fix: handle failure of topic stat update URL: https://github.com/apache/incubator-pulsar/pull/1546 ### Motivation Recently, we have seen multiple scenarios where due to incorrect state of one of the `ManagedCursor`, broker fails to prepare

[GitHub] zhaijack commented on issue #1538: Add rate limit for client lookup requests

2018-04-10 Thread GitBox
zhaijack commented on issue #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#issuecomment-380297860 retest this please This is an automated message from the Apache Git

[GitHub] jerrypeng commented on issue #1531: remove unnecessary proto def in FunctionsConfig

2018-04-10 Thread GitBox
jerrypeng commented on issue #1531: remove unnecessary proto def in FunctionsConfig URL: https://github.com/apache/incubator-pulsar/pull/1531#issuecomment-380298095 retest this please This is an automated message from the Apa

[GitHub] zhaijack opened a new pull request #1547: Make client keepAliveInterval configurable in client side

2018-04-10 Thread GitBox
zhaijack opened a new pull request #1547: Make client keepAliveInterval configurable in client side URL: https://github.com/apache/incubator-pulsar/pull/1547 ### Motivation Currently `keepAliveInterval` is hard coded as 30s in ClientCnx, Would like to make it configurable. ##

[GitHub] massakam commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-04-10 Thread GitBox
massakam commented on a change in pull request #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r180613509 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java ##

[GitHub] yush1ga commented on a change in pull request #1352: Delete inactive subscriptions automatically

2018-04-10 Thread GitBox
yush1ga commented on a change in pull request #1352: Delete inactive subscriptions automatically URL: https://github.com/apache/incubator-pulsar/pull/1352#discussion_r180614996 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursor.java ##

[GitHub] srkukarni commented on issue #1545: Added Aerospike Sink

2018-04-10 Thread GitBox
srkukarni commented on issue #1545: Added Aerospike Sink URL: https://github.com/apache/incubator-pulsar/pull/1545#issuecomment-380309676 retest this please This is an automated message from the Apache Git Service. To respond

[incubator-pulsar] branch master updated: Refactor JavaInstanceRunnable (#1533)

2018-04-10 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 22e45e7 Refactor JavaInstanceRunnable

[GitHub] merlimat closed pull request #1533: [functions] Refactor JavaInstanceRunnable

2018-04-10 Thread GitBox
merlimat closed pull request #1533: [functions] Refactor JavaInstanceRunnable URL: https://github.com/apache/incubator-pulsar/pull/1533 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Added Aerospike Sink (#1545)

2018-04-10 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e370b97 Added Aerospike Sink (#1545) e

[GitHub] sijie closed pull request #1545: Added Aerospike Sink

2018-04-10 Thread GitBox
sijie closed pull request #1545: Added Aerospike Sink URL: https://github.com/apache/incubator-pulsar/pull/1545 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (fr

[GitHub] merlimat commented on a change in pull request #1547: Make client keepAliveInterval configurable in client side

2018-04-10 Thread GitBox
merlimat commented on a change in pull request #1547: Make client keepAliveInterval configurable in client side URL: https://github.com/apache/incubator-pulsar/pull/1547#discussion_r180630809 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java ##

[GitHub] merlimat commented on a change in pull request #1547: Make client keepAliveInterval configurable in client side

2018-04-10 Thread GitBox
merlimat commented on a change in pull request #1547: Make client keepAliveInterval configurable in client side URL: https://github.com/apache/incubator-pulsar/pull/1547#discussion_r180630681 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ClientConfigu

[GitHub] zhaijack commented on issue #1517: Reader#hasMessageAvailable can report false when it should be true

2018-04-10 Thread GitBox
zhaijack commented on issue #1517: Reader#hasMessageAvailable can report false when it should be true URL: https://github.com/apache/incubator-pulsar/issues/1517#issuecomment-380322987 Thanks @ivankelly will handle this. Th

[GitHub] zhaijack commented on issue #1538: Add rate limit for client lookup requests

2018-04-10 Thread GitBox
zhaijack commented on issue #1538: Add rate limit for client lookup requests URL: https://github.com/apache/incubator-pulsar/pull/1538#issuecomment-380297860 retest this please This is an automated message from the Apache Git

[GitHub] merlimat opened a new pull request #1548: Fixed race condition intruduced managed ledger addEntry introduced in #1521

2018-04-10 Thread GitBox
merlimat opened a new pull request #1548: Fixed race condition intruduced managed ledger addEntry introduced in #1521 URL: https://github.com/apache/incubator-pulsar/pull/1548 ### Motivation The change in #1521 introduced a race between multiple writers since the enqueing and sendin