[GitHub] jerrypeng opened a new pull request #1649: refactoring functions to use source interface

2018-04-25 Thread GitBox
jerrypeng opened a new pull request #1649: refactoring functions to use source interface URL: https://github.com/apache/incubator-pulsar/pull/1649 This is an automated message from the Apache Git Service. To respond to

[GitHub] jerrypeng commented on issue #1649: refactoring functions to use source interface

2018-04-25 Thread GitBox
jerrypeng commented on issue #1649: refactoring functions to use source interface URL: https://github.com/apache/incubator-pulsar/pull/1649#issuecomment-384517581 @sijie @srkukarni please review This is an automated message

[GitHub] rdhabalia commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics

2018-04-25 Thread GitBox
rdhabalia commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics URL: https://github.com/apache/incubator-pulsar/pull/1647#discussion_r184277172 ## File path:

[GitHub] rdhabalia closed pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics

2018-04-25 Thread GitBox
rdhabalia closed pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics URL: https://github.com/apache/incubator-pulsar/pull/1647 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] merlimat commented on issue #1580: Modified functions producer consumers to use new builder based api

2018-04-25 Thread GitBox
merlimat commented on issue #1580: Modified functions producer consumers to use new builder based api URL: https://github.com/apache/incubator-pulsar/pull/1580#issuecomment-384518513 retest this please This is an automated

[incubator-pulsar] branch master updated: Fix: remove local-cluster from replication list of global-namespace should clean topics (#1647)

2018-04-25 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9746ea4 Fix: remove local-cluster

[GitHub] merlimat commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics

2018-04-25 Thread GitBox
merlimat commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics URL: https://github.com/apache/incubator-pulsar/pull/1647#discussion_r184275718 ## File path:

[GitHub] merlimat closed pull request #1646: Fix the exception output for admin commands

2018-04-25 Thread GitBox
merlimat closed pull request #1646: Fix the exception output for admin commands URL: https://github.com/apache/incubator-pulsar/pull/1646 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Hide namespace cli commands that are no longer relevant (#1645)

2018-04-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fc3417f Hide namespace cli commands

[incubator-pulsar] branch master updated: Fix the exception output for admin commands (#1646)

2018-04-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 43d2257 Fix the exception output for

[GitHub] merlimat closed pull request #1645: Hide namespace cli commands that are no longer relevant

2018-04-25 Thread GitBox
merlimat closed pull request #1645: Hide namespace cli commands that are no longer relevant URL: https://github.com/apache/incubator-pulsar/pull/1645 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed issue #1119: Add pulsar-prometheus docker image to pulsar repo

2018-04-25 Thread GitBox
sijie closed issue #1119: Add pulsar-prometheus docker image to pulsar repo URL: https://github.com/apache/incubator-pulsar/issues/1119 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #1119: Add pulsar-prometheus docker image to pulsar repo

2018-04-25 Thread GitBox
sijie commented on issue #1119: Add pulsar-prometheus docker image to pulsar repo URL: https://github.com/apache/incubator-pulsar/issues/1119#issuecomment-384203303 This fix is contributed by @zhaijack This is an

[GitHub] sijie commented on issue #621: Documentation for deployment of a single cluster in a data center

2018-04-25 Thread GitBox
sijie commented on issue #621: Documentation for deployment of a single cluster in a data center URL: https://github.com/apache/incubator-pulsar/issues/621#issuecomment-384207473 This is fixed by multiple PRs. This is an

[GitHub] sijie closed issue #621: Documentation for deployment of a single cluster in a data center

2018-04-25 Thread GitBox
sijie closed issue #621: Documentation for deployment of a single cluster in a data center URL: https://github.com/apache/incubator-pulsar/issues/621 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on issue #1637: LedgerOffloader interface allows two phase update

2018-04-25 Thread GitBox
sijie commented on issue #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637#issuecomment-384191685 @ivankelly - #1549 is merged. can you rebase this one? This

[incubator-pulsar] branch master updated: offloadPrefix implementation for managed ledger (#1549)

2018-04-25 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 785d2a2 offloadPrefix implementation

[GitHub] sijie commented on issue #404: Intermittent test failure: OwnershipCacheTest.testGetOwner

2018-04-25 Thread GitBox
sijie commented on issue #404: Intermittent test failure: OwnershipCacheTest.testGetOwner URL: https://github.com/apache/incubator-pulsar/issues/404#issuecomment-384206108 This is fixed by #503 This is an automated message

[GitHub] sijie closed issue #404: Intermittent test failure: OwnershipCacheTest.testGetOwner

2018-04-25 Thread GitBox
sijie closed issue #404: Intermittent test failure: OwnershipCacheTest.testGetOwner URL: https://github.com/apache/incubator-pulsar/issues/404 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie closed issue #1159: Update bookkeeper version to apache release

2018-04-25 Thread GitBox
sijie closed issue #1159: Update bookkeeper version to apache release URL: https://github.com/apache/incubator-pulsar/issues/1159 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] sijie commented on issue #1159: Update bookkeeper version to apache release

2018-04-25 Thread GitBox
sijie commented on issue #1159: Update bookkeeper version to apache release URL: https://github.com/apache/incubator-pulsar/issues/1159#issuecomment-384197939 This is fixed by #1605 This is an automated message from the

[GitHub] sijie commented on issue #1020: Inject system-env variables to pulsar configuration

2018-04-25 Thread GitBox
sijie commented on issue #1020: Inject system-env variables to pulsar configuration URL: https://github.com/apache/incubator-pulsar/pull/1020#issuecomment-384198660 @jai1 @rdhabalia what is the take here? are we targeting this for 2.0? If not, can we move it to 2.1?

[GitHub] sijie closed issue #893: Avoid confliction of subscription names for multiple tenants

2018-04-25 Thread GitBox
sijie closed issue #893: Avoid confliction of subscription names for multiple tenants URL: https://github.com/apache/incubator-pulsar/issues/893 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie closed issue #980: Add optional metadata labels to producers and consumers

2018-04-25 Thread GitBox
sijie closed issue #980: Add optional metadata labels to producers and consumers URL: https://github.com/apache/incubator-pulsar/issues/980 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #937: Allow reader to detect when it's caught up with writers

2018-04-25 Thread GitBox
sijie commented on issue #937: Allow reader to detect when it's caught up with writers URL: https://github.com/apache/incubator-pulsar/issues/937#issuecomment-384202263 This fix was contributed by @zhaijack This is an

[GitHub] sijie commented on issue #1003: Intermittent test failure DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher

2018-04-25 Thread GitBox
sijie commented on issue #1003: Intermittent test failure DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher URL: https://github.com/apache/incubator-pulsar/issues/1003#issuecomment-384202707 This is fixed by #1144

[GitHub] sijie closed issue #1003: Intermittent test failure DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher

2018-04-25 Thread GitBox
sijie closed issue #1003: Intermittent test failure DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher URL: https://github.com/apache/incubator-pulsar/issues/1003 This is an automated message

[GitHub] sijie commented on issue #980: Add optional metadata labels to producers and consumers

2018-04-25 Thread GitBox
sijie commented on issue #980: Add optional metadata labels to producers and consumers URL: https://github.com/apache/incubator-pulsar/issues/980#issuecomment-384202637 This is fixed by #1009 #1031 This is an automated

[GitHub] sijie commented on issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools

2018-04-25 Thread GitBox
sijie commented on issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools URL: https://github.com/apache/incubator-pulsar/issues/766#issuecomment-384208618 This is fixed by #768 This is an

[GitHub] sijie closed issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools

2018-04-25 Thread GitBox
sijie closed issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools URL: https://github.com/apache/incubator-pulsar/issues/766 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #577: CPP add receiveAsync API

2018-04-25 Thread GitBox
sijie commented on issue #577: CPP add receiveAsync API URL: https://github.com/apache/incubator-pulsar/pull/577#issuecomment-384197380 it seems that this PR was from 1.19.0-incubating. so I will move it out of 2.0, if we need this for 2.0, let's add it back.

[GitHub] sijie commented on issue #1505: Proxy admin web requests

2018-04-25 Thread GitBox
sijie commented on issue #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#issuecomment-384199988 @merlimat can you review this again? This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1138: Test Timeouts in ReplicatorTest

2018-04-25 Thread GitBox
sijie commented on issue #1138: Test Timeouts in ReplicatorTest URL: https://github.com/apache/incubator-pulsar/issues/1138#issuecomment-384203524 This is fixed by #1154 #1354 This is an automated message from the Apache

[GitHub] sijie closed issue #1138: Test Timeouts in ReplicatorTest

2018-04-25 Thread GitBox
sijie closed issue #1138: Test Timeouts in ReplicatorTest URL: https://github.com/apache/incubator-pulsar/issues/1138 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie commented on issue #1119: Add pulsar-prometheus docker image to pulsar repo

2018-04-25 Thread GitBox
sijie commented on issue #1119: Add pulsar-prometheus docker image to pulsar repo URL: https://github.com/apache/incubator-pulsar/issues/1119#issuecomment-384203182 This is fixed by #1127 This is an automated message from

[GitHub] sijie commented on issue #671: Should authParamsString for Authentication support another format ?

2018-04-25 Thread GitBox
sijie commented on issue #671: Should authParamsString for Authentication support another format ? URL: https://github.com/apache/incubator-pulsar/issues/671#issuecomment-384207959 This is fixed by #721 This is an

[GitHub] sijie closed issue #671: Should authParamsString for Authentication support another format ?

2018-04-25 Thread GitBox
sijie closed issue #671: Should authParamsString for Authentication support another format ? URL: https://github.com/apache/incubator-pulsar/issues/671 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-04-25 Thread GitBox
sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-384196196 retest this please

[GitHub] sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-04-25 Thread GitBox
sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-384196272 @merlimat - can we move forward with this change?

[GitHub] sijie closed issue #937: Allow reader to detect when it's caught up with writers

2018-04-25 Thread GitBox
sijie closed issue #937: Allow reader to detect when it's caught up with writers URL: https://github.com/apache/incubator-pulsar/issues/937 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #937: Allow reader to detect when it's caught up with writers

2018-04-25 Thread GitBox
sijie commented on issue #937: Allow reader to detect when it's caught up with writers URL: https://github.com/apache/incubator-pulsar/issues/937#issuecomment-384202019 This is fixed by #1066 This is an automated message

[GitHub] sijie closed issue #1167: Add test for C++ client with proxy

2018-04-25 Thread GitBox
sijie closed issue #1167: Add test for C++ client with proxy URL: https://github.com/apache/incubator-pulsar/issues/1167 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie closed issue #237: Intermittent test failures in ProxyPublishConsumeTest. socketTest

2018-04-25 Thread GitBox
sijie closed issue #237: Intermittent test failures in ProxyPublishConsumeTest. socketTest URL: https://github.com/apache/incubator-pulsar/issues/237 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie closed issue #617: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

2018-04-25 Thread GitBox
sijie closed issue #617: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice URL: https://github.com/apache/incubator-pulsar/issues/617 This is an automated message from the Apache Git

[GitHub] sijie commented on issue #617: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

2018-04-25 Thread GitBox
sijie commented on issue #617: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice URL: https://github.com/apache/incubator-pulsar/issues/617#issuecomment-384207122 Fixed by @ivankelly This

[GitHub] sijie closed pull request #1549: offloadPrefix implementation for managed ledger

2018-04-25 Thread GitBox
sijie closed pull request #1549: offloadPrefix implementation for managed ledger URL: https://github.com/apache/incubator-pulsar/pull/1549 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sijie commented on issue #1063: ENH: Add code formatter for Java

2018-04-25 Thread GitBox
sijie commented on issue #1063: ENH: Add code formatter for Java URL: https://github.com/apache/incubator-pulsar/pull/1063#issuecomment-384196820 @Licht-T @merlimat - are we targeting this for 2.0? If not, can we move it to 2.1?

[GitHub] sijie commented on issue #1072: Support pluggable authorization mechansim

2018-04-25 Thread GitBox
sijie commented on issue #1072: Support pluggable authorization mechansim URL: https://github.com/apache/incubator-pulsar/issues/1072#issuecomment-384196581 This is fixed by #1200 This is an automated message from the

[GitHub] sijie commented on issue #577: CPP add receiveAsync API

2018-04-25 Thread GitBox
sijie commented on issue #577: CPP add receiveAsync API URL: https://github.com/apache/incubator-pulsar/pull/577#issuecomment-384197011 @rdhabalia what is the current state of this PR? are we targeting this for 2.0? If not, can we move it to 2.1?

[GitHub] sijie closed issue #1072: Support pluggable authorization mechansim

2018-04-25 Thread GitBox
sijie closed issue #1072: Support pluggable authorization mechansim URL: https://github.com/apache/incubator-pulsar/issues/1072 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] sijie commented on issue #1183: Apply make format into Python C++ wrapper client

2018-04-25 Thread GitBox
sijie commented on issue #1183: Apply make format into Python C++ wrapper client URL: https://github.com/apache/incubator-pulsar/pull/1183#issuecomment-384198235 @Licht-T @merlimat are we targeting this for 2.0? If not, can we move it to 2.1?

[GitHub] sijie commented on issue #894: Guarantee that messages are encrypted

2018-04-25 Thread GitBox
sijie commented on issue #894: Guarantee that messages are encrypted URL: https://github.com/apache/incubator-pulsar/issues/894#issuecomment-384200712 This is fixed by #904 This is an automated message from the Apache Git

[GitHub] sijie commented on issue #893: Avoid confliction of subscription names for multiple tenants

2018-04-25 Thread GitBox
sijie commented on issue #893: Avoid confliction of subscription names for multiple tenants URL: https://github.com/apache/incubator-pulsar/issues/893#issuecomment-384200593 This is fixed by #899 This is an automated

[GitHub] sijie closed issue #915: Intermittent test failure: ZookeeperCacheLoaderTest:: testZookeeperCacheLoader

2018-04-25 Thread GitBox
sijie closed issue #915: Intermittent test failure: ZookeeperCacheLoaderTest:: testZookeeperCacheLoader URL: https://github.com/apache/incubator-pulsar/issues/915 This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #915: Intermittent test failure: ZookeeperCacheLoaderTest:: testZookeeperCacheLoader

2018-04-25 Thread GitBox
sijie commented on issue #915: Intermittent test failure: ZookeeperCacheLoaderTest:: testZookeeperCacheLoader URL: https://github.com/apache/incubator-pulsar/issues/915#issuecomment-384200916 This is fixed by #916 This is

[GitHub] sijie closed issue #894: Guarantee that messages are encrypted

2018-04-25 Thread GitBox
sijie closed issue #894: Guarantee that messages are encrypted URL: https://github.com/apache/incubator-pulsar/issues/894 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] sijie commented on issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

2018-04-25 Thread GitBox
sijie commented on issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice URL: https://github.com/apache/incubator-pulsar/issues/1145#issuecomment-384204053 This is fixed by #1360

[GitHub] sijie closed issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

2018-04-25 Thread GitBox
sijie closed issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice URL: https://github.com/apache/incubator-pulsar/issues/1145 This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1167: Add test for C++ client with proxy

2018-04-25 Thread GitBox
sijie commented on issue #1167: Add test for C++ client with proxy URL: https://github.com/apache/incubator-pulsar/issues/1167#issuecomment-384204278 This is fixed by #1124 This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

2018-04-25 Thread GitBox
sijie commented on issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice URL: https://github.com/apache/incubator-pulsar/issues/1145#issuecomment-384204155 The fix is contributed by @ivankelly

[GitHub] sijie commented on issue #1248: Start Proxy in TLS only mode.

2018-04-25 Thread GitBox
sijie commented on issue #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#issuecomment-384208924 @jai1 are we going to include this in 2.0? shall we move it to 2.1? This is an

[GitHub] sijie closed issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie closed issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1288: Provide documentation for running BookKeeper auto-recovery

2018-04-25 Thread GitBox
sijie commented on issue #1288: Provide documentation for running BookKeeper auto-recovery URL: https://github.com/apache/incubator-pulsar/issues/1288#issuecomment-384210006 @lucperkins are you working on this? This is an

[GitHub] sijie commented on issue #1287: Provide documentation for the load manager and bundles

2018-04-25 Thread GitBox
sijie commented on issue #1287: Provide documentation for the load manager and bundles URL: https://github.com/apache/incubator-pulsar/issues/1287#issuecomment-384210151 @lucperkins is this done? This is an automated

[GitHub] sijie commented on issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie commented on issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267#issuecomment-384209722 fixed by #1156 This is an automated message from

[GitHub] sijie opened a new issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie opened a new issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267 *Problem* Currently failover subscription is sorting the consumers. so if a consumer who consumer name is always the first consumer

[GitHub] sijie commented on issue #1446: Pulsar 2.0 Documentation

2018-04-25 Thread GitBox
sijie commented on issue #1446: Pulsar 2.0 Documentation URL: https://github.com/apache/incubator-pulsar/issues/1446#issuecomment-384213624 @lucperkins can you check the boxes what items are done? This is an automated

[GitHub] sijie commented on issue #1466: Topic compaction documentation (WIP)

2018-04-25 Thread GitBox
sijie commented on issue #1466: Topic compaction documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1466#issuecomment-384213099 @lucperkins what is the state of this PR? @ivankelly shall we include this for 2.0?

[GitHub] sijie commented on issue #1457: Schema registry documentation (WIP)

2018-04-25 Thread GitBox
sijie commented on issue #1457: Schema registry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1457#issuecomment-384213267 @lucperkins what is the state of this PR? is it ready for review? @mgodave can you review this?

[GitHub] ivankelly opened a new pull request #1639: Rest API for Ledger Offloading

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1639: Rest API for Ledger Offloading URL: https://github.com/apache/incubator-pulsar/pull/1639 Implemented for both V1 and V2 topic name formats. API takes a message ID, up to which the broker will try to offload messages. It returns the message ID

[GitHub] sijie commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
sijie commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384211672 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1580: Modified functions producer consumers to use new builder based api

2018-04-25 Thread GitBox
sijie commented on issue #1580: Modified functions producer consumers to use new builder based api URL: https://github.com/apache/incubator-pulsar/pull/1580#issuecomment-384211396 @merlimat can you rebase this? This is an

[GitHub] sijie commented on issue #1266: Pass all Apache Podling Website Checks

2018-04-25 Thread GitBox
sijie commented on issue #1266: Pass all Apache Podling Website Checks URL: https://github.com/apache/incubator-pulsar/issues/1266#issuecomment-384215343 (Move this to 2.1.0, since it is not a blocker for 2.0) This is an

[GitHub] sijie commented on issue #1632: Avoid creating different message object for pulsar sink connector

2018-04-25 Thread GitBox
sijie commented on issue #1632: Avoid creating different message object for pulsar sink connector URL: https://github.com/apache/incubator-pulsar/pull/1632#issuecomment-384210662 @rdhabalia since #1636 is already merged, shall we close this one?

[GitHub] sijie commented on issue #1546: Fix: handle failure of topic stat update

2018-04-25 Thread GitBox
sijie commented on issue #1546: Fix: handle failure of topic stat update URL: https://github.com/apache/incubator-pulsar/pull/1546#issuecomment-384211952 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
sijie commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384211810 @merlimat can you review @mgodave 's latest change? This is an automated message from the

[GitHub] rdhabalia commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-25 Thread GitBox
rdhabalia commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#issuecomment-384212326 > since we are close to 2.0 release, shall we move this PR to 2.1? Sure, we can move it to next

[GitHub] ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update

2018-04-25 Thread GitBox
ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637#issuecomment-384244943 @sijie these changes were already in #1549 . My idea was to merge this one first, to keep the #1549 focused on the

[GitHub] ivankelly closed pull request #1637: LedgerOffloader interface allows two phase update

2018-04-25 Thread GitBox
ivankelly closed pull request #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] rdhabalia commented on issue #577: CPP add receiveAsync API

2018-04-25 Thread GitBox
rdhabalia commented on issue #577: CPP add receiveAsync API URL: https://github.com/apache/incubator-pulsar/pull/577#issuecomment-384211303 sure. I will rebase it and we can take it to next release. This is an automated

[GitHub] sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-25 Thread GitBox
sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#issuecomment-38421 @rdhabalia - since we are close to 2.0 release, shall we move this PR to 2.1?

[GitHub] sijie commented on issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie commented on issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267#issuecomment-384209722 fixed by #1156 This is an automated message from

[GitHub] sijie commented on issue #1599: Throw illegal state exception instead of NPE in zk-cache when no session available

2018-04-25 Thread GitBox
sijie commented on issue #1599: Throw illegal state exception instead of NPE in zk-cache when no session available URL: https://github.com/apache/incubator-pulsar/pull/1599#issuecomment-384210839 retest this please This is

[GitHub] sijie commented on issue #1509: Fix init of Input CustomSerDe of function

2018-04-25 Thread GitBox
sijie commented on issue #1509: Fix init of Input CustomSerDe of function URL: https://github.com/apache/incubator-pulsar/pull/1509#issuecomment-384212529 @rdhabalia are you still working on this change? shall we move this to 2.1?

[GitHub] sijie commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
sijie commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384212850 @lucperkins what is the state of this PR? @srkukarni shall we include this for 2.0?

[GitHub] sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-25 Thread GitBox
sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#issuecomment-384215856 @rdhabalia thank you This is an automated

[GitHub] ivankelly opened a new pull request #1640: Read OffloadedLedger if available

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1640: Read OffloadedLedger if available URL: https://github.com/apache/incubator-pulsar/pull/1640 If a ledger has been previously offloaded to long term storage, read the ledger from long term storage, rather than from bookkeeper. Master issue

[GitHub] ivankelly opened a new pull request #1641: Delete offloaded ledger when ledger deleted

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1641: Delete offloaded ledger when ledger deleted URL: https://github.com/apache/incubator-pulsar/pull/1641 When a managed ledger trims a ledger, if that ledger has been offloaded to long term storage, delete it from long term storage also.

[GitHub] srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384302533 I think we need to complete this for 2.0 This is an automated message

[GitHub] ivankelly opened a new pull request #1643: Offloading prints wrong log on exception

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1643: Offloading prints wrong log on exception URL: https://github.com/apache/incubator-pulsar/pull/1643 The check for exception was backwards, so it was always warning in the happy case, and reporting success in the case of failure. Master

[GitHub] lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384302873 Work in progress. Will the Python API be complete by 2.0? On Wed, Apr 25, 2018 at 7:15 AM Sanjeev Kulkarni

[GitHub] srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384304741 Except for counter support, Python api/implementation already exists

[GitHub] ivankelly opened a new pull request #1642: Clock interface in ManagedLedger for testing

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1642: Clock interface in ManagedLedger for testing URL: https://github.com/apache/incubator-pulsar/pull/1642 Managed ledger has background tasks which act on ledgers after configured times. To test these, we need to be able to move through time.

[GitHub] ivankelly commented on issue #1639: Rest API for Ledger Offloading

2018-04-25 Thread GitBox
ivankelly commented on issue #1639: Rest API for Ledger Offloading URL: https://github.com/apache/incubator-pulsar/pull/1639#issuecomment-384309216 retest this please // integration test timeout This is an automated message

[GitHub] ivankelly commented on issue #1640: Read OffloadedLedger if available

2018-04-25 Thread GitBox
ivankelly commented on issue #1640: Read OffloadedLedger if available URL: https://github.com/apache/incubator-pulsar/pull/1640#issuecomment-384310152 retest this please // ManagedCursorTest.testReplayEntries This is an

[GitHub] merlimat commented on a change in pull request #1642: Clock interface in ManagedLedger for testing

2018-04-25 Thread GitBox
merlimat commented on a change in pull request #1642: Clock interface in ManagedLedger for testing URL: https://github.com/apache/incubator-pulsar/pull/1642#discussion_r184136903 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java

[GitHub] mgodave commented on issue #1457: Schema registry documentation (WIP)

2018-04-25 Thread GitBox
mgodave commented on issue #1457: Schema registry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1457#issuecomment-384368789 On the list for today. This is an automated message from the Apache Git

[GitHub] lucperkins commented on issue #1457: Schema registry documentation (WIP)

2018-04-25 Thread GitBox
lucperkins commented on issue #1457: Schema registry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1457#issuecomment-384372490 @sijie @mgodave This is NOT ready for review, and work on this can really only continue when the schema registry is integrated with the

[GitHub] lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384328497 @srkukarni I know, I was waiting on counter support, but if that's not required for API completion then I can resume work on this.

[GitHub] srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384362636 I consider Counters as advanced features that allows us to do stateful functions, but without them stateless functions are still

  1   2   >