merlimat opened a new pull request #1689: When preparing pulsar-build Docker
image, ensure apt-get update is not cached
URL: https://github.com/apache/incubator-pulsar/pull/1689
### Motivation
If the `apt-get update` is in a different `RUN ` command, Docker will cache
it
merlimat closed pull request #1677: Add tenant and namespace getters to Python
context
URL: https://github.com/apache/incubator-pulsar/pull/1677
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new d5780ef Add tenant and namespace
merlimat closed pull request #1689: When preparing pulsar-build Docker image,
ensure apt-get update is not cached
URL: https://github.com/apache/incubator-pulsar/pull/1689
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
mgodave opened a new pull request #1692: Return an error if schema is
incompatible
URL: https://github.com/apache/incubator-pulsar/pull/1692
We added the notion of schema "compatibility" but did not handle an
incompatible schema in the REST interface. This is to handle that.
srkukarni commented on issue #1688: Check if javaInstance is created in the
first place before invocing close
URL: https://github.com/apache/incubator-pulsar/pull/1688#issuecomment-385540555
retest this please
This is an
merlimat opened a new pull request #1694: Renamed Schema.IDENTITY into
Schema.BYTES
URL: https://github.com/apache/incubator-pulsar/pull/1694
### Motivation
`Schema.BYTES` seems to resonate more with people, so renaming before
releasing it.
srkukarni commented on issue #1688: Check if javaInstance is created in the
first place before invocing close
URL: https://github.com/apache/incubator-pulsar/pull/1688#issuecomment-385521411
@sijie @jerrypeng
This is an
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new e9a1b9a additional refactoring to use
merlimat opened a new pull request #1695: Remove "global" from returned
clusters list
URL: https://github.com/apache/incubator-pulsar/pull/1695
### Motivation
`global` clusters is still returned in the clusters list command. Since this
was an artificial placeholder, which is not
merlimat closed pull request #1686: Protobuf documentation update
URL: https://github.com/apache/incubator-pulsar/pull/1686
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 31131c2 Protobuf documentation
ivankelly opened a new pull request #1687: Don't offload empty ledgers
URL: https://github.com/apache/incubator-pulsar/pull/1687
It shouldn't be possible for a ledger in a managed ledger to be
empty (it should be cleaned up on recovery), but this patch adds
defensive code so that if
sijie closed pull request #1681: additional refactoring to use source interface
URL: https://github.com/apache/incubator-pulsar/pull/1681
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 0f2f478 Introduced
srkukarni opened a new pull request #1691: Key the download directory by the
instance id
URL: https://github.com/apache/incubator-pulsar/pull/1691
### Motivation
If a worker is assigned more than one instance of a particular function, the
download paths of the function package
srkukarni commented on issue #1691: Key the download directory by the instance
id
URL: https://github.com/apache/incubator-pulsar/pull/1691#issuecomment-385539924
@sijie @jerrypeng
This is an automated message from the
srkukarni commented on issue #1698: Use Function ClassLoader to load types
URL: https://github.com/apache/incubator-pulsar/pull/1698#issuecomment-385579728
@jerrypeng @sijie
This is an automated message from the Apache Git
srkukarni opened a new pull request #1698: Use Function ClassLoader to load
types
URL: https://github.com/apache/incubator-pulsar/pull/1698
### Motivation
Since user types for function could involve user jar, always use function
class loader to resolve function types.
###
srkukarni closed pull request #1698: Use Function ClassLoader to load types
URL: https://github.com/apache/incubator-pulsar/pull/1698
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
sijie closed pull request #1696: Allow functions to be triggered without
specifying topic name
URL: https://github.com/apache/incubator-pulsar/pull/1696
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new fb7198a Allow functions to be
srkukarni commented on issue #1699: Use Function class loader to resolve
function types
URL: https://github.com/apache/incubator-pulsar/pull/1699#issuecomment-385580219
@jerrypeng @sijie
This is an automated message from
srkukarni opened a new pull request #1699: Use Function class loader to resolve
function types
URL: https://github.com/apache/incubator-pulsar/pull/1699
### Motivation
Since user types for function could involve user jar, always use function
class loader to resolve function types.
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 600b55d Check if javaInstance is
sijie closed pull request #1688: Check if javaInstance is created in the first
place before invocing close
URL: https://github.com/apache/incubator-pulsar/pull/1688
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the
zhaijack commented on a change in pull request #1593: PIP-17: the part of
index block for offload.
URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r185156310
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/s3offload/OffloadIndexTest.java
srkukarni commented on a change in pull request #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700#discussion_r185160956
##
File path: pulsar-functions/proto/src/main/proto/Function.proto
##
@@ -64,6 +65,17 @@ message SourceSpec {
srkukarni commented on a change in pull request #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700#discussion_r185160964
##
File path: pulsar-functions/proto/src/main/proto/Function.proto
##
@@ -43,15 +43,16 @@ message FunctionDetails {
srkukarni opened a new pull request #1688: Check if javaInstance is created in
the first place before invocing close
URL: https://github.com/apache/incubator-pulsar/pull/1688
### Motivation
If there is an issue setting up javaInstance(like if class path is not
found, etc),
sijie commented on issue #1681: additional refactoring to use source interface
URL: https://github.com/apache/incubator-pulsar/pull/1681#issuecomment-385527527
retest this please
This is an automated message from the Apache
lucperkins commented on issue #1670: Check for tenant and namespace for
pulsar-admin functions list command
URL: https://github.com/apache/incubator-pulsar/pull/1670#issuecomment-385517524
retest this please
This is an
sijie closed pull request #1683: Introduced TypedMessageBuilder
URL: https://github.com/apache/incubator-pulsar/pull/1683
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 3c99306 Key the download directory
jerrypeng commented on issue #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700#issuecomment-385584994
@sijie @srkukarni please review
This is an automated message from the Apache Git Service.
jerrypeng opened a new pull request #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
jerrypeng commented on issue #1681: additional refactoring to use source
interface
URL: https://github.com/apache/incubator-pulsar/pull/1681#issuecomment-385514330
@srkukarni thanks for the review. I have addressed your comments
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 3a6e0e2 Fixed NPE and added test for
sijie closed pull request #1685: Fixed NPE and added test for Schema.STRING
URL: https://github.com/apache/incubator-pulsar/pull/1685
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
lucperkins opened a new pull request #1690: Fix Golang setup in Dockerfile
URL: https://github.com/apache/incubator-pulsar/pull/1690
I've verified this new setup:
```bash
$ docker build -t pulsar-build build/docker
$ docker run -it pulsar-build go get -u
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 240f533 Pulsar Functions for Python
sijie closed pull request #1482: Pulsar Functions for Python docs
URL: https://github.com/apache/incubator-pulsar/pull/1482
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
merlimat opened a new pull request #1693: Make SchemaSerializationException an
unchecked exception
URL: https://github.com/apache/incubator-pulsar/pull/1693
### Motivation
Since the exception when serializing is only thrown when there is a severe
misconfiguration in the Schema
merlimat closed pull request #1691: Key the download directory by the instance
id
URL: https://github.com/apache/incubator-pulsar/pull/1691
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
merlimat commented on issue #1352: Delete inactive subscriptions automatically
URL: https://github.com/apache/incubator-pulsar/pull/1352#issuecomment-385560450
Merged with current master and fixed conflicts.
This is an
jerrypeng commented on a change in pull request #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700#discussion_r185164567
##
File path: pulsar-functions/proto/src/main/proto/Function.proto
##
@@ -64,6 +65,17 @@ message SourceSpec {
jerrypeng commented on issue #1700: adding sink spec
URL: https://github.com/apache/incubator-pulsar/pull/1700#issuecomment-385596843
@srkukarni thanks for the review. I have addressed your comments.
This is an automated
merlimat commented on issue #1690: Fix Golang setup in Dockerfile
URL: https://github.com/apache/incubator-pulsar/pull/1690#issuecomment-385552629
retest this please
This is an automated message from the Apache Git Service.
merlimat commented on issue #1690: Fix Golang setup in Dockerfile
URL: https://github.com/apache/incubator-pulsar/pull/1690#issuecomment-385552629
retest this please
This is an automated message from the Apache Git Service.
sijie commented on issue #1657: Document default values for Pulsar Functions
URL: https://github.com/apache/incubator-pulsar/pull/1657#issuecomment-385557002
@srkukarni : I think @lucperkins addressed your comments. can you review it
again?
merlimat closed pull request #1690: Fix Golang setup in Dockerfile
URL: https://github.com/apache/incubator-pulsar/pull/1690
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1e0e12a Remove "global" from
merlimat closed pull request #1695: Remove "global" from returned clusters list
URL: https://github.com/apache/incubator-pulsar/pull/1695
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new f5d9502 Fix Golang setup in
merlimat commented on issue #1650: Documentation of admin REST API is missing
body parameters
URL:
https://github.com/apache/incubator-pulsar/issues/1650#issuecomment-385565942
Moved to 2.1 since it requires a bit of work and investigation with Swagger
to include the JSON format for the
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new cbdce09 Make
sijie closed pull request #1693: Make SchemaSerializationException an unchecked
exception
URL: https://github.com/apache/incubator-pulsar/pull/1693
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
This is an automated email from the ASF dual-hosted git repository.
mmerli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 1eff40e Renamed Schema.IDENTITY into
merlimat closed pull request #1694: Renamed Schema.IDENTITY into Schema.BYTES
URL: https://github.com/apache/incubator-pulsar/pull/1694
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
srkukarni commented on issue #1696: Allow functions to be triggered without
specifying topic name
URL: https://github.com/apache/incubator-pulsar/pull/1696#issuecomment-385563329
@jerrypeng @sijie
This is an automated
srkukarni opened a new pull request #1696: Trigger fix
URL: https://github.com/apache/incubator-pulsar/pull/1696
### Motivation
Added the trigger functionality where one does not need to specify input
topic. This will work for those functions who only take one input Pulsar Topic.
merlimat commented on issue #1656: Add admin api to delete topic forcefully
URL: https://github.com/apache/incubator-pulsar/pull/1656#issuecomment-385559863
retest this please
This is an automated message from the Apache Git
jerrypeng opened a new pull request #1697: adding function worker initialized
check
URL: https://github.com/apache/incubator-pulsar/pull/1697
This is an automated message from the Apache Git Service.
To respond to the
jerrypeng commented on issue #1697: adding function worker initialized check
URL: https://github.com/apache/incubator-pulsar/pull/1697#issuecomment-385569773
@sijie @srkukarni please review
This is an automated message from
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new fd576ae Use Function class loader to
sijie closed pull request #1699: Use Function class loader to resolve function
types
URL: https://github.com/apache/incubator-pulsar/pull/1699
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
srkukarni opened a new pull request #1701: Fix Trigger functionality for non
Java Functions
URL: https://github.com/apache/incubator-pulsar/pull/1701
### Motivation
Non Java functions won't have PulsarSource as their source function. Instead
we need to rely on the inputserdemap.
srkukarni commented on issue #1701: Fix Trigger functionality for non Java
Functions
URL: https://github.com/apache/incubator-pulsar/pull/1701#issuecomment-385603515
@sijie @jerrypeng
This is an automated message from the
sijie opened a new pull request #1682: Fix DefaultSchemasTest
URL: https://github.com/apache/incubator-pulsar/pull/1682
*Motivation*
#1585 introduced default schemas test. it wasn't rebased to latest master.
so the PR was merged without problem but fail the build
*Solution*
sijie commented on issue #1682: Fix DefaultSchemasTest
URL: https://github.com/apache/incubator-pulsar/pull/1682#issuecomment-385320445
@mgodave @srkukarni
This is an automated message from the Apache Git Service.
To respond
zhaijack commented on a change in pull request #1669: PIP-17: provide
DataBlockHeader and implementation
URL: https://github.com/apache/incubator-pulsar/pull/1669#discussion_r185004609
##
File path:
ivankelly commented on a change in pull request #1669: PIP-17: provide
DataBlockHeader and implementation
URL: https://github.com/apache/incubator-pulsar/pull/1669#discussion_r185007245
##
File path:
sijie commented on issue #1681: additional refactoring to use source interface
URL: https://github.com/apache/incubator-pulsar/pull/1681#issuecomment-385434315
@srkukarni please review @jerrypeng 's latest changes
This is an
ivankelly commented on a change in pull request #1593: PIP-17: the part of
index block for offload.
URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r185012846
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/s3offload/OffloadIndexTest.java
ivankelly commented on a change in pull request #1593: PIP-17: the part of
index block for offload.
URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r185011995
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/s3offload/OffloadIndexTest.java
ivankelly commented on a change in pull request #1593: PIP-17: the part of
index block for offload.
URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r185013023
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/s3offload/OffloadIndexBlock.java
ivankelly commented on a change in pull request #1593: PIP-17: the part of
index block for offload.
URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r185011046
##
File path:
ivankelly commented on a change in pull request #1593: PIP-17: the part of
index block for offload.
URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r185012415
##
File path:
pulsar-broker/src/test/java/org/apache/pulsar/s3offload/OffloadIndexTest.java
ivankelly commented on a change in pull request #1593: PIP-17: the part of
index block for offload.
URL: https://github.com/apache/incubator-pulsar/pull/1593#discussion_r185009429
##
File path:
ivankelly closed issue #975: CLI tool for compaction
URL: https://github.com/apache/incubator-pulsar/issues/975
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and
ivankelly closed issue #967: Compaction algorithm implementation
URL: https://github.com/apache/incubator-pulsar/issues/967
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ivankelly closed issue #969: Broker reads from compacted ledger
URL: https://github.com/apache/incubator-pulsar/issues/969
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ivankelly closed issue #970: Testing: Compaction on an encrypted topic
shouldn't break the topic
URL: https://github.com/apache/incubator-pulsar/issues/970
This is an automated message from the Apache Git Service.
To
zhaijack commented on issue #1669: PIP-17: provide DataBlockHeader and
implementation
URL: https://github.com/apache/incubator-pulsar/pull/1669#issuecomment-385423885
Thanks @ivankelly , added it.
This is an automated
zhaijack commented on a change in pull request #1669: PIP-17: provide
DataBlockHeader and implementation
URL: https://github.com/apache/incubator-pulsar/pull/1669#discussion_r185004609
##
File path:
ivankelly closed issue #972: Testing: Batching with encryption and compression
must work with compaction
URL: https://github.com/apache/incubator-pulsar/issues/972
This is an automated message from the Apache Git Service.
ivankelly closed issue #971: Testing: Compaction on a compressed topic
shouldn't break the topic
URL: https://github.com/apache/incubator-pulsar/issues/971
This is an automated message from the Apache Git Service.
To
ivankelly closed issue #966: Coordination for compacted ledger
URL: https://github.com/apache/incubator-pulsar/issues/966
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ivankelly commented on issue #1669: PIP-17: provide DataBlockHeader and
implementation
URL: https://github.com/apache/incubator-pulsar/pull/1669#issuecomment-385420445
@zhaijack lgtm. Will you add the master issue to the PR description, so it
gets linked there.
lucperkins commented on a change in pull request #1677: Add tenant and
namespace getters to Python context
URL: https://github.com/apache/incubator-pulsar/pull/1677#discussion_r185055849
##
File path: pulsar-client-cpp/python/functions/context.py
##
@@ -50,9 +50,18 @@ def
ivankelly commented on issue #1639: Rest API for Ledger Offloading
URL: https://github.com/apache/incubator-pulsar/pull/1639#issuecomment-385476742
retest this please //
PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition
lucperkins opened a new pull request #1684: Update REST API docs
URL: https://github.com/apache/incubator-pulsar/pull/1684
At the moment, updating the REST API docs via Swagger is a manual process.
This PR is the first update in several months (in light of some important
changes).
merlimat opened a new pull request #1685: Fixed NPE and added test for
Schema.STRING
URL: https://github.com/apache/incubator-pulsar/pull/1685
### Motivation
Fixed NullPointerException when using `StringSchema`
### Modifications
* Added `StringSchema` as
merlimat commented on a change in pull request #1553: Pulsar 2.0 docs
URL: https://github.com/apache/incubator-pulsar/pull/1553#discussion_r185071798
##
File path: site/_config.yml
##
@@ -25,9 +25,10 @@ pulsar_repo:
https://github.com/apache/incubator-pulsar/tree/master
sijie closed pull request #1682: Fix DefaultSchemasTest
URL: https://github.com/apache/incubator-pulsar/pull/1682
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new 42c2f37 Fix DefaultSchemasTest
sijie commented on issue #1656: Add admin api to delete topic forcefully
URL: https://github.com/apache/incubator-pulsar/pull/1656#issuecomment-385443933
@merlimat : @rdhabalia has addressed the conflicts. can you review this PR?
srkukarni commented on a change in pull request #1677: Add tenant and namespace
getters to Python context
URL: https://github.com/apache/incubator-pulsar/pull/1677#discussion_r185055226
##
File path: pulsar-client-cpp/python/functions/context.py
##
@@ -50,9 +50,18 @@ def
lucperkins commented on issue #1482: Pulsar Functions for Python docs
URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-385480279
@srkukarni Fixed
This is an automated message from the Apache Git Service.
merlimat opened a new pull request #1683: Introduced TypedMessageBuilder
URL: https://github.com/apache/incubator-pulsar/pull/1683
### Motivation
Simplify message builder interactions when using schema.
The current message builder interface requires to pass the `Schema`
1 - 100 of 151 matches
Mail list logo
