[GitHub] ivankelly commented on a change in pull request #1941: Tiered Storage documentation

2018-06-14 Thread GitBox
ivankelly commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r195400759 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] ivankelly commented on issue #1962: Human readable sizes when triggering offload

2018-06-14 Thread GitBox
ivankelly commented on issue #1962: Human readable sizes when triggering offload URL: https://github.com/apache/incubator-pulsar/pull/1962#issuecomment-397213693 retest this please // ReplicatorTest.testCloseReplicatorStartProducer

[GitHub] ivankelly opened a new pull request #1965: Allow ML offload immediately after ledger closed

2018-06-14 Thread GitBox
ivankelly opened a new pull request #1965: Allow ML offload immediately after ledger closed URL: https://github.com/apache/incubator-pulsar/pull/1965 The documentation said that only negative values disabled. If a user wants data to be offloaded as soon as possible, the obvious thing is

[GitHub] ivankelly commented on a change in pull request #1941: Tiered Storage documentation

2018-06-14 Thread GitBox
ivankelly commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r195401324 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] ivankelly opened a new pull request #1966: Typo compaction threshold rest api

2018-06-14 Thread GitBox
ivankelly opened a new pull request #1966: Typo compaction threshold rest api URL: https://github.com/apache/incubator-pulsar/pull/1966 Bad copy/paste. This is an automated message from the Apache Git Service. To respond

[GitHub] ivankelly opened a new pull request #1969: Issue #1722: Fix copy-paste error in ConsumerBuilder javadoc

2018-06-14 Thread GitBox
ivankelly opened a new pull request #1969: Issue #1722: Fix copy-paste error in ConsumerBuilder javadoc URL: https://github.com/apache/incubator-pulsar/pull/1969 This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-14 Thread GitBox
sijie commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r195499055 ## File path: conf/schema_example.conf ## @@ -0,0 +1,7 @@ +{ Review comment: @merlimat - I am

[GitHub] sijie commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-14 Thread GitBox
sijie commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r195512274 ## File path: pom.xml ## @@ -925,6 +925,7 @@ flexible messaging model and an intuitive client API.

[incubator-pulsar] branch master updated: Allow ML offload immediately after ledger closed (#1965)

2018-06-14 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 77502c8 Allow ML offload immediately

[GitHub] sijie closed pull request #1965: Allow ML offload immediately after ledger closed

2018-06-14 Thread GitBox
sijie closed pull request #1965: Allow ML offload immediately after ledger closed URL: https://github.com/apache/incubator-pulsar/pull/1965 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] gfouquier opened a new issue #1967: non-persistent topic drop too much message

2018-06-14 Thread GitBox
gfouquier opened a new issue #1967: non-persistent topic drop too much message URL: https://github.com/apache/incubator-pulsar/issues/1967 Expected behavior Messages sent to a non-persistent topic and acknowledge must be delivered, at least if the consumer is sufficient to

[GitHub] sijie closed pull request #1845: Functions schema integration

2018-06-14 Thread GitBox
sijie closed pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on issue #1845: Functions schema integration

2018-06-14 Thread GitBox
sijie commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-397355405 (not sure why github checks hanging. trying close and reopen pull request to trigger CI again)

[GitHub] mgodave opened a new pull request #1845: Functions schema integration

2018-06-14 Thread GitBox
mgodave opened a new pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845 Unify SerDe and Schema. Allow SerDe/Schema to be used when creating PulsarSink and PulsarSource.

[GitHub] sijie commented on issue #1845: Functions schema integration

2018-06-14 Thread GitBox
sijie commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-397355122 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat closed pull request #1966: Typo compaction threshold rest api

2018-06-14 Thread GitBox
merlimat closed pull request #1966: Typo compaction threshold rest api URL: https://github.com/apache/incubator-pulsar/pull/1966 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Typo compaction threshold rest api (#1966)

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 468242e Typo compaction threshold

[GitHub] merlimat commented on a change in pull request #1963: Added RPM packaging for C++ pulsar client lib

2018-06-14 Thread GitBox
merlimat commented on a change in pull request #1963: Added RPM packaging for C++ pulsar client lib URL: https://github.com/apache/incubator-pulsar/pull/1963#discussion_r195485135 ## File path: pulsar-client-cpp/pkg/rpm/SPECS/pulsar-client.spec ## @@ -0,0 +1,61 @@ +# +#

[GitHub] merlimat commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-14 Thread GitBox
merlimat commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r195494177 ## File path: conf/schema_example.conf ## @@ -0,0 +1,7 @@ +{ Review comment: If this file is

[GitHub] ivankelly opened a new pull request #1968: Capture zookeeper journal when integration tests end

2018-06-14 Thread GitBox
ivankelly opened a new pull request #1968: Capture zookeeper journal when integration tests end URL: https://github.com/apache/incubator-pulsar/pull/1968 Some issues with integration are hard to debug from the logs alone. For example, #1916 looks like bookies are registering with

[incubator-pulsar] branch master updated: Human readable sizes when triggering offload (#1962)

2018-06-14 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e104085 Human readable sizes when

[GitHub] sijie closed pull request #1962: Human readable sizes when triggering offload

2018-06-14 Thread GitBox
sijie closed pull request #1962: Human readable sizes when triggering offload URL: https://github.com/apache/incubator-pulsar/pull/1962 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch asf-site updated: Updated site at revision 0a655c1

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new dde8507 Updated site at revision

[GitHub] sijie commented on issue #1944: Add CLI commands for schema registry

2018-06-14 Thread GitBox
sijie commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-397354908 @merlimat please review the latest change. This is an automated message

[GitHub] srkukarni commented on issue #1845: Functions schema integration

2018-06-14 Thread GitBox
srkukarni commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-397406187 retest this please This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #1922: Enable bookkeeper table service in pulsar standalone

2018-06-14 Thread GitBox
sijie commented on issue #1922: Enable bookkeeper table service in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1922#issuecomment-397420497 4.7.1 rc0 is pushed to apache staging. so this PR is compilable now. I will address the remaining comments today,

[GitHub] merlimat commented on issue #1964: pulsar-client-cpp not able to build with static link

2018-06-14 Thread GitBox
merlimat commented on issue #1964: pulsar-client-cpp not able to build with static link URL: https://github.com/apache/incubator-pulsar/issues/1964#issuecomment-397426362 @vli02 The Gmock and Gtest are not included in the Docker image. For the RPM I was building with the `cmake .

[GitHub] merlimat closed pull request #1969: Issue #1722: Fix copy-paste error in ConsumerBuilder javadoc

2018-06-14 Thread GitBox
merlimat closed pull request #1969: Issue #1722: Fix copy-paste error in ConsumerBuilder javadoc URL: https://github.com/apache/incubator-pulsar/pull/1969 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Issue #1722: Fix copy-paste error in ConsumerBuilder javadoc (#1969)

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 31ab19f Issue #1722: Fix copy-paste

[incubator-pulsar.wiki] branch master updated: Added instructions with stage-release.sh script

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 57c7cbc Added instructions with

[GitHub] srkukarni commented on a change in pull request #1845: Functions schema integration

2018-06-14 Thread GitBox
srkukarni commented on a change in pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r195536726 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java

[GitHub] vli02 commented on issue #1964: pulsar-client-cpp not able to build with static link

2018-06-14 Thread GitBox
vli02 commented on issue #1964: pulsar-client-cpp not able to build with static link URL: https://github.com/apache/incubator-pulsar/issues/1964#issuecomment-397414253 Hi @merlimat I just had a quick try with `apachepulsar/pulsar-build:centos-7`, build failed early in cmake: ```

[incubator-pulsar] branch master updated: Capture zookeeper journal when integration tests end (#1968)

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 44349cc Capture zookeeper journal

[GitHub] merlimat closed pull request #1968: Capture zookeeper journal when integration tests end

2018-06-14 Thread GitBox
merlimat closed pull request #1968: Capture zookeeper journal when integration tests end URL: https://github.com/apache/incubator-pulsar/pull/1968 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] srkukarni commented on a change in pull request #1845: Functions schema integration

2018-06-14 Thread GitBox
srkukarni commented on a change in pull request #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#discussion_r195536726 ## File path: pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstance.java

[GitHub] sijie commented on issue #1922: Enable bookkeeper table service in pulsar standalone

2018-06-14 Thread GitBox
sijie commented on issue #1922: Enable bookkeeper table service in pulsar standalone URL: https://github.com/apache/incubator-pulsar/pull/1922#issuecomment-397421687 > so this PR is compilable now. take my words back. I think we need to wait until 4.7.1 becomes available at maven

[GitHub] merlimat opened a new pull request #1970: Added DEB packaging for C++ pulsar client lib

2018-06-14 Thread GitBox
merlimat opened a new pull request #1970: Added DEB packaging for C++ pulsar client lib URL: https://github.com/apache/incubator-pulsar/pull/1970 ### Motivation Added scripts and tools to build debian packages for C++ pulsar client lib.

[incubator-pulsar.wiki] branch master updated: Updated Release process (markdown)

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 3e65237 Updated Release process

[GitHub] merlimat opened a new pull request #1971: Fixed License header for ByteBufCoded{Input, Output}Stream.java

2018-06-14 Thread GitBox
merlimat opened a new pull request #1971: Fixed License header for ByteBufCoded{Input,Output}Stream.java URL: https://github.com/apache/incubator-pulsar/pull/1971 ### Motivation The files `ByteBufCoded{Input,Output}Stream.java` are derived from Protobuf code. As explained in

[GitHub] merlimat commented on issue #1964: pulsar-client-cpp not able to build with static link

2018-06-14 Thread GitBox
merlimat commented on issue #1964: pulsar-client-cpp not able to build with static link URL: https://github.com/apache/incubator-pulsar/issues/1964#issuecomment-397504947 @vli02 the fix to compile in the centos docker image was merged earlier today

[GitHub] merlimat closed pull request #1971: Fixed License header for ByteBufCoded{Input, Output}Stream.java

2018-06-14 Thread GitBox
merlimat closed pull request #1971: Fixed License header for ByteBufCoded{Input,Output}Stream.java URL: https://github.com/apache/incubator-pulsar/pull/1971 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Fixed License header for ByteBufCoded{Input, Output}Stream.java (#1971)

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0b26ce7 Fixed License header for

[GitHub] rdhabalia opened a new pull request #1972: Add documentation and flexible aws-credential plugin to support aws-role

2018-06-14 Thread GitBox
rdhabalia opened a new pull request #1972: Add documentation and flexible aws-credential plugin to support aws-role URL: https://github.com/apache/incubator-pulsar/pull/1972 ### Motivation Right now, KinesisSink's credentialProvider-plugin doesn't support session-token which can be

[GitHub] sijie commented on issue #1944: Add CLI commands for schema registry

2018-06-14 Thread GitBox
sijie commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-397190826 all CI jobs passed. This is an automated message from the Apache Git

[GitHub] vli02 opened a new issue #1964: pulsar-client-cpp not able to build with static link

2018-06-14 Thread GitBox
vli02 opened a new issue #1964: pulsar-client-cpp not able to build with static link URL: https://github.com/apache/incubator-pulsar/issues/1964 Expected behavior Build pulsar-client-cpp lib with static linking all libs. Set LINK_STATIC to ON in CMakeList.txt and run

[GitHub] merlimat closed pull request #1963: Added RPM packaging for C++ pulsar client lib

2018-06-14 Thread GitBox
merlimat closed pull request #1963: Added RPM packaging for C++ pulsar client lib URL: https://github.com/apache/incubator-pulsar/pull/1963 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Added RPM packaging for C++ pulsar client lib (#1963)

2018-06-14 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7dac7ba Added RPM packaging for C++