[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202785971 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202786021 ## File path:

[GitHub] merlimat opened a new pull request #2173: Removed GPL deps on gnu crypto from aerospike connector

merlimat opened a new pull request #2173: Removed GPL deps on gnu crypto from aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2173 ### Motivation There's an optional dependency on gnu-crypto for aerospike connector. We need to remove it to avoid license

[GitHub] aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-405358779 Conflicts should be fixed now This is an automated

[GitHub] srkukarni commented on a change in pull request #2105: Attach function metadata properties to pulsar source/sink

srkukarni commented on a change in pull request #2105: Attach function metadata properties to pulsar source/sink URL: https://github.com/apache/incubator-pulsar/pull/2105#discussion_r202754104 ## File path:

[incubator-pulsar] branch master updated: fixing protobuf schema shading issue (#2168)

This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 7af6374 fixing protobuf schema

[GitHub] srkukarni commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone

srkukarni commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone URL: https://github.com/apache/incubator-pulsar/issues/2166#issuecomment-405312563 I built master and did not encounter any such issue. What's your os/java version?

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202786268 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202786737 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202797674 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202799087 ## File path:

[GitHub] aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202798871 ## File path:

[GitHub] jerrypeng closed pull request #2168: fixing protobuf schema shading issue

jerrypeng closed pull request #2168: fixing protobuf schema shading issue URL: https://github.com/apache/incubator-pulsar/pull/2168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ivankelly commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007)

ivankelly commented on a change in pull request #2135: Allow user to get topic from consumer message (#2007) URL: https://github.com/apache/incubator-pulsar/pull/2135#discussion_r202763305 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/naming/TopicName.java

[GitHub] grantwwu opened a new pull request #2174: V2 doc changes

grantwwu opened a new pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174 Apparently we've forgotten to add some v2s to the URLs. NOTE: I think there will be more changes needed. Also - should we note the availability of v1 of the API

[GitHub] sijie commented on issue #2170: Add integration test for kafka sink

sijie commented on issue #2170: Add integration test for kafka sink URL: https://github.com/apache/incubator-pulsar/pull/2170#issuecomment-405344833 retest this please This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #2172: If auth is badly configured in c++, close the connection

sijie commented on issue #2172: If auth is badly configured in c++, close the connection URL: https://github.com/apache/incubator-pulsar/pull/2172#issuecomment-405345234 retest this please This is an automated message from

[GitHub] rdhabalia removed a comment on issue #2169: Add kinesis-sink user metrics to sinkContext

rdhabalia removed a comment on issue #2169: Add kinesis-sink user metrics to sinkContext URL: https://github.com/apache/incubator-pulsar/pull/2169#issuecomment-405352052 retest this please This is an automated message from

[GitHub] rdhabalia commented on issue #2169: Add kinesis-sink user metrics to sinkContext

rdhabalia commented on issue #2169: Add kinesis-sink user metrics to sinkContext URL: https://github.com/apache/incubator-pulsar/pull/2169#issuecomment-405352052 retest this please This is an automated message from the Apache

[GitHub] aahmed-se commented on issue #2036: Add testcontainer based standalone test

aahmed-se commented on issue #2036: Add testcontainer based standalone test URL: https://github.com/apache/incubator-pulsar/pull/2036#issuecomment-405365008 This is out of context now will close it for now. This is an

[incubator-pulsar] branch master updated: Add kinesis-sink user metrics to sinkContext (#2169)

This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new ba1ea66 Add kinesis-sink user

[GitHub] grantwwu commented on issue #2174: V2 doc changes

grantwwu commented on issue #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#issuecomment-405395717 @merlimat Are all these problems with the cluster in them due to

[GitHub] grantwwu commented on issue #2174: V2 doc changes

grantwwu commented on issue #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#issuecomment-405400116 @merlimat Just making sure that I was understanding how this happened correctly. Now that I know it was that proposal, I can do another pass through the docs

[GitHub] merlimat commented on issue #2174: V2 doc changes

merlimat commented on issue #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#issuecomment-405396654 @grantwwu Mostly, to implement that proposal, we had to differentiate the API in `/admin/..` and `/admin/v2/..` to avoid naming conflicts.

[GitHub] merlimat edited a comment on issue #2174: V2 doc changes

merlimat edited a comment on issue #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#issuecomment-405396654 @grantwwu Mostly, to implement that proposal, we had to differentiate the API in `/admin/..` and `/admin/v2/..` to avoid naming conflicts. We tried to

[incubator-pulsar] branch master updated: Add function metrics with function-stats to get metrics on-demand (#2130)

This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5f779b4 Add function metrics with

[GitHub] rdhabalia closed pull request #2169: Add kinesis-sink user metrics to sinkContext

rdhabalia closed pull request #2169: Add kinesis-sink user metrics to sinkContext URL: https://github.com/apache/incubator-pulsar/pull/2169 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] grantwwu commented on issue #2174: V2 doc changes

grantwwu commented on issue #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#issuecomment-405382916 @merlimat @sijie Sorry I just added on a bunch more and squashed into a single commit. Should we mention anywhere that there's still a v1 API? Perhaps

[GitHub] merlimat commented on a change in pull request #2174: V2 doc changes

merlimat commented on a change in pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#discussion_r202833495 ## File path: site/docs/latest/admin-api/namespaces.md ## @@ -344,7 +344,7 @@ N/A ## REST ``` -POST

[GitHub] merlimat commented on a change in pull request #2174: V2 doc changes

merlimat commented on a change in pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#discussion_r202832925 ## File path: site/docs/latest/admin-api/namespaces.md ## @@ -47,7 +47,7 @@ $ pulsar-admin namespaces create

[GitHub] merlimat commented on a change in pull request #2174: V2 doc changes

merlimat commented on a change in pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#discussion_r202833084 ## File path: site/docs/latest/admin-api/namespaces.md ## @@ -144,7 +144,7 @@ test-tenant/ns2 REST API -{%

[GitHub] merlimat commented on issue #2173: Removed GPL deps on gnu crypto from aerospike connector

merlimat commented on issue #2173: Removed GPL deps on gnu crypto from aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2173#issuecomment-405399213 retest this please This is an automated message from

[GitHub] merlimat commented on issue #2174: V2 doc changes

merlimat commented on issue #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#issuecomment-405412792 > @merlimat Just making sure that I was understanding how this happened correctly. Now that I know it was that proposal, I can do another pass through the

[GitHub] sijie closed issue #2142: Can't find code source in package org.apache.bookkeeper.mledger.proto

sijie closed issue #2142: Can't find code source in package org.apache.bookkeeper.mledger.proto URL: https://github.com/apache/incubator-pulsar/issues/2142 This is an automated message from the Apache Git Service. To

[GitHub] sijie opened a new pull request #2176: Issue 2119: TopicPatternSubscription doesn't work through proxy

sijie opened a new pull request #2176: Issue 2119: TopicPatternSubscription doesn't work through proxy URL: https://github.com/apache/incubator-pulsar/pull/2176 ### Motivation Fixes #2119 TopicPatternSubscription is not supported on proxy. ### Modifications -

[GitHub] aahmed-se closed pull request #2036: Add testcontainer based standalone test

aahmed-se closed pull request #2036: Add testcontainer based standalone test URL: https://github.com/apache/incubator-pulsar/pull/2036 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers

sijie commented on a change in pull request #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#discussion_r202815746 ## File path:

[GitHub] sijie commented on issue #2101: Migrate compaction and s3 offload test to testcontainers

sijie commented on issue #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-405374084 @ivankelly can you review this again? This is an

[GitHub] merlimat commented on a change in pull request #2174: V2 doc changes

merlimat commented on a change in pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#discussion_r202833182 ## File path: site/docs/latest/admin-api/namespaces.md ## @@ -92,7 +92,7 @@ $ pulsar-admin namespaces policies

[GitHub] merlimat commented on a change in pull request #2174: V2 doc changes

merlimat commented on a change in pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#discussion_r202833153 ## File path: site/docs/latest/admin-api/namespaces.md ## @@ -168,7 +168,7 @@ $ pulsar-admin namespaces delete

[GitHub] ivankelly opened a new pull request #2175: [WIP] figuring out what's happening to the sha in CI

ivankelly opened a new pull request #2175: [WIP] figuring out what's happening to the sha in CI URL: https://github.com/apache/incubator-pulsar/pull/2175 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve.

[GitHub] merlimat commented on a change in pull request #2174: V2 doc changes

merlimat commented on a change in pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#discussion_r202831818 ## File path: site/docs/latest/cookbooks/RetentionExpiry.md ## @@ -97,7 +97,7 @@ $ pulsar-admin namespaces set-retention

[GitHub] merlimat commented on a change in pull request #2174: V2 doc changes

merlimat commented on a change in pull request #2174: V2 doc changes URL: https://github.com/apache/incubator-pulsar/pull/2174#discussion_r202831664 ## File path: site/docs/latest/cookbooks/RetentionExpiry.md ## @@ -97,7 +97,7 @@ $ pulsar-admin namespaces set-retention

[GitHub] aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers

aahmed-se commented on issue #2101: Migrate compaction and s3 offload test to testcontainers URL: https://github.com/apache/incubator-pulsar/pull/2101#issuecomment-405406467 retest this please This is an automated message

[GitHub] merlimat commented on issue #2172: If auth is badly configured in c++, close the connection

merlimat commented on issue #2172: If auth is badly configured in c++, close the connection URL: https://github.com/apache/incubator-pulsar/pull/2172#issuecomment-405414020 retest this please This is an automated message

[GitHub] sijie opened a new pull request #2170: Add integration test for kafka sink

sijie opened a new pull request #2170: Add integration test for kafka sink URL: https://github.com/apache/incubator-pulsar/pull/2170 *Motivation* #2167 introduces a sink test for cassandra. this PR adds a test for kafka sink. *Changes* - Add a KafkaSinkTester so

[GitHub] sijie opened a new pull request #2171: Add integration test for kafka source

sijie opened a new pull request #2171: Add integration test for kafka source URL: https://github.com/apache/incubator-pulsar/pull/2171 *Motivation* We added integration tests for kafka & cassandra sinks. We need test coverage on kafka sources. *Changes* - Add

[GitHub] sijie commented on issue #2171: Add integration test for kafka source

sijie commented on issue #2171: Add integration test for kafka source URL: https://github.com/apache/incubator-pulsar/pull/2171#issuecomment-405167056 This change is based on #2170 . The git commit 52f8c74 is the one to review for this PR.

[incubator-pulsar] branch asf-site updated: Updated site at revision 555dd57

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new a2df34d Updated site at revision

[incubator-pulsar] branch master updated: If auth is badly configured in c++, close the connection (#2172)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new da5b3cd If auth is badly configured

[GitHub] merlimat closed pull request #2172: If auth is badly configured in c++, close the connection

merlimat closed pull request #2172: If auth is badly configured in c++, close the connection URL: https://github.com/apache/incubator-pulsar/pull/2172 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie closed issue #2037: Initialization of cluster meta data fails while setting up a multi cluster pulsar instance

sijie closed issue #2037: Initialization of cluster meta data fails while setting up a multi cluster pulsar instance URL: https://github.com/apache/incubator-pulsar/issues/2037 This is an automated message from the Apache

[GitHub] sijie commented on issue #2037: Initialization of cluster meta data fails while setting up a multi cluster pulsar instance

sijie commented on issue #2037: Initialization of cluster meta data fails while setting up a multi cluster pulsar instance URL: https://github.com/apache/incubator-pulsar/issues/2037#issuecomment-405422587 It seems no updates here. I will close this for now. If there are more

[GitHub] merlimat closed pull request #2176: Issue 2119: TopicPatternSubscription doesn't work through proxy

merlimat closed pull request #2176: Issue 2119: TopicPatternSubscription doesn't work through proxy URL: https://github.com/apache/incubator-pulsar/pull/2176 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat commented on issue #2173: Removed GPL deps on gnu crypto from aerospike connector

merlimat commented on issue #2173: Removed GPL deps on gnu crypto from aerospike connector URL: https://github.com/apache/incubator-pulsar/pull/2173#issuecomment-405458792 retest this please This is an automated message from

[incubator-pulsar] branch master updated: Issue 2119: TopicPatternSubscription doesn't work through proxy (#2176)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5b72eec Issue 2119:

[GitHub] merlimat closed issue #2119: TopicPatternSubscription doesn't work through proxy

merlimat closed issue #2119: TopicPatternSubscription doesn't work through proxy URL: https://github.com/apache/incubator-pulsar/issues/2119 This is an automated message from the Apache Git Service. To respond to the

[GitHub] ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api

ivankelly commented on a change in pull request #2065: GCS offload support(2): replace `s3client` api with `jclouds` related api URL: https://github.com/apache/incubator-pulsar/pull/2065#discussion_r202795291 ## File path:

[GitHub] ivankelly opened a new pull request #2172: If auth is badly configured in c++, close the connection

ivankelly opened a new pull request #2172: If auth is badly configured in c++, close the connection URL: https://github.com/apache/incubator-pulsar/pull/2172 This patch fixes a segfault where, if auth was badly configured, resulting in a null authentication pointer, the client would

[GitHub] sijie commented on issue #2013: Unable to consume messages from a partition

sijie commented on issue #2013: Unable to consume messages from a partition URL: https://github.com/apache/incubator-pulsar/issues/2013#issuecomment-405422840 @bardock it seems difficult to debug this issue without any logs. it is a bit hard to reproduce the behavior.

[GitHub] djKooks commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone

djKooks commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone URL: https://github.com/apache/incubator-pulsar/issues/2166#issuecomment-405424753 @srkukarni It is MacOS(with Java8). Is MacOS not supported?

[GitHub] merlimat commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone

merlimat commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone URL: https://github.com/apache/incubator-pulsar/issues/2166#issuecomment-405428431 @djKooks one other thing that might help is to do `mvn clean` and try again. I've seen sometimes a double `mvn

[GitHub] djKooks commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone

djKooks commented on issue #2166: 'java.lang.NoSuchMethodError' when running standalone URL: https://github.com/apache/incubator-pulsar/issues/2166#issuecomment-405429524 @srkukarni @merlimat thanks! I'll try it and let you know.