[GitHub] merlimat commented on issue #841: Change timezone of request log from GMT to local one

2017-10-23 Thread GitBox
merlimat commented on issue #841: Change timezone of request log from GMT to local one URL: https://github.com/apache/incubator-pulsar/pull/841#issuecomment-338875818 @massakam Is the other log4j configuration already using local timezone as well?

[GitHub] merlimat commented on issue #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper

2017-10-23 Thread GitBox
merlimat commented on issue #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper URL: https://github.com/apache/incubator-pulsar/pull/849#issuecomment-338875446 Rebased on master after merging #848

[GitHub] merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire

2017-10-23 Thread GitBox
merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire URL: https://github.com/apache/incubator-pulsar/pull/850#issuecomment-338873124 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire

2017-10-23 Thread GitBox
merlimat commented on issue #850: Use "trimStackTrace" option in Maven surefire URL: https://github.com/apache/incubator-pulsar/pull/850#issuecomment-338873124 retest this please This is an automated message from the Apache

[GitHub] merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146429033 ## File path:

[GitHub] merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
merlimat commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146429093 ## File path:

[GitHub] merlimat opened a new pull request #850: Use "trimStackTrace" option in Maven surefire

2017-10-23 Thread GitBox
merlimat opened a new pull request #850: Use "trimStackTrace" option in Maven surefire URL: https://github.com/apache/incubator-pulsar/pull/850 ### Motivation This option will print the full stack trace of exception thrown within the test execution. In many cases, this should help

[GitHub] rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146426737 ## File path:

[GitHub] rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146428378 ## File path:

[GitHub] rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #848: Allow consumer to seek to message id from within Pulsar client URL: https://github.com/apache/incubator-pulsar/pull/848#discussion_r146428274 ## File path:

[GitHub] merlimat opened a new pull request #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper

2017-10-23 Thread GitBox
merlimat opened a new pull request #849: Implement seekToBeginning()/end operations in Kafka consumer wrapper URL: https://github.com/apache/incubator-pulsar/pull/849 ### Motivation The Kafka `ConsumerPerformance` benchmark tool makes use of the `seekToBeginning()`, `seekToEnd()`

[GitHub] merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#issuecomment-338801668 > So, mvn install creates two separate jars in target pulsar-client-original(unshaded) and

[GitHub] merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
merlimat commented on issue #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#issuecomment-338775878 > I just tried this commit it creates pulsar-client.jar(shaded jar) and pulsar-client-original.jar (actual jar

[GitHub] rdhabalia commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
rdhabalia commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#discussion_r146361946 ## File path: pulsar-client-shaded/pom.xml ## @@ -0,0 +1,140 @@ +

[GitHub] merlimat commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
merlimat commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#discussion_r146333646 ## File path:

[GitHub] merlimat commented on issue #847: Enable json format to be used as an authentication params string

2017-10-23 Thread GitBox
merlimat commented on issue #847: Enable json format to be used as an authentication params string URL: https://github.com/apache/incubator-pulsar/pull/847#issuecomment-338730045 There is a test failure possibly related to the change: ``` [0;32m[ RUN ]

[GitHub] saandrews commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency

2017-10-23 Thread GitBox
saandrews commented on a change in pull request #846: Publish the shaded pulsar-client as the default dependency URL: https://github.com/apache/incubator-pulsar/pull/846#discussion_r146331029 ## File path: