[GitHub] zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic
zhaijack commented on issue #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#issuecomment-358215961 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #1072: Support pluggable authorization mechansim
sijie opened a new issue #1072: Support pluggable authorization mechansim URL: https://github.com/apache/incubator-pulsar/issues/1072 Currently pulsar only supports pluggable authentication mechanisms. It doesn't support pluggable authorization provides. It would be good to make this also pluggable, so users can easily integrate with their own authorization infrastructures. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #1071: Rate limiting and throttling should be applied at subscription level
sijie opened a new issue #1071: Rate limiting and throttling should be applied at subscription level URL: https://github.com/apache/incubator-pulsar/issues/1071 Currently rate limiting and throttling are applied at namespace/topic level. It would be good to provide a mechanism to apply these settings in subscription level, so user can control different rate limiting, throttling strategies for different subscriptions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)
zhaijack commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-358167840 rebased master to fix conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #1069: Provide a setting in consumer configuration to specify where to start consuming messages
sijie opened a new issue #1069: Provide a setting in consumer configuration to specify where to start consuming messages URL: https://github.com/apache/incubator-pulsar/issues/1069 Consumer provides a `seek` api for applications to seek to `earliest` or `latest` to consume messages. It would be good to add a setting in consumer configuration to simply application logic. It is useful for application development and any other similar required use cases. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sijie opened a new issue #1068: Improve `pulsar-broker-shaded` to shade non-pulsar dependencies
sijie opened a new issue #1068: Improve `pulsar-broker-shaded` to shade non-pulsar dependencies URL: https://github.com/apache/incubator-pulsar/issues/1068 currently `pulsar-client-shaded` provides a better shading story, however `pulsar-broker-shaded` doesn't shade all the external dependencies. It would be good to also shade all non-pulsar dependencies in broker. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zhaijack commented on issue #1065: Issue 1060: changes make MessageId Comparable
zhaijack commented on issue #1065: Issue 1060: changes make MessageId Comparable URL: https://github.com/apache/incubator-pulsar/pull/1065#issuecomment-358162114 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins commented on issue #1041: Templatize resources page
lucperkins commented on issue #1041: Templatize resources page URL: https://github.com/apache/incubator-pulsar/pull/1041#issuecomment-358130451 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358096761 > Can you check a different PR that is already approved and with tests passing to see if you have the green merge button? Eg: #1038 No merge button, only comment > Yes, at least it should fix the failing tests. Done This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
merlimat commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358094344 > Shall i leave netty upgrade to another PR? Yes, at least it should fix the failing tests. >We probably need to update yahoo/bookkeeer to 4.1.19 as well. That it's not strictly necessary, since we manage the netty version in our pom and only our version gets included in the distribution. > I thought I had merge permissions as well @merlimat but it seems I don't Can you check a different PR that is already approved and with tests passing to see if you have the green merge button? Eg: https://github.com/apache/incubator-pulsar/pull/1038 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12
sschepens commented on issue #1056: DoubleByteBuf fix for Netty > 4.1.12 URL: https://github.com/apache/incubator-pulsar/pull/1056#issuecomment-358091287 > There are some tests failing (otherwise you should be able to merge). I think they're not related to the DoubleByteBuf change, though they might be releated to the netty upgrade to 4.1.19 Shall i leave netty upgrade to another PR? We probably need to update yahoo/bookkeeer to 4.1.19 as well. I thought I had merge permissions as well @merlimat but it seems I don't This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lucperkins commented on issue #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine
lucperkins commented on issue #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine URL: https://github.com/apache/incubator-pulsar/pull/1047#issuecomment-358088243 @merlimat This is now ready for review This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services