[GitHub] rdhabalia commented on a change in pull request #1209: Fixed missing '"' sign in system metrics for Prometheus

2018-02-08 Thread GitBox
rdhabalia commented on a change in pull request #1209: Fixed missing '"' sign in system metrics for Prometheus URL: https://github.com/apache/incubator-pulsar/pull/1209#discussion_r167157129 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/Prometh

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-08 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167156439 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/Re

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-08 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167153269 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/

[GitHub] merlimat commented on a change in pull request #1208: Add hostname-verification at client tls connection

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1208: Add hostname-verification at client tls connection URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167151485 ## File path: pulsar-broker/src/test/resources/authentication/tls/hn-verification/broker-cert.pem

[GitHub] merlimat commented on a change in pull request #1208: Add hostname-verification at client tls connection

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1208: Add hostname-verification at client tls connection URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167151686 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/ClientConfiguration.java

[GitHub] merlimat commented on a change in pull request #1208: Add hostname-verification at client tls connection

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1208: Add hostname-verification at client tls connection URL: https://github.com/apache/incubator-pulsar/pull/1208#discussion_r167151990 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/ssl/DefaultHostnameVerifi

[GitHub] merlimat opened a new pull request #1209: Fixed missing '"' sign in system metrics for Prometheus

2018-02-08 Thread GitBox
merlimat opened a new pull request #1209: Fixed missing '"' sign in system metrics for Prometheus URL: https://github.com/apache/incubator-pulsar/pull/1209 ### Motivation There was a bug in #1185 that was removing the final '"' for metrics reported to Prometheus make the parser to r

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-08 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167148272 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/T

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-08 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167148083 ## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/C

[GitHub] merlimat commented on issue #1201: Buffer truncated in producer when sending

2018-02-08 Thread GitBox
merlimat commented on issue #1201: Buffer truncated in producer when sending URL: https://github.com/apache/incubator-pulsar/issues/1201#issuecomment-364345903 Fixed in #1203 This is an automated message from the Apache Git

[GitHub] merlimat closed issue #1201: Buffer truncated in producer when sending

2018-02-08 Thread GitBox
merlimat closed issue #1201: Buffer truncated in producer when sending URL: https://github.com/apache/incubator-pulsar/issues/1201 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic

2018-02-08 Thread GitBox
zhaijack commented on a change in pull request #1066: Issue 937: add CommandGetLastMessageId to make reader know the end of topic URL: https://github.com/apache/incubator-pulsar/pull/1066#discussion_r167148039 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @

[GitHub] rdhabalia commented on issue #1208: Add hostname-verification at client tls connection

2018-02-08 Thread GitBox
rdhabalia commented on issue #1208: Add hostname-verification at client tls connection URL: https://github.com/apache/incubator-pulsar/pull/1208#issuecomment-364343714 retest this please This is an automated message from the

[GitHub] rdhabalia commented on issue #1208: Add hostname-verification at client tls connection

2018-02-08 Thread GitBox
rdhabalia commented on issue #1208: Add hostname-verification at client tls connection URL: https://github.com/apache/incubator-pulsar/pull/1208#issuecomment-364343714 retest this please This is an automated message from the

[GitHub] rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-08 Thread GitBox
rdhabalia commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r167132526 ## File path: conf/proxy.conf ## @@ -49,6 +49,9 @@ authenticationProviders= # Enforce authorization

[GitHub] rdhabalia opened a new pull request #1208: Add host-verification at client tls connection

2018-02-08 Thread GitBox
rdhabalia opened a new pull request #1208: Add host-verification at client tls connection URL: https://github.com/apache/incubator-pulsar/pull/1208 ### Motivation Right now, Pulsar client is not able to perform [hostname-verification](https://tersesystems.com/blog/2014/03/23/fixing-

[GitHub] merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1200: Add pluggable authorization mechanism URL: https://github.com/apache/incubator-pulsar/pull/1200#discussion_r167124157 ## File path: conf/proxy.conf ## @@ -49,6 +49,9 @@ authenticationProviders= # Enforce authorization

[GitHub] merlimat commented on issue #1051: [WIP] PIP-10: Remove cluster for namespace and topic names

2018-02-08 Thread GitBox
merlimat commented on issue #1051: [WIP] PIP-10: Remove cluster for namespace and topic names URL: https://github.com/apache/incubator-pulsar/pull/1051#issuecomment-364313203 closing this in favor of #1150 from @cckellogg Thi

[GitHub] merlimat commented on a change in pull request #1205: Algorithm to find start point of compacted ledger

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1205: Algorithm to find start point of compacted ledger URL: https://github.com/apache/incubator-pulsar/pull/1205#discussion_r167123661 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/CompactedTopicImpl.java ##

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167122023 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167122279 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167121515 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167121188 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167119380 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167121243 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167121654 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

2018-02-08 Thread GitBox
merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167121933 ## File path: pulsar-client/src/main/java/org/apache/pulsar

[GitHub] merlimat commented on issue #1207: Allow to configure most client/producer/consumer options in Kafka API wrapper

2018-02-08 Thread GitBox
merlimat commented on issue #1207: Allow to configure most client/producer/consumer options in Kafka API wrapper URL: https://github.com/apache/incubator-pulsar/pull/1207#issuecomment-364306005 retest this please This is an a

[GitHub] merlimat commented on issue #1207: Allow to configure most client/producer/consumer options in Kafka API wrapper

2018-02-08 Thread GitBox
merlimat commented on issue #1207: Allow to configure most client/producer/consumer options in Kafka API wrapper URL: https://github.com/apache/incubator-pulsar/pull/1207#issuecomment-364306005 retest this please This is an a

[GitHub] merlimat opened a new pull request #1207: Allow to configure most client/producer/consumer options in Kafka API wrapper

2018-02-08 Thread GitBox
merlimat opened a new pull request #1207: Allow to configure most client/producer/consumer options in Kafka API wrapper URL: https://github.com/apache/incubator-pulsar/pull/1207 ### Motivation When using the Kafka API wrapper library, there can be the need to tune some of the option

[GitHub] merlimat commented on issue #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-08 Thread GitBox
merlimat commented on issue #1089: WIP - PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-364279251 The other doubt here was which form would be preferred between: ```java Producer producer = cli

[GitHub] merlimat closed pull request #1203: Use duplicates when writing from ByteBuf pair to avoid multiple threads issues

2018-02-08 Thread GitBox
merlimat closed pull request #1203: Use duplicates when writing from ByteBuf pair to avoid multiple threads issues URL: https://github.com/apache/incubator-pulsar/pull/1203 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[incubator-pulsar] branch master updated: Use duplicates when writing from ByteBuf pair to avoid multiple threads issues (#1203)

2018-02-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new feb0acc Use duplicates when writing f

[GitHub] merlimat commented on issue #1203: Use duplicates when writing from ByteBuf pair to avoid multiple threads issues

2018-02-08 Thread GitBox
merlimat commented on issue #1203: Use duplicates when writing from ByteBuf pair to avoid multiple threads issues URL: https://github.com/apache/incubator-pulsar/pull/1203#issuecomment-364266095 @jai1 @rdhabalia PTAL at this one -

[incubator-pulsar] branch master updated: Ensure the checksum is not stripped after validation in the broker (#1195)

2018-02-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 552249d Ensure the checksum is not st

[GitHub] merlimat closed pull request #1195: Ensure the checksum is not stripped after validation in the broker

2018-02-08 Thread GitBox
merlimat closed pull request #1195: Ensure the checksum is not stripped after validation in the broker URL: https://github.com/apache/incubator-pulsar/pull/1195 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat closed pull request #1204: Reduce size of buffer used to assemble batches

2018-02-08 Thread GitBox
merlimat closed pull request #1204: Reduce size of buffer used to assemble batches URL: https://github.com/apache/incubator-pulsar/pull/1204 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[incubator-pulsar] branch master updated: Reduce size of buffer used to assemble batches (#1204)

2018-02-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3615e25 Reduce size of buffer used to

[GitHub] merlimat opened a new issue #1206: Pulsar proxy should forward HTTP requests to brokers

2018-02-08 Thread GitBox
merlimat opened a new issue #1206: Pulsar proxy should forward HTTP requests to brokers URL: https://github.com/apache/incubator-pulsar/issues/1206 In order to be able to use admin API through proxy, the proxy needs to do reverse proxy to the broker, internally following redirects and writ

[GitHub] zhaijack commented on issue #1186: Pulsar FAQ

2018-02-08 Thread GitBox
zhaijack commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-364157939 for website, it may have a more wide audience. This is an automated message from the Apache Git Ser

[GitHub] XiaoZYang commented on issue #1186: Pulsar FAQ

2018-02-08 Thread GitBox
XiaoZYang commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-364120645 @sijie Sorry for the mess, I've reverted it . This is an automated message from the Apache Git Ser

[incubator-pulsar] branch master updated: Perf producer was overriding the producer max queue size (#1202)

2018-02-08 Thread yushiga
This is an automated email from the ASF dual-hosted git repository. yushiga pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b538165 Perf producer was overriding

[GitHub] yush1ga closed pull request #1202: Perf producer was overriding the producer max queue size

2018-02-08 Thread GitBox
yush1ga closed pull request #1202: Perf producer was overriding the producer max queue size URL: https://github.com/apache/incubator-pulsar/pull/1202 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] sijie commented on issue #1186: Pulsar FAQ

2018-02-08 Thread GitBox
sijie commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-364059199 @merlimat I would prefer website pages. I think it would make review easier. This is an automated mess

[GitHub] sijie commented on issue #1186: Pulsar FAQ

2018-02-08 Thread GitBox
sijie commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-364058943 @XiaoZYang it seems that you pushed a change with non-faq related changes. can you revert it? This is

[GitHub] sebbASF commented on issue #986: Bug: Download page must include KEYS, sig and hashes

2018-02-08 Thread GitBox
sebbASF commented on issue #986: Bug: Download page must include KEYS, sig and hashes URL: https://github.com/apache/incubator-pulsar/issues/986#issuecomment-364054352 Thanks, it looks as though you have fixed all the points I raised ---

[GitHub] sebbASF closed issue #986: Bug: Download page must include KEYS, sig and hashes

2018-02-08 Thread GitBox
sebbASF closed issue #986: Bug: Download page must include KEYS, sig and hashes URL: https://github.com/apache/incubator-pulsar/issues/986 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] ivankelly opened a new pull request #1205: Algorithm to find start point of compacted ledger

2018-02-08 Thread GitBox
ivankelly opened a new pull request #1205: Algorithm to find start point of compacted ledger URL: https://github.com/apache/incubator-pulsar/pull/1205 When reading from a compacted topic ledger, the reader will have to find the the first entry whole message id is greater than or equal to

[incubator-pulsar] branch asf-site updated: Updated site at revision b7e2e7c

2018-02-08 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new c77f887 Updated site at revision