[GitHub] rdhabalia commented on issue #1223: Add a `internalConfiguration` admin restful endpoint for query internal configuration

rdhabalia commented on issue #1223: Add a `internalConfiguration` admin restful endpoint for query internal configuration URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365839106 LGTM.. just few minor comments..

[GitHub] rdhabalia commented on a change in pull request #1223: Add a `internalConfiguration` admin restful endpoint for query internal configuration

rdhabalia commented on a change in pull request #1223: Add a `internalConfiguration` admin restful endpoint for query internal configuration URL: https://github.com/apache/incubator-pulsar/pull/1223#discussion_r168390204 ## File path:

[GitHub] rdhabalia commented on a change in pull request #1223: Add a `internalConfiguration` admin restful endpoint for query internal configuration

rdhabalia commented on a change in pull request #1223: Add a `internalConfiguration` admin restful endpoint for query internal configuration URL: https://github.com/apache/incubator-pulsar/pull/1223#discussion_r168390403 ## File path:

[GitHub] merlimat closed issue #1058: Provide a mechanism to tell whether a consumer is the leader of a failover subscription

merlimat closed issue #1058: Provide a mechanism to tell whether a consumer is the leader of a failover subscription URL: https://github.com/apache/incubator-pulsar/issues/1058 This is an automated message from the Apache

[incubator-pulsar] branch master updated: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group (#1156)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f2160c0 Introduce

[GitHub] merlimat closed pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

merlimat closed pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156 This is a PR merged from a forked repository. As GitHub hides the original diff on merge,

svn commit: r25081 - /dev/incubator/pulsar/pulsar-1.22.0-incubating-candidate-0/

Author: jai1 Date: Thu Feb 15 02:06:00 2018 New Revision: 25081 Log: Staging artifacts and signature for Pulsar release 1.22.0-incubating Added: dev/incubator/pulsar/pulsar-1.22.0-incubating-candidate-0/apache-pulsar-1.22.0-incubating-bin.tar.gz (with props)

[GitHub] merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365801659 retest this please

[GitHub] merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365801659 retest this please

[incubator-pulsar] branch branch-1.22 updated: add httpcore dep required by httpclient in hostname-verification (#1239)

This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch branch-1.22 in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/branch-1.22 by this push: new 96d720c add httpcore

[GitHub] merlimat closed pull request #1239: add httpcore dep required by httpclient in hostname-verification

merlimat closed pull request #1239: add httpcore dep required by httpclient in hostname-verification URL: https://github.com/apache/incubator-pulsar/pull/1239 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: add httpcore dep required by httpclient in hostname-verification (#1239)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 350d297 add httpcore dep required by

[GitHub] sijie opened a new issue #1240: Implement ActiveConsumerListener for pulsar cpp client

sijie opened a new issue #1240: Implement ActiveConsumerListener for pulsar cpp client URL: https://github.com/apache/incubator-pulsar/issues/1240 ActiveConsumerListener is introduced in #1156 . We need similar feature implemented in cpp client.

[GitHub] sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365780104 the CI failed with license header. fixed license header. I forgot

[incubator-pulsar] branch master updated: Make max clients per topic/subscription configurable (#1234)

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5613c2b Make max clients per

[GitHub] rdhabalia opened a new pull request #1239: add httpcore dep required by httpclient in hostname-verification

rdhabalia opened a new pull request #1239: add httpcore dep required by httpclient in hostname-verification URL: https://github.com/apache/incubator-pulsar/pull/1239 ### Motivation - when a broker's tls certificate present, httpclient's DefaultHostnameVerifier requires httpcore

[GitHub] merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

merlimat commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r168322621 ## File path:

[GitHub] rdhabalia closed pull request #1238: add httpcore dep required by httpclient in hostname-verification

rdhabalia closed pull request #1238: add httpcore dep required by httpclient in hostname-verification URL: https://github.com/apache/incubator-pulsar/pull/1238 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168294644 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[incubator-pulsar] branch master updated: Add non-persistent topic stats separately in brokers-stat (#1235)

This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3c9e281 Add non-persistent topic

[GitHub] rdhabalia closed pull request #1235: Add non-persistent topic stats separately in brokers-stat

rdhabalia closed pull request #1235: Add non-persistent topic stats separately in brokers-stat URL: https://github.com/apache/incubator-pulsar/pull/1235 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rdhabalia opened a new pull request #1238: add httpcore dep required by httpclient in hostname-verification

rdhabalia opened a new pull request #1238: add httpcore dep required by httpclient in hostname-verification URL: https://github.com/apache/incubator-pulsar/pull/1238 ### Motivation when a broker's tls certificate present, httpclient's DefaultHostnameVerifier requires httpcore

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168293225 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168283925 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168277614 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168275516 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -79,8 +86,9 @@ message MessageMetadata {

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168275383 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168274945 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -79,8 +86,9 @@ message MessageMetadata {

[incubator-pulsar] branch branch-1.20-yahoo deleted (was d5175b9)

This is an automated email from the ASF dual-hosted git repository. jai1 pushed a change to branch branch-1.20-yahoo in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git. was d5175b9 Bumped to 1.20.8-incubating-yahoo-SNAPSHOT This change permanently discards the

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168274469 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] dave2wave commented on a change in pull request #1232: Schema registry (1/4)

dave2wave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168274341 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168271879 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] mgodave commented on a change in pull request #1232: Schema registry (1/4)

mgodave commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168271025 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] ivankelly commented on a change in pull request #1232: Schema registry (1/4)

ivankelly commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168262139 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[GitHub] sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365688094 rebased to the latest master

[GitHub] ivankelly commented on a change in pull request #1232: Schema registry (1/4)

ivankelly commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168240669 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168237399 ## File path:

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168236993 ## File path:

[GitHub] merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

merlimat commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168236725 ## File path:

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168236331 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -272,6 +289,8 @@ message CommandProducer {

[GitHub] sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365666967 > This could also have been done by each consumer periodically adding a

[GitHub] sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168229704 ## File path:

[GitHub] sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168230414 ## File path:

[GitHub] sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168230587 ## File path:

[GitHub] sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168231825 ## File path:

[GitHub] sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

sijie commented on a change in pull request #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#discussion_r168229917 ## File path:

[GitHub] ivankelly commented on a change in pull request #1232: Schema registry (1/4)

ivankelly commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168196011 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] ivankelly commented on a change in pull request #1232: Schema registry (1/4)

ivankelly commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168230410 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] ivankelly commented on a change in pull request #1232: Schema registry (1/4)

ivankelly commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168229944 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -22,6 +22,20 @@ package pulsar.proto; option

[GitHub] ivankelly commented on a change in pull request #1232: Schema registry (1/4)

ivankelly commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168231228 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -368,6 +387,7 @@ message

[GitHub] merlimat commented on a change in pull request #1232: Schema registry (1/4)

merlimat commented on a change in pull request #1232: Schema registry (1/4) URL: https://github.com/apache/incubator-pulsar/pull/1232#discussion_r168231034 ## File path: pulsar-common/src/main/proto/PulsarApi.proto ## @@ -272,6 +289,8 @@ message CommandProducer {

[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-365505550 > Once we have subscription for topics and pattern, we need add them in. Yes, the idea was to have

[GitHub] merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

merlimat commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365660980 > Does this provide a way to figure out the current active consumer?

[GitHub] sijie commented on issue #1223: Add a `backend` admin restful endpoint for query backend information

sijie commented on issue #1223: Add a `backend` admin restful endpoint for query backend information URL: https://github.com/apache/incubator-pulsar/pull/1223#issuecomment-365658827 @rdhabalia @yush1ga I renamed "backend" to "internalConfiguration". Can you guys review this change again?

[GitHub] ivankelly commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

ivankelly commented on a change in pull request #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#discussion_r168221779 ## File path:

[GitHub] merlimat closed pull request #1228: Force to pull docker build image to regenerate PulsarApi.java generat?

merlimat closed pull request #1228: Force to pull docker build image to regenerate PulsarApi.java generat? URL: https://github.com/apache/incubator-pulsar/pull/1228 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] sijie commented on issue #1186: Pulsar FAQ

sijie commented on issue #1186: Pulsar FAQ URL: https://github.com/apache/incubator-pulsar/pull/1186#issuecomment-365653665 @lucperkins do you have time on helping with the FAQ content here? This is an automated message from

[GitHub] sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group

sijie commented on issue #1156: Introduce ActiveConsumerListener for realizing if a consumer is active in a failover subscription group URL: https://github.com/apache/incubator-pulsar/pull/1156#issuecomment-365652446 @merlimat as you suggested, I did two changes here: - rename

[GitHub] ivankelly commented on issue #1137: Schema registry

ivankelly commented on issue #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137#issuecomment-365634195 I don't see any client changes in this. How is a schema set for a topic? This is an

[GitHub] zhaijack commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

zhaijack commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#issuecomment-365620069 @merlimat @ivankelly, Thanks for your comments, Would you please help review it

[GitHub] zhaijack commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

zhaijack commented on issue #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#issuecomment-365613677 opened issue #1237 tracking using builder to create topics consumer.

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r168178825 ## File path:

[GitHub] zhaijack opened a new issue #1236: Make TopicsConsumerImpl extends PartitionedConsumerImpl

zhaijack opened a new issue #1236: Make TopicsConsumerImpl extends PartitionedConsumerImpl URL: https://github.com/apache/incubator-pulsar/issues/1236 IN PIP-13 and its following PRs: https://github.com/apache/incubator-pulsar/pull/1103, We have made TopicsConsumerImpl behaviour similar

[GitHub] zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace

zhaijack commented on a change in pull request #1103: PIP-13-1/3: Provide `TopicsConsumer` to consume from several topics under same namespace URL: https://github.com/apache/incubator-pulsar/pull/1103#discussion_r167877509 ## File path:

[incubator-pulsar] branch asf-site updated: Updated site at revision 7404952

This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/asf-site by this push: new 2716be2 Updated site at revision