[GitHub] jai1 commented on a change in pull request #1248: Start Proxy in TLS only mode.

2018-03-22 Thread GitBox
jai1 commented on a change in pull request #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#discussion_r176642168 ## File path: conf/broker.conf ## @@ -29,13 +29,13 @@ globalZookeeperServers= brokerServicePort=6650 # Broker

[GitHub] jai1 commented on issue #1248: Start Proxy in TLS only mode.

2018-03-22 Thread GitBox
jai1 commented on issue #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#issuecomment-375549651 @merlimat - have addressed all your comments This is an automated message from the

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-375540220 retest this please This is an automated message from the Apache Git

[GitHub] jai1 commented on a change in pull request #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
jai1 commented on a change in pull request #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#discussion_r176636245 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TlsProducerConsumerBase.java ##

[GitHub] jai1 opened a new pull request #1425: Using correct flag (isReplicationTlsEnabled) for redirection for dele…

2018-03-22 Thread GitBox
jai1 opened a new pull request #1425: Using correct flag (isReplicationTlsEnabled) for redirection for dele… URL: https://github.com/apache/incubator-pulsar/pull/1425 …te Namespace Code review bug: While deciding whether to return the serviceUrl or serviceUrlTls of a replication

[GitHub] sijie opened a new pull request #1424: Improve batch message acking by removing batch message tracker

2018-03-22 Thread GitBox
sijie opened a new pull request #1424: Improve batch message acking by removing batch message tracker URL: https://github.com/apache/incubator-pulsar/pull/1424 ### Motivation client is maintaining a batch message tracker to track batch messages for acknowledge. if the application

[GitHub] rdhabalia commented on issue #1423: Refactor pulsar function admin api location

2018-03-22 Thread GitBox
rdhabalia commented on issue #1423: Refactor pulsar function admin api location URL: https://github.com/apache/incubator-pulsar/pull/1423#issuecomment-375499120 yeah, I saw that cyclic dependency issue while bringing everything under `PulsarAdmin`. Will reopen if I will be able to fix it

[incubator-pulsar] branch master updated: Performance consumer end-to-end latency can be negative when running on different machines (#1422)

2018-03-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 38d3b4b Performance consumer

[GitHub] merlimat commented on issue #1423: Refactor pulsar function admin api location

2018-03-22 Thread GitBox
merlimat commented on issue #1423: Refactor pulsar function admin api location URL: https://github.com/apache/incubator-pulsar/pull/1423#issuecomment-375474829 @rdhabalia I think there was a problem with shading and dependencies to solve for this

[GitHub] rdhabalia closed pull request #1423: Refactor pulsar function admin api location

2018-03-22 Thread GitBox
rdhabalia closed pull request #1423: Refactor pulsar function admin api location URL: https://github.com/apache/incubator-pulsar/pull/1423 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] rdhabalia opened a new pull request #1423: Refactor pulsar function admin api location

2018-03-22 Thread GitBox
rdhabalia opened a new pull request #1423: Refactor pulsar function admin api location URL: https://github.com/apache/incubator-pulsar/pull/1423 ### Motivation Right now, pulsar-function admin api is not available. ### Modifications - to maintain consistency of

[GitHub] maskit commented on a change in pull request #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
maskit commented on a change in pull request #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#discussion_r176581561 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TlsProducerConsumerBase.java

[incubator-pulsar] branch master updated: Add pulsar python location to python path so that pdoc can succeed generating docs (#1414)

2018-03-22 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fdad48b Add pulsar python location to

[GitHub] sijie closed pull request #1414: Add pulsar python location to python path so that pdoc can succeed generating docs

2018-03-22 Thread GitBox
sijie closed pull request #1414: Add pulsar python location to python path so that pdoc can succeed generating docs URL: https://github.com/apache/incubator-pulsar/pull/1414 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] saandrews commented on issue #1417: Replace cached data key from the map if present already

2018-03-22 Thread GitBox
saandrews commented on issue #1417: Replace cached data key from the map if present already URL: https://github.com/apache/incubator-pulsar/pull/1417#issuecomment-375428928 retest this please This is an automated message

[GitHub] merlimat commented on issue #1422: Performance consumer end-to-end latency can be negative when running …

2018-03-22 Thread GitBox
merlimat commented on issue #1422: Performance consumer end-to-end latency can be negative when running … URL: https://github.com/apache/incubator-pulsar/pull/1422#issuecomment-375424294 ...actually that was the reason why I didn't put the e2e latency initially.

[GitHub] merlimat commented on issue #1422: Performance consumer end-to-end latency can be negative when running …

2018-03-22 Thread GitBox
merlimat commented on issue #1422: Performance consumer end-to-end latency can be negative when running … URL: https://github.com/apache/incubator-pulsar/pull/1422#issuecomment-375424147 > Currently if the producer and consumer has a difference in timestamp (average t) then we can just

[GitHub] merlimat opened a new pull request #1422: Performance consumer end-to-end latency can be negative when running …

2018-03-22 Thread GitBox
merlimat opened a new pull request #1422: Performance consumer end-to-end latency can be negative when running … URL: https://github.com/apache/incubator-pulsar/pull/1422 …on different machines ### Motivation We can measure "negative" end-to-end latency times when the

[GitHub] srkukarni commented on issue #1414: Add pulsar python location to python path so that pdoc can succeed generating docs

2018-03-22 Thread GitBox
srkukarni commented on issue #1414: Add pulsar python location to python path so that pdoc can succeed generating docs URL: https://github.com/apache/incubator-pulsar/pull/1414#issuecomment-375396870 retest this please This

[GitHub] saandrews commented on issue #1417: Replace cached data key from the map if present already

2018-03-22 Thread GitBox
saandrews commented on issue #1417: Replace cached data key from the map if present already URL: https://github.com/apache/incubator-pulsar/pull/1417#issuecomment-375390590 retest this please This is an automated message

[GitHub] jai1 commented on a change in pull request #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
jai1 commented on a change in pull request #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#discussion_r176504826 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TlsProducerConsumerBase.java ##

[GitHub] jai1 commented on issue #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
jai1 commented on issue #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#issuecomment-375388466 retest this please This is an automated message from the Apache Git

[GitHub] lucperkins commented on a change in pull request #1421: Fix Python example class name

2018-03-22 Thread GitBox
lucperkins commented on a change in pull request #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421#discussion_r176501475 ## File path: site/docs/latest/functions/quickstart.md ## @@ -212,9 +212,9 @@ $ touch reverse.py In that

[GitHub] lucperkins commented on a change in pull request #1421: Fix Python example class name

2018-03-22 Thread GitBox
lucperkins commented on a change in pull request #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421#discussion_r176501475 ## File path: site/docs/latest/functions/quickstart.md ## @@ -212,9 +212,9 @@ $ touch reverse.py In that

[GitHub] merlimat commented on a change in pull request #1421: Fix Python example class name

2018-03-22 Thread GitBox
merlimat commented on a change in pull request #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421#discussion_r176501175 ## File path: site/docs/latest/functions/quickstart.md ## @@ -212,9 +212,9 @@ $ touch reverse.py In that

[GitHub] merlimat commented on a change in pull request #1421: Fix Python example class name

2018-03-22 Thread GitBox
merlimat commented on a change in pull request #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421#discussion_r176501032 ## File path: site/docs/latest/functions/quickstart.md ## @@ -212,9 +212,9 @@ $ touch reverse.py In that

[GitHub] merlimat commented on a change in pull request #1421: Fix Python example class name

2018-03-22 Thread GitBox
merlimat commented on a change in pull request #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421#discussion_r176501260 ## File path: site/docs/latest/functions/quickstart.md ## @@ -212,9 +212,9 @@ $ touch reverse.py In that

[GitHub] lucperkins opened a new pull request #1421: Fix Python example class name

2018-03-22 Thread GitBox
lucperkins opened a new pull request #1421: Fix Python example class name URL: https://github.com/apache/incubator-pulsar/pull/1421 The Python interface for Pulsar Functions has changed, and the current Pulsar Functions quick start needs to be changed to reflect this.

[incubator-pulsar.wiki] branch master updated: Updated Home (markdown)

2018-03-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 5c91a82 Updated Home (markdown)

[incubator-pulsar.wiki] branch master updated: Created PIP-16: Pulsar "instance" terminology change (markdown)

2018-03-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.wiki.git The following commit(s) were added to refs/heads/master by this push: new 3e09a32 Created PIP-16: Pulsar

[incubator-pulsar] branch master updated: Utility to rebatch a message (#1391)

2018-03-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6541720 Utility to rebatch a message

[GitHub] merlimat closed pull request #1391: Utility to rebatch a message

2018-03-22 Thread GitBox
merlimat closed pull request #1391: Utility to rebatch a message URL: https://github.com/apache/incubator-pulsar/pull/1391 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] srkukarni commented on issue #1414: Add pulsar python location to python path so that pdoc can succeed generating docs

2018-03-22 Thread GitBox
srkukarni commented on issue #1414: Add pulsar python location to python path so that pdoc can succeed generating docs URL: https://github.com/apache/incubator-pulsar/pull/1414#issuecomment-375365673 retest this please This

[GitHub] merlimat closed pull request #1420: Null checks in MockedPulsarServiceBaseTest

2018-03-22 Thread GitBox
merlimat closed pull request #1420: Null checks in MockedPulsarServiceBaseTest URL: https://github.com/apache/incubator-pulsar/pull/1420 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Null checks in MockedPulsarServiceBaseTest (#1420)

2018-03-22 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9bc5518 Null checks in

[GitHub] maskit commented on issue #1419: Pulsar standalone fails to start with java 9

2018-03-22 Thread GitBox
maskit commented on issue #1419: Pulsar standalone fails to start with java 9 URL: https://github.com/apache/incubator-pulsar/issues/1419#issuecomment-375265185 Maybe this? https://github.com/electronicarts/ea-agent-loader/issues/10

[GitHub] maskit commented on a change in pull request #1297: Add Configuration to set tlsClientAuth

2018-03-22 Thread GitBox
maskit commented on a change in pull request #1297: Add Configuration to set tlsClientAuth URL: https://github.com/apache/incubator-pulsar/pull/1297#discussion_r176378321 ## File path: pulsar-broker/src/test/java/org/apache/pulsar/client/api/TlsProducerConsumerBase.java