[GitHub] jerrypeng commented on a change in pull request #1622: Add pull source

2018-04-19 Thread GitBox
jerrypeng commented on a change in pull request #1622: Add pull source URL: https://github.com/apache/incubator-pulsar/pull/1622#discussion_r182952190 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Source.java ## @@ -0,0 +1,38 @@ +/** + *

[incubator-pulsar] branch master updated: Document 307 redirection on admin restful api (#1619)

2018-04-19 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 3bfa9d6 Document 307 redirection on

[GitHub] sijie closed pull request #1619: Document 307 redirect on admin restful api

2018-04-19 Thread GitBox
sijie closed pull request #1619: Document 307 redirect on admin restful api URL: https://github.com/apache/incubator-pulsar/pull/1619 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] srkukarni commented on a change in pull request #1622: Add pull source

2018-04-19 Thread GitBox
srkukarni commented on a change in pull request #1622: Add pull source URL: https://github.com/apache/incubator-pulsar/pull/1622#discussion_r182949836 ## File path: pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Source.java ## @@ -0,0 +1,38 @@ +/** + *

[GitHub] jerrypeng commented on issue #1622: Add pull source

2018-04-19 Thread GitBox
jerrypeng commented on issue #1622: Add pull source URL: https://github.com/apache/incubator-pulsar/pull/1622#issuecomment-382982201 @srkukarni @sijie please review This is an automated message from the Apache Git Service. To

[GitHub] jerrypeng opened a new pull request #1622: Add pull source

2018-04-19 Thread GitBox
jerrypeng opened a new pull request #1622: Add pull source URL: https://github.com/apache/incubator-pulsar/pull/1622 ### Motivation add pull source connector interface for Pulsar This is an automated message from

[GitHub] sijie commented on issue #1620: Issue #1618: Topic termination should work with no consumers connected to

2018-04-19 Thread GitBox
sijie commented on issue #1620: Issue #1618: Topic termination should work with no consumers connected to URL: https://github.com/apache/incubator-pulsar/pull/1620#issuecomment-382980594 retest this please This is an

[GitHub] srkukarni commented on a change in pull request #1621: refactoring java instance to use pull model for message ingress

2018-04-19 Thread GitBox
srkukarni commented on a change in pull request #1621: refactoring java instance to use pull model for message ingress URL: https://github.com/apache/incubator-pulsar/pull/1621#discussion_r182944409 ## File path:

[GitHub] jerrypeng commented on issue #1621: refactoring java instance to use pull model for message ingress

2018-04-19 Thread GitBox
jerrypeng commented on issue #1621: refactoring java instance to use pull model for message ingress URL: https://github.com/apache/incubator-pulsar/pull/1621#issuecomment-382972964 @sijie @srkukarni please review This is an

[GitHub] jerrypeng opened a new pull request #1621: refactoring java instance to use pull model for message ingress

2018-04-19 Thread GitBox
jerrypeng opened a new pull request #1621: refactoring java instance to use pull model for message ingress URL: https://github.com/apache/incubator-pulsar/pull/1621 ### Motivation To simplify the processing model for functions. Prepare to be able to support running

[GitHub] sijie closed issue #1555: NPE in pulsar function worker

2018-04-19 Thread GitBox
sijie closed issue #1555: NPE in pulsar function worker URL: https://github.com/apache/incubator-pulsar/issues/1555 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie commented on issue #1555: NPE in pulsar function worker

2018-04-19 Thread GitBox
sijie commented on issue #1555: NPE in pulsar function worker URL: https://github.com/apache/incubator-pulsar/issues/1555#issuecomment-382936823 Talked with @jerrypeng I think this is fixed. closing it. This is an automated

[GitHub] sijie opened a new pull request #1620: Issue #1618: Topic termination should work with no consumers connected to

2018-04-19 Thread GitBox
sijie opened a new pull request #1620: Issue #1618: Topic termination should work with no consumers connected to URL: https://github.com/apache/incubator-pulsar/pull/1620 *Problem* Topic termination fails with NPE when there is no consumers connected to. *Solution* If

[GitHub] merlimat commented on issue #1608: Fixed typo in ConsumerBuilder acknowledgmentGroupTime option

2018-04-19 Thread GitBox
merlimat commented on issue #1608: Fixed typo in ConsumerBuilder acknowledgmentGroupTime option URL: https://github.com/apache/incubator-pulsar/pull/1608#issuecomment-382891932 retest this please This is an automated message

[GitHub] merlimat commented on issue #1608: Fixed typo in ConsumerBuilder acknowledgmentGroupTime option

2018-04-19 Thread GitBox
merlimat commented on issue #1608: Fixed typo in ConsumerBuilder acknowledgmentGroupTime option URL: https://github.com/apache/incubator-pulsar/pull/1608#issuecomment-382891932 retest this please This is an automated message

[GitHub] sijie opened a new pull request #1619: Document 307 redirect on admin restful api

2018-04-19 Thread GitBox
sijie opened a new pull request #1619: Document 307 redirect on admin restful api URL: https://github.com/apache/incubator-pulsar/pull/1619 Admin rest apis like `createSubscription` redirect with `307`. so we need to update the documentation to let people know to handle `307`.

[GitHub] sijie commented on issue #1613: Add a integration test for create subscription CLI command

2018-04-19 Thread GitBox
sijie commented on issue #1613: Add a integration test for create subscription CLI command URL: https://github.com/apache/incubator-pulsar/pull/1613#issuecomment-382853669 two issues spots with this integration tests: - pulsar admin doesn't handle exception correctly. ``` Got

[GitHub] sijie opened a new issue #1618: NPE at topic termination when there is no consumers connected

2018-04-19 Thread GitBox
sijie opened a new issue #1618: NPE at topic termination when there is no consumers connected URL: https://github.com/apache/incubator-pulsar/issues/1618 Expected behavior topic termination should work no matter if there are consumers connected or not. Actual

[GitHub] merlimat closed pull request #1586: Added config to deploy pulsar in aws using ebs storage

2018-04-19 Thread GitBox
merlimat closed pull request #1586: Added config to deploy pulsar in aws using ebs storage URL: https://github.com/apache/incubator-pulsar/pull/1586 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Added config to deploy pulsar in aws using ebs storage (#1586)

2018-04-19 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new f703926 Added config to deploy

[GitHub] mgodave commented on issue #1505: Proxy admin web requests

2018-04-19 Thread GitBox
mgodave commented on issue #1505: Proxy admin web requests URL: https://github.com/apache/incubator-pulsar/pull/1505#issuecomment-382788049 yup, in progress. On Thu, Apr 19, 2018 at 8:40 AM, Matteo Merli wrote: > *@merlimat* commented on this pull

[GitHub] merlimat commented on issue #1617: (WIP) Fixing PersistentFailoverE2ETest

2018-04-19 Thread GitBox
merlimat commented on issue #1617: (WIP) Fixing PersistentFailoverE2ETest URL: https://github.com/apache/incubator-pulsar/pull/1617#issuecomment-382758692 The problem was reproducing for me locally when running multiple times, with ```java @Test(invocationCount=100) ...

[GitHub] sijie commented on issue #1617: (WIP) Fixing PersistentFailoverE2ETest

2018-04-19 Thread GitBox
sijie commented on issue #1617: (WIP) Fixing PersistentFailoverE2ETest URL: https://github.com/apache/incubator-pulsar/pull/1617#issuecomment-382634367 Currently I can't reproduce the failure of PersistentFailoverE2ETest, trying to adding more logging information and see if CI can give

[GitHub] sijie opened a new pull request #1617: (WIP) Fixing PersistentFailoverE2ETest

2018-04-19 Thread GitBox
sijie opened a new pull request #1617: (WIP) Fixing PersistentFailoverE2ETest URL: https://github.com/apache/incubator-pulsar/pull/1617 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie closed pull request #1604: Compression support for compaction

2018-04-19 Thread GitBox
sijie closed pull request #1604: Compression support for compaction URL: https://github.com/apache/incubator-pulsar/pull/1604 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[incubator-pulsar] branch master updated: Compression support for compaction (#1604)

2018-04-19 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new dc404e0 Compression support for

[incubator-pulsar] branch master updated: Fixed initial default namespace setup with current cluster setup (#1607)

2018-04-19 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new a86e7be Fixed initial default