[GitHub] rdhabalia commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics

2018-04-25 Thread GitBox
rdhabalia commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics URL: https://github.com/apache/incubator-pulsar/pull/1647#discussion_r184277172 ## File path:

[GitHub] rdhabalia closed pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics

2018-04-25 Thread GitBox
rdhabalia closed pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics URL: https://github.com/apache/incubator-pulsar/pull/1647 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[incubator-pulsar] branch master updated: Fix: remove local-cluster from replication list of global-namespace should clean topics (#1647)

2018-04-25 Thread rdhabalia
This is an automated email from the ASF dual-hosted git repository. rdhabalia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 9746ea4 Fix: remove local-cluster

[GitHub] merlimat commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics

2018-04-25 Thread GitBox
merlimat commented on a change in pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics URL: https://github.com/apache/incubator-pulsar/pull/1647#discussion_r184275718 ## File path:

[GitHub] merlimat closed pull request #1646: Fix the exception output for admin commands

2018-04-25 Thread GitBox
merlimat closed pull request #1646: Fix the exception output for admin commands URL: https://github.com/apache/incubator-pulsar/pull/1646 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[incubator-pulsar] branch master updated: Hide namespace cli commands that are no longer relevant (#1645)

2018-04-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new fc3417f Hide namespace cli commands

[incubator-pulsar] branch master updated: Fix the exception output for admin commands (#1646)

2018-04-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 43d2257 Fix the exception output for

[GitHub] merlimat closed pull request #1645: Hide namespace cli commands that are no longer relevant

2018-04-25 Thread GitBox
merlimat closed pull request #1645: Hide namespace cli commands that are no longer relevant URL: https://github.com/apache/incubator-pulsar/pull/1645 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] merlimat commented on issue #1580: Modified functions producer consumers to use new builder based api

2018-04-25 Thread GitBox
merlimat commented on issue #1580: Modified functions producer consumers to use new builder based api URL: https://github.com/apache/incubator-pulsar/pull/1580#issuecomment-384518513 retest this please This is an automated

[GitHub] jerrypeng commented on issue #1649: refactoring functions to use source interface

2018-04-25 Thread GitBox
jerrypeng commented on issue #1649: refactoring functions to use source interface URL: https://github.com/apache/incubator-pulsar/pull/1649#issuecomment-384517581 @sijie @srkukarni please review This is an automated message

[GitHub] jerrypeng opened a new pull request #1649: refactoring functions to use source interface

2018-04-25 Thread GitBox
jerrypeng opened a new pull request #1649: refactoring functions to use source interface URL: https://github.com/apache/incubator-pulsar/pull/1649 This is an automated message from the Apache Git Service. To respond to

[GitHub] cckellogg opened a new pull request #1648: Optionally expose publisher stats in broker-stats admin rest api.

2018-04-25 Thread GitBox
cckellogg opened a new pull request #1648: Optionally expose publisher stats in broker-stats admin rest api. URL: https://github.com/apache/incubator-pulsar/pull/1648 Add a flag to expose the publishers in the broker-stats admin rest api call. This also changes the endpoint to topics for

[GitHub] rdhabalia opened a new pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics

2018-04-25 Thread GitBox
rdhabalia opened a new pull request #1647: Fix: remove local-cluster from replication list of global-namespace should clean topics URL: https://github.com/apache/incubator-pulsar/pull/1647 ### Motivation Right now, if we remove local-cluster from repl-cluster list of the global

[GitHub] sijie commented on issue #1646: Fix the exception output for admin commands

2018-04-25 Thread GitBox
sijie commented on issue #1646: Fix the exception output for admin commands URL: https://github.com/apache/incubator-pulsar/pull/1646#issuecomment-384479753 /cc @srkukarni This is an automated message from the Apache Git

[GitHub] sijie opened a new pull request #1646: Fix the exception output for admin commands

2018-04-25 Thread GitBox
sijie opened a new pull request #1646: Fix the exception output for admin commands URL: https://github.com/apache/incubator-pulsar/pull/1646 ### Motivation The output was changed for debugging in #1613 ### Modifications Revert the output back to original output.

[GitHub] sijie commented on issue #1580: Modified functions producer consumers to use new builder based api

2018-04-25 Thread GitBox
sijie commented on issue #1580: Modified functions producer consumers to use new builder based api URL: https://github.com/apache/incubator-pulsar/pull/1580#issuecomment-384470674 I fixed the tests, so it should be good now.

[GitHub] sijie commented on issue #1617: (WIP) Fixing PersistentFailoverE2ETest

2018-04-25 Thread GitBox
sijie commented on issue #1617: (WIP) Fixing PersistentFailoverE2ETest URL: https://github.com/apache/incubator-pulsar/pull/1617#issuecomment-384460767 defer this to 2.1 after discussed with @merlimat This is an automated

[GitHub] sijie commented on issue #1614: Itermittent test timeout on PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition

2018-04-25 Thread GitBox
sijie commented on issue #1614: Itermittent test timeout on PersistentFailoverE2ETest.testSimpleConsumerEventsWithoutPartition URL: https://github.com/apache/incubator-pulsar/issues/1614#issuecomment-384460655 discussed with @merlimat - it is a bit unknown how the flaky test can happen

[GitHub] mgodave commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384448768 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] mgodave commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384445656 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] merlimat commented on issue #1645: Hide namespace cli commands that are no longer relevant

2018-04-25 Thread GitBox
merlimat commented on issue #1645: Hide namespace cli commands that are no longer relevant URL: https://github.com/apache/incubator-pulsar/pull/1645#issuecomment-384446234 > what is the reason for hiding this command? `pulsar-admin namespaces destinations $MY_NAMESPACE` was

[GitHub] mgodave commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384445656 retest this please This is an automated message from the Apache Git Service. To respond to

[GitHub] srkukarni commented on issue #1645: Hide namespace cli commands that are no longer relevant

2018-04-25 Thread GitBox
srkukarni commented on issue #1645: Hide namespace cli commands that are no longer relevant URL: https://github.com/apache/incubator-pulsar/pull/1645#issuecomment-384443038 In 2.0 the concept of cluster in a topic name goes away. Plus I believe we(and the rest of the industry) have

[GitHub] rdhabalia commented on issue #1645: Hide namespace cli commands that are no longer relevant

2018-04-25 Thread GitBox
rdhabalia commented on issue #1645: Hide namespace cli commands that are no longer relevant URL: https://github.com/apache/incubator-pulsar/pull/1645#issuecomment-384442540 what is the reason for hiding this command? This is

[GitHub] merlimat commented on issue #1644: Hide CLI namespaces list-cluster and destinations commands

2018-04-25 Thread GitBox
merlimat commented on issue #1644: Hide CLI namespaces list-cluster and destinations commands URL: https://github.com/apache/incubator-pulsar/pull/1644#issuecomment-384441437 closing for #1645 This is an automated message

[GitHub] merlimat closed pull request #1644: Hide CLI namespaces list-cluster and destinations commands

2018-04-25 Thread GitBox
merlimat closed pull request #1644: Hide CLI namespaces list-cluster and destinations commands URL: https://github.com/apache/incubator-pulsar/pull/1644 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Delete offloaded ledger when ledger deleted (#1641)

2018-04-25 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 6001c41 Delete offloaded ledger when

[GitHub] sijie closed pull request #1641: Delete offloaded ledger when ledger deleted

2018-04-25 Thread GitBox
sijie closed pull request #1641: Delete offloaded ledger when ledger deleted URL: https://github.com/apache/incubator-pulsar/pull/1641 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] sijie closed pull request #1643: Offloading prints wrong log on exception

2018-04-25 Thread GitBox
sijie closed pull request #1643: Offloading prints wrong log on exception URL: https://github.com/apache/incubator-pulsar/pull/1643 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Offloading prints wrong log on exception (#1643)

2018-04-25 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new edf01a8 Offloading prints wrong log

[GitHub] srkukarni commented on issue #1645: Hide namespace cli commands that are no longer relevant

2018-04-25 Thread GitBox
srkukarni commented on issue #1645: Hide namespace cli commands that are no longer relevant URL: https://github.com/apache/incubator-pulsar/pull/1645#issuecomment-384441016 @merlimat This is an automated message from the

[GitHub] srkukarni opened a new pull request #1645: Hide namespace cli commands that are no longer relevant

2018-04-25 Thread GitBox
srkukarni opened a new pull request #1645: Hide namespace cli commands that are no longer relevant URL: https://github.com/apache/incubator-pulsar/pull/1645 ### Motivation Explain here the context, and why you're making that change. What is the problem you're trying to solve.

[GitHub] merlimat opened a new pull request #1644: Hide CLI namespaces list-cluster and destinations commands

2018-04-25 Thread GitBox
merlimat opened a new pull request #1644: Hide CLI namespaces list-cluster and destinations commands URL: https://github.com/apache/incubator-pulsar/pull/1644 ### Motivation Hide deprecated commands `namespaces list-cluster` and `namespaces destinations` from CLI help command.

[GitHub] sijie commented on issue #1639: Rest API for Ledger Offloading

2018-04-25 Thread GitBox
sijie commented on issue #1639: Rest API for Ledger Offloading URL: https://github.com/apache/incubator-pulsar/pull/1639#issuecomment-384433056 cool thanks @ivankelly This is an automated message from the Apache Git Service.

[GitHub] ivankelly commented on issue #1639: Rest API for Ledger Offloading

2018-04-25 Thread GitBox
ivankelly commented on issue #1639: Rest API for Ledger Offloading URL: https://github.com/apache/incubator-pulsar/pull/1639#issuecomment-384421873 @sijie ya, I thought about doing it like that when I was finishing this version. Compaction is done like that. Will change this.

[GitHub] sijie commented on issue #1599: Throw illegal state exception instead of NPE in zk-cache when no session available

2018-04-25 Thread GitBox
sijie commented on issue #1599: Throw illegal state exception instead of NPE in zk-cache when no session available URL: https://github.com/apache/incubator-pulsar/pull/1599#issuecomment-384411018 retest this please This is

[GitHub] sijie commented on issue #1509: Fix init of Input CustomSerDe of function

2018-04-25 Thread GitBox
sijie commented on issue #1509: Fix init of Input CustomSerDe of function URL: https://github.com/apache/incubator-pulsar/pull/1509#issuecomment-384410383 @rdhabalia @srkukarni I moved this to 2.1, feel free to move it back to 2.0

[GitHub] mgodave commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
mgodave commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384409566 I just noticed that, I included a stashed change by accident, one sec... On Wed, Apr 25, 2018 at 1:36 PM, Sijie Guo wrote:

[GitHub] sijie commented on issue #1063: ENH: Add code formatter for Java

2018-04-25 Thread GitBox
sijie commented on issue #1063: ENH: Add code formatter for Java URL: https://github.com/apache/incubator-pulsar/pull/1063#issuecomment-384409549 moved to 2.1. if it is required for 2.0, feel free to move it back. This is an

[GitHub] sijie commented on issue #1248: Start Proxy in TLS only mode.

2018-04-25 Thread GitBox
sijie commented on issue #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#issuecomment-384409153 @jai1 I moved this to 2.1, if you think we should include this for 2.0, please move it back :)

[GitHub] sijie commented on issue #1546: Fix: handle failure of topic stat update

2018-04-25 Thread GitBox
sijie commented on issue #1546: Fix: handle failure of topic stat update URL: https://github.com/apache/incubator-pulsar/pull/1546#issuecomment-384407612 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1580: Modified functions producer consumers to use new builder based api

2018-04-25 Thread GitBox
sijie commented on issue #1580: Modified functions producer consumers to use new builder based api URL: https://github.com/apache/incubator-pulsar/pull/1580#issuecomment-384406986 @merlimat - just fyi, I rebased this PR to latest master.

[GitHub] sijie commented on issue #1640: Read OffloadedLedger if available

2018-04-25 Thread GitBox
sijie commented on issue #1640: Read OffloadedLedger if available URL: https://github.com/apache/incubator-pulsar/pull/1640#issuecomment-384401488 retest this please This is an automated message from the Apache Git Service.

[GitHub] sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli)

2018-04-25 Thread GitBox
sijie commented on issue #1059: Issue 1014: Rename "global zookeeper" to "configuration-store"(change in code, conf and cli) URL: https://github.com/apache/incubator-pulsar/pull/1059#issuecomment-384401335 @zhaijack I've rebased your branch to latest master. let's see CI results.

[GitHub] sijie commented on issue #1643: Offloading prints wrong log on exception

2018-04-25 Thread GitBox
sijie commented on issue #1643: Offloading prints wrong log on exception URL: https://github.com/apache/incubator-pulsar/pull/1643#issuecomment-384400622 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1593: PIP-17: the part of index block for offload.

2018-04-25 Thread GitBox
sijie commented on issue #1593: PIP-17: the part of index block for offload. URL: https://github.com/apache/incubator-pulsar/pull/1593#issuecomment-384397555 ping @ivankelly ? This is an automated message from the Apache Git

[GitHub] sijie closed pull request #1632: Avoid creating different message object for pulsar sink connector

2018-04-25 Thread GitBox
sijie closed pull request #1632: Avoid creating different message object for pulsar sink connector URL: https://github.com/apache/incubator-pulsar/pull/1632 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] sijie commented on issue #1632: Avoid creating different message object for pulsar sink connector

2018-04-25 Thread GitBox
sijie commented on issue #1632: Avoid creating different message object for pulsar sink connector URL: https://github.com/apache/incubator-pulsar/pull/1632#issuecomment-384397279 @rdhabalia - I am closing this issue since #1636 has been merged.

[GitHub] lucperkins commented on issue #1446: Pulsar 2.0 Documentation

2018-04-25 Thread GitBox
lucperkins commented on issue #1446: Pulsar 2.0 Documentation URL: https://github.com/apache/incubator-pulsar/issues/1446#issuecomment-376286514 - [x] Message deduplication - [ ] Add "cookbooks" section with end-to-end instructions for specific tasks (like adding and removing nodes)

[GitHub] lucperkins commented on issue #1446: Pulsar 2.0 Documentation

2018-04-25 Thread GitBox
lucperkins commented on issue #1446: Pulsar 2.0 Documentation URL: https://github.com/apache/incubator-pulsar/issues/1446#issuecomment-376286514 - [ ] Message deduplication - [ ] Add "cookbooks" section with end-to-end instructions for specific tasks (like adding and removing nodes)

[GitHub] sijie commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
sijie commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384391221 we should leave counter/state part out of the scope of 2.0. let's finish the documentation for stateless part, we need finish the

[GitHub] ivankelly commented on a change in pull request #1642: Clock interface in ManagedLedger for testing

2018-04-25 Thread GitBox
ivankelly commented on a change in pull request #1642: Clock interface in ManagedLedger for testing URL: https://github.com/apache/incubator-pulsar/pull/1642#discussion_r184157483 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java

[GitHub] lucperkins commented on issue #1457: Schema registry documentation (WIP)

2018-04-25 Thread GitBox
lucperkins commented on issue #1457: Schema registry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1457#issuecomment-384372490 @sijie @mgodave This is NOT ready for review, and work on this can really only continue when the schema registry is integrated with the

[GitHub] mgodave commented on issue #1457: Schema registry documentation (WIP)

2018-04-25 Thread GitBox
mgodave commented on issue #1457: Schema registry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1457#issuecomment-384368789 On the list for today. This is an automated message from the Apache Git

[GitHub] srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384362636 I consider Counters as advanced features that allows us to do stateful functions, but without them stateless functions are still

[GitHub] merlimat commented on a change in pull request #1642: Clock interface in ManagedLedger for testing

2018-04-25 Thread GitBox
merlimat commented on a change in pull request #1642: Clock interface in ManagedLedger for testing URL: https://github.com/apache/incubator-pulsar/pull/1642#discussion_r184136903 ## File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedLedgerConfig.java

[GitHub] merlimat closed issue #1206: Pulsar proxy should forward HTTP requests to brokers

2018-04-25 Thread GitBox
merlimat closed issue #1206: Pulsar proxy should forward HTTP requests to brokers URL: https://github.com/apache/incubator-pulsar/issues/1206 This is an automated message from the Apache Git Service. To respond to the

[incubator-pulsar] branch master updated: Proxy admin web requests (#1505)

2018-04-25 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0c9822c Proxy admin web requests

[GitHub] lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384328497 @srkukarni I know, I was waiting on counter support, but if that's not required for API completion then I can resume work on this.

[GitHub] ivankelly commented on issue #1640: Read OffloadedLedger if available

2018-04-25 Thread GitBox
ivankelly commented on issue #1640: Read OffloadedLedger if available URL: https://github.com/apache/incubator-pulsar/pull/1640#issuecomment-384310152 retest this please // ManagedCursorTest.testReplayEntries This is an

[GitHub] ivankelly commented on issue #1639: Rest API for Ledger Offloading

2018-04-25 Thread GitBox
ivankelly commented on issue #1639: Rest API for Ledger Offloading URL: https://github.com/apache/incubator-pulsar/pull/1639#issuecomment-384309216 retest this please // integration test timeout This is an automated message

[GitHub] ivankelly opened a new pull request #1643: Offloading prints wrong log on exception

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1643: Offloading prints wrong log on exception URL: https://github.com/apache/incubator-pulsar/pull/1643 The check for exception was backwards, so it was always warning in the happy case, and reporting success in the case of failure. Master

[GitHub] ivankelly opened a new pull request #1642: Clock interface in ManagedLedger for testing

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1642: Clock interface in ManagedLedger for testing URL: https://github.com/apache/incubator-pulsar/pull/1642 Managed ledger has background tasks which act on ledgers after configured times. To test these, we need to be able to move through time.

[GitHub] srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384304741 Except for counter support, Python api/implementation already exists

[GitHub] lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
lucperkins commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384302873 Work in progress. Will the Python API be complete by 2.0? On Wed, Apr 25, 2018 at 7:15 AM Sanjeev Kulkarni

[GitHub] srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
srkukarni commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384302533 I think we need to complete this for 2.0 This is an automated message

[GitHub] ivankelly opened a new pull request #1640: Read OffloadedLedger if available

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1640: Read OffloadedLedger if available URL: https://github.com/apache/incubator-pulsar/pull/1640 If a ledger has been previously offloaded to long term storage, read the ledger from long term storage, rather than from bookkeeper. Master issue

[GitHub] ivankelly opened a new pull request #1641: Delete offloaded ledger when ledger deleted

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1641: Delete offloaded ledger when ledger deleted URL: https://github.com/apache/incubator-pulsar/pull/1641 When a managed ledger trims a ledger, if that ledger has been offloaded to long term storage, delete it from long term storage also.

[GitHub] ivankelly closed pull request #1637: LedgerOffloader interface allows two phase update

2018-04-25 Thread GitBox
ivankelly closed pull request #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update

2018-04-25 Thread GitBox
ivankelly commented on issue #1637: LedgerOffloader interface allows two phase update URL: https://github.com/apache/incubator-pulsar/pull/1637#issuecomment-384244943 @sijie these changes were already in #1549 . My idea was to merge this one first, to keep the #1549 focused on the

[GitHub] ivankelly opened a new pull request #1639: Rest API for Ledger Offloading

2018-04-25 Thread GitBox
ivankelly opened a new pull request #1639: Rest API for Ledger Offloading URL: https://github.com/apache/incubator-pulsar/pull/1639 Implemented for both V1 and V2 topic name formats. API takes a message ID, up to which the broker will try to offload messages. It returns the message ID

[GitHub] sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-25 Thread GitBox
sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#issuecomment-384215856 @rdhabalia thank you This is an automated

[GitHub] sijie commented on issue #1266: Pass all Apache Podling Website Checks

2018-04-25 Thread GitBox
sijie commented on issue #1266: Pass all Apache Podling Website Checks URL: https://github.com/apache/incubator-pulsar/issues/1266#issuecomment-384215343 (Move this to 2.1.0, since it is not a blocker for 2.0) This is an

[GitHub] sijie commented on issue #1446: Pulsar 2.0 Documentation

2018-04-25 Thread GitBox
sijie commented on issue #1446: Pulsar 2.0 Documentation URL: https://github.com/apache/incubator-pulsar/issues/1446#issuecomment-384213624 @lucperkins can you check the boxes what items are done? This is an automated

[GitHub] sijie commented on issue #1466: Topic compaction documentation (WIP)

2018-04-25 Thread GitBox
sijie commented on issue #1466: Topic compaction documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1466#issuecomment-384213099 @lucperkins what is the state of this PR? @ivankelly shall we include this for 2.0?

[GitHub] sijie commented on issue #1457: Schema registry documentation (WIP)

2018-04-25 Thread GitBox
sijie commented on issue #1457: Schema registry documentation (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1457#issuecomment-384213267 @lucperkins what is the state of this PR? is it ready for review? @mgodave can you review this?

[GitHub] sijie commented on issue #1482: Pulsar Functions for Python docs (WIP)

2018-04-25 Thread GitBox
sijie commented on issue #1482: Pulsar Functions for Python docs (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1482#issuecomment-384212850 @lucperkins what is the state of this PR? @srkukarni shall we include this for 2.0?

[GitHub] sijie commented on issue #1509: Fix init of Input CustomSerDe of function

2018-04-25 Thread GitBox
sijie commented on issue #1509: Fix init of Input CustomSerDe of function URL: https://github.com/apache/incubator-pulsar/pull/1509#issuecomment-384212529 @rdhabalia are you still working on this change? shall we move this to 2.1?

[GitHub] rdhabalia commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-25 Thread GitBox
rdhabalia commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#issuecomment-384212326 > since we are close to 2.0 release, shall we move this PR to 2.1? Sure, we can move it to next

[GitHub] sijie commented on issue #1546: Fix: handle failure of topic stat update

2018-04-25 Thread GitBox
sijie commented on issue #1546: Fix: handle failure of topic stat update URL: https://github.com/apache/incubator-pulsar/pull/1546#issuecomment-384211952 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
sijie commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384211810 @merlimat can you review @mgodave 's latest change? This is an automated message from the

[GitHub] sijie commented on issue #1551: Json schema codec

2018-04-25 Thread GitBox
sijie commented on issue #1551: Json schema codec URL: https://github.com/apache/incubator-pulsar/pull/1551#issuecomment-384211672 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #1580: Modified functions producer consumers to use new builder based api

2018-04-25 Thread GitBox
sijie commented on issue #1580: Modified functions producer consumers to use new builder based api URL: https://github.com/apache/incubator-pulsar/pull/1580#issuecomment-384211396 @merlimat can you rebase this? This is an

[GitHub] sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function

2018-04-25 Thread GitBox
sijie commented on issue #1594: Introduce pulsar-replicator and kinesis-provider with pulsar-function URL: https://github.com/apache/incubator-pulsar/pull/1594#issuecomment-38421 @rdhabalia - since we are close to 2.0 release, shall we move this PR to 2.1?

[GitHub] rdhabalia commented on issue #577: CPP add receiveAsync API

2018-04-25 Thread GitBox
rdhabalia commented on issue #577: CPP add receiveAsync API URL: https://github.com/apache/incubator-pulsar/pull/577#issuecomment-384211303 sure. I will rebase it and we can take it to next release. This is an automated

[GitHub] sijie commented on issue #1599: Throw illegal state exception instead of NPE in zk-cache when no session available

2018-04-25 Thread GitBox
sijie commented on issue #1599: Throw illegal state exception instead of NPE in zk-cache when no session available URL: https://github.com/apache/incubator-pulsar/pull/1599#issuecomment-384210839 retest this please This is

[GitHub] sijie commented on issue #1632: Avoid creating different message object for pulsar sink connector

2018-04-25 Thread GitBox
sijie commented on issue #1632: Avoid creating different message object for pulsar sink connector URL: https://github.com/apache/incubator-pulsar/pull/1632#issuecomment-384210662 @rdhabalia since #1636 is already merged, shall we close this one?

[GitHub] sijie commented on issue #1287: Provide documentation for the load manager and bundles

2018-04-25 Thread GitBox
sijie commented on issue #1287: Provide documentation for the load manager and bundles URL: https://github.com/apache/incubator-pulsar/issues/1287#issuecomment-384210151 @lucperkins is this done? This is an automated

[GitHub] sijie commented on issue #1288: Provide documentation for running BookKeeper auto-recovery

2018-04-25 Thread GitBox
sijie commented on issue #1288: Provide documentation for running BookKeeper auto-recovery URL: https://github.com/apache/incubator-pulsar/issues/1288#issuecomment-384210006 @lucperkins are you working on this? This is an

[GitHub] sijie commented on issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie commented on issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267#issuecomment-384209722 fixed by #1156 This is an automated message from

[GitHub] sijie commented on issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie commented on issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267#issuecomment-384209722 fixed by #1156 This is an automated message from

[GitHub] sijie closed issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie closed issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie opened a new issue #1267: Improve failover subscription for non-partitioned topic

2018-04-25 Thread GitBox
sijie opened a new issue #1267: Improve failover subscription for non-partitioned topic URL: https://github.com/apache/incubator-pulsar/issues/1267 *Problem* Currently failover subscription is sorting the consumers. so if a consumer who consumer name is always the first consumer

[GitHub] sijie commented on issue #1248: Start Proxy in TLS only mode.

2018-04-25 Thread GitBox
sijie commented on issue #1248: Start Proxy in TLS only mode. URL: https://github.com/apache/incubator-pulsar/pull/1248#issuecomment-384208924 @jai1 are we going to include this in 2.0? shall we move it to 2.1? This is an

[GitHub] sijie closed issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools

2018-04-25 Thread GitBox
sijie closed issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools URL: https://github.com/apache/incubator-pulsar/issues/766 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools

2018-04-25 Thread GitBox
sijie commented on issue #766: Maven surfire-plugin marks build fail for module: pulsar-client-tools URL: https://github.com/apache/incubator-pulsar/issues/766#issuecomment-384208618 This is fixed by #768 This is an

[GitHub] sijie commented on issue #671: Should authParamsString for Authentication support another format ?

2018-04-25 Thread GitBox
sijie commented on issue #671: Should authParamsString for Authentication support another format ? URL: https://github.com/apache/incubator-pulsar/issues/671#issuecomment-384207959 This is fixed by #721 This is an

[GitHub] sijie closed issue #671: Should authParamsString for Authentication support another format ?

2018-04-25 Thread GitBox
sijie closed issue #671: Should authParamsString for Authentication support another format ? URL: https://github.com/apache/incubator-pulsar/issues/671 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie closed issue #621: Documentation for deployment of a single cluster in a data center

2018-04-25 Thread GitBox
sijie closed issue #621: Documentation for deployment of a single cluster in a data center URL: https://github.com/apache/incubator-pulsar/issues/621 This is an automated message from the Apache Git Service. To respond to

[GitHub] sijie commented on issue #621: Documentation for deployment of a single cluster in a data center

2018-04-25 Thread GitBox
sijie commented on issue #621: Documentation for deployment of a single cluster in a data center URL: https://github.com/apache/incubator-pulsar/issues/621#issuecomment-384207473 This is fixed by multiple PRs. This is an

  1   2   >