[GitHub] srkukarni commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli

2018-06-13 Thread GitBox
srkukarni commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli URL: https://github.com/apache/incubator-pulsar/pull/1956#discussion_r195293019 ## File path:

[GitHub] hrsakai commented on a change in pull request #1963: Added RPM packaging for C++ pulsar client lib

2018-06-13 Thread GitBox
hrsakai commented on a change in pull request #1963: Added RPM packaging for C++ pulsar client lib URL: https://github.com/apache/incubator-pulsar/pull/1963#discussion_r195285528 ## File path: pulsar-client-cpp/pkg/rpm/SPECS/pulsar-client.spec ## @@ -0,0 +1,61 @@ +# +#

[GitHub] sijie commented on issue #1845: Functions schema integration

2018-06-13 Thread GitBox
sijie commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-397141984 retest this please This is an automated message from the Apache Git Service. To

[GitHub] rdhabalia commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli

2018-06-13 Thread GitBox
rdhabalia commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli URL: https://github.com/apache/incubator-pulsar/pull/1956#discussion_r195281116 ## File path:

[GitHub] hrsakai commented on a change in pull request #1838: Pulsar Go client docs

2018-06-13 Thread GitBox
hrsakai commented on a change in pull request #1838: Pulsar Go client docs URL: https://github.com/apache/incubator-pulsar/pull/1838#discussion_r195280614 ## File path: site/docs/latest/clients/go.md ## @@ -0,0 +1,589 @@ +--- +title: The Pulsar Go client +tags: [client,

[GitHub] merlimat opened a new pull request #1963: Added RPM packaging for C++ pulsar client lib

2018-06-13 Thread GitBox
merlimat opened a new pull request #1963: Added RPM packaging for C++ pulsar client lib URL: https://github.com/apache/incubator-pulsar/pull/1963 ### Motivation Added scripts to generate RPM package for Pulsar C++ client library. The RPM package will make it easier for users

[GitHub] ivankelly opened a new pull request #1962: Human readable sizes when triggering offload

2018-06-13 Thread GitBox
ivankelly opened a new pull request #1962: Human readable sizes when triggering offload URL: https://github.com/apache/incubator-pulsar/pull/1962 When triggering offload from the CLI, allow the user to specify human readable sizes, like 10M, 100G etc. This patch also fixes a bug

[GitHub] rdhabalia commented on issue #1582: Introduce pulsar replicator

2018-06-13 Thread GitBox
rdhabalia commented on issue #1582: Introduce pulsar replicator URL: https://github.com/apache/incubator-pulsar/issues/1582#issuecomment-397103132 @sijie I think we can close this one as we will be trying out pulsar-io framework here.

[GitHub] rdhabalia closed issue #1582: Introduce pulsar replicator

2018-06-13 Thread GitBox
rdhabalia closed issue #1582: Introduce pulsar replicator URL: https://github.com/apache/incubator-pulsar/issues/1582 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie commented on issue #1582: Introduce pulsar replicator

2018-06-13 Thread GitBox
sijie commented on issue #1582: Introduce pulsar replicator URL: https://github.com/apache/incubator-pulsar/issues/1582#issuecomment-397101383 @rdhabalia what is your status of this task? This is an automated message from

[GitHub] sijie closed issue #1615: PulsarAdmin.createSubscription method does not work against a multi-node Pulsar cluster

2018-06-13 Thread GitBox
sijie closed issue #1615: PulsarAdmin.createSubscription method does not work against a multi-node Pulsar cluster URL: https://github.com/apache/incubator-pulsar/issues/1615 This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1615: PulsarAdmin.createSubscription method does not work against a multi-node Pulsar cluster

2018-06-13 Thread GitBox
sijie commented on issue #1615: PulsarAdmin.createSubscription method does not work against a multi-node Pulsar cluster URL: https://github.com/apache/incubator-pulsar/issues/1615#issuecomment-397101045 This is fixed by #1612 and the fix is available in 2.0.0 release.

[GitHub] sijie commented on issue #1891: Remove references to md5 checksums in download page

2018-06-13 Thread GitBox
sijie commented on issue #1891: Remove references to md5 checksums in download page URL: https://github.com/apache/incubator-pulsar/issues/1891#issuecomment-397098762 This is addressed by #1894 This is an automated message

[GitHub] sijie closed issue #1891: Remove references to md5 checksums in download page

2018-06-13 Thread GitBox
sijie closed issue #1891: Remove references to md5 checksums in download page URL: https://github.com/apache/incubator-pulsar/issues/1891 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] sijie commented on issue #1912: Intermittent test failures in C++ tests BasicEndToEndTest.testSeek

2018-06-13 Thread GitBox
sijie commented on issue #1912: Intermittent test failures in C++ tests BasicEndToEndTest.testSeek URL: https://github.com/apache/incubator-pulsar/issues/1912#issuecomment-397098571 This is fixed by #1936 This is an

[GitHub] sijie closed issue #1912: Intermittent test failures in C++ tests BasicEndToEndTest.testSeek

2018-06-13 Thread GitBox
sijie closed issue #1912: Intermittent test failures in C++ tests BasicEndToEndTest.testSeek URL: https://github.com/apache/incubator-pulsar/issues/1912 This is an automated message from the Apache Git Service. To respond

[GitHub] sijie commented on issue #1928: Support authentication in pulsar-functions

2018-06-13 Thread GitBox
sijie commented on issue #1928: Support authentication in pulsar-functions URL: https://github.com/apache/incubator-pulsar/issues/1928#issuecomment-397097561 This is implemented by #1935 This is an automated message from the

[GitHub] sijie closed issue #1928: Support authentication in pulsar-functions

2018-06-13 Thread GitBox
sijie closed issue #1928: Support authentication in pulsar-functions URL: https://github.com/apache/incubator-pulsar/issues/1928 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] sijie commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
sijie commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-397071852 @dsambandam yeah broker just needs to set advertisedAddress. bookies are tricky since it has a lot

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-397072683 Thanks for your help..I shall keep you posted for any further questions.

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-397069871 Brokers seems to be working now and able to discover the bookies configured

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-397063453 Bookies came up fine after above changes and I see hostname configured for bookie host.

[GitHub] srkukarni commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli

2018-06-13 Thread GitBox
srkukarni commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli URL: https://github.com/apache/incubator-pulsar/pull/1956#discussion_r195213411 ## File path:

[GitHub] sijie closed pull request #1959: Fixed authorization for REST API provided by WebSocket proxy

2018-06-13 Thread GitBox
sijie closed pull request #1959: Fixed authorization for REST API provided by WebSocket proxy URL: https://github.com/apache/incubator-pulsar/pull/1959 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[incubator-pulsar] branch master updated: Fixed authorization for REST API provided by WebSocket proxy (#1959)

2018-06-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 0a655c1 Fixed authorization for REST

[GitHub] sijie closed pull request #1957: Update pulsar cpp client docs

2018-06-13 Thread GitBox
sijie closed pull request #1957: Update pulsar cpp client docs URL: https://github.com/apache/incubator-pulsar/pull/1957 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[incubator-pulsar] branch master updated: Update pulsar cpp client docs (#1957)

2018-06-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 08146c2 Update pulsar cpp client docs

[incubator-pulsar] branch master updated: Remove duplication in CLI validation code (#1958)

2018-06-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 08ffa52 Remove duplication in CLI

[GitHub] sijie closed pull request #1961: Remove potential deadlock in offloading

2018-06-13 Thread GitBox
sijie closed pull request #1961: Remove potential deadlock in offloading URL: https://github.com/apache/incubator-pulsar/pull/1961 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Remove potential deadlock in offloading (#1961)

2018-06-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 830eef1 Remove potential deadlock in

[incubator-pulsar] branch master updated: Trigger offload when managed ledger reaches a size threshold (#1960)

2018-06-13 Thread sijie
This is an automated email from the ASF dual-hosted git repository. sijie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 5c2b0aa Trigger offload when managed

[GitHub] sijie commented on issue #1845: Functions schema integration

2018-06-13 Thread GitBox
sijie commented on issue #1845: Functions schema integration URL: https://github.com/apache/incubator-pulsar/pull/1845#issuecomment-397061816 I merged the latest master. @jerrypeng also addressed your latest two comments (since they are simple comments to address)

[GitHub] merlimat commented on issue #1944: Add CLI commands for schema registry

2018-06-13 Thread GitBox
merlimat commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-397060601 I think the schema is not confined to be used from functions. We should have a common convention to for CLI and Java APIs. For schema I'd

[GitHub] sijie commented on issue #1944: Add CLI commands for schema registry

2018-06-13 Thread GitBox
sijie commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-397059443 @jerrypeng : I pushed a commit to fix the license headers. @merlimat : I think the CLI is following the pattern in functions CLI. I

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-396973645 When bookie format is attempted, I can't start back the bookie process again since it fails

[GitHub] merlimat commented on issue #1944: Add CLI commands for schema registry

2018-06-13 Thread GitBox
merlimat commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-397047830 @mgodave Example of CLI params:

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-396784882 Also when useHostNameAsBookieID is set to true and bookie restarted , process fails with the

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-396757371 All the bookies are up . Below is the broker conf update # Zookeeper quorum

[GitHub] merlimat commented on a change in pull request #1944: Add CLI commands for schema registry

2018-06-13 Thread GitBox
merlimat commented on a change in pull request #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#discussion_r195197389 ## File path: pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Schemas.java ## @@

[GitHub] jerrypeng commented on issue #1944: Add CLI commands for schema registry

2018-06-13 Thread GitBox
jerrypeng commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-397046458 @mgodave can you add the missing headers to the files This is an

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-396742632 @sijie useHostNameAsBookieID to true (worked fine) but having issues with brokers

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-397045930 Version file still uses IPV6 since bookie never started successfully after modifying conf

[GitHub] jerrypeng commented on issue #1944: Add CLI commands for schema registry

2018-06-13 Thread GitBox
jerrypeng commented on issue #1944: Add CLI commands for schema registry URL: https://github.com/apache/incubator-pulsar/pull/1944#issuecomment-397045671 retest this please This is an automated message from the Apache Git

[GitHub] sijie commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
sijie commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-397036494 interesting, so it seems that `VERSION` file is still using ipv6 ip as the bookie identifier. what

[GitHub] merlimat closed pull request #1952: Fix race in MultiTopicsConsumerImpl#redeliverUnacknowledgedMessages

2018-06-13 Thread GitBox
merlimat closed pull request #1952: Fix race in MultiTopicsConsumerImpl#redeliverUnacknowledgedMessages URL: https://github.com/apache/incubator-pulsar/pull/1952 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[incubator-pulsar] branch master updated: Fix race in MultiTopicsConsumerImpl#redeliverUnacknowledgedMessages (#1952)

2018-06-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new dbfe9b7 Fix race in

[GitHub] merlimat commented on a change in pull request #1941: Tiered Storage documentation

2018-06-13 Thread GitBox
merlimat commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r195169464 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] merlimat commented on a change in pull request #1941: Tiered Storage documentation

2018-06-13 Thread GitBox
merlimat commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r195169089 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] merlimat commented on a change in pull request #1941: Tiered Storage documentation

2018-06-13 Thread GitBox
merlimat commented on a change in pull request #1941: Tiered Storage documentation URL: https://github.com/apache/incubator-pulsar/pull/1941#discussion_r195169846 ## File path: site/docs/latest/cookbooks/tiered-storage.md ## @@ -0,0 +1,119 @@ +--- +title: Tiered Storage

[GitHub] merlimat closed pull request #1955: Workaround for ZK 3.4->3.5 upgrade

2018-06-13 Thread GitBox
merlimat closed pull request #1955: Workaround for ZK 3.4->3.5 upgrade URL: https://github.com/apache/incubator-pulsar/pull/1955 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[incubator-pulsar] branch master updated: Workaround for ZK 3.4->3.5 upgrade (#1955)

2018-06-13 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new e45d9e3 Workaround for ZK 3.4->3.5

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-397000397 Ledger version: [root@carocnxodapa5v current]# cat VERSION 4 bookieHost:

[GitHub] ivankelly opened a new pull request #1961: Remove potential deadlock in offloading

2018-06-13 Thread GitBox
ivankelly opened a new pull request #1961: Remove potential deadlock in offloading URL: https://github.com/apache/incubator-pulsar/pull/1961 Managed ledger has a lock, ledgersListMutex, to control write access to the list of ledgers that form the managed ledger. Normally this

[GitHub] ivankelly opened a new pull request #1960: Trigger offload when managed ledger reaches a size threshold

2018-06-13 Thread GitBox
ivankelly opened a new pull request #1960: Trigger offload when managed ledger reaches a size threshold URL: https://github.com/apache/incubator-pulsar/pull/1960 When a managed ledger reaches a certain size, start offloading ledgers in the background. Master Issue: #1511

[GitHub] dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
dsambandam commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-396973645 When bookie format is attempted, I can't start back the bookie process again since it fails

[GitHub] massakam opened a new pull request #1959: Fixed authorization for REST API provided by WebSocket proxy

2018-06-13 Thread GitBox
massakam opened a new pull request #1959: Fixed authorization for REST API provided by WebSocket proxy URL: https://github.com/apache/incubator-pulsar/pull/1959 ### Motivation Currently, anyone can access the entry point

[GitHub] ivankelly opened a new pull request #1958: Remove duplication in CLI validation code

2018-06-13 Thread GitBox
ivankelly opened a new pull request #1958: Remove duplication in CLI validation code URL: https://github.com/apache/incubator-pulsar/pull/1958 There was a couple of validation methods which were duplicated verbatim among various classes. All have been moved into the CliCommand base

[GitHub] rdhabalia commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli

2018-06-13 Thread GitBox
rdhabalia commented on a change in pull request #1956: Add function-package-url support in function cli add url support to function cli URL: https://github.com/apache/incubator-pulsar/pull/1956#discussion_r194975787 ## File path:

[GitHub] sijie commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger

2018-06-13 Thread GitBox
sijie commented on issue #1953: Bookie sanity fails - Unable to connect to Bookie after writing to Ledger URL: https://github.com/apache/incubator-pulsar/issues/1953#issuecomment-396834578 @dsambandam I see still the same error. actually can you do following: 1) on the bookie