saandrews commented on issue #884: Restrict partitioned-metadata rest-api
access for cpp-client older than 1.21
URL: https://github.com/apache/incubator-pulsar/pull/884#issuecomment-342313328
@rdhabalia , Lets do that. Create a patch to know if there are producers
using older version,
sijie opened a new pull request #888: Use fully-qualified docker image name for
running dashboard
URL: https://github.com/apache/incubator-pulsar/pull/888
### Motivation
if a user doesn't build the dashboard image, it can't find the actual
dashboard image locally.
###
hrsakai closed pull request #875: Fix ConsumerHandler in WebSocket Proxy
URL: https://github.com/apache/incubator-pulsar/pull/875
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
massakam opened a new pull request #876: Separate ports used by global and
local zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876
### Motivation
This closes [#813](https://github.com/apache/incubator-pulsar/issues/813)
### Modifications
* Add
merlimat commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341515876
retest this please
This is an automated message from the
merlimat commented on issue #877: Namespace-isolation policy should consider
secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#issuecomment-341498894
retest this please
This is an automated message
merlimat commented on issue #877: Namespace-isolation policy should consider
secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#issuecomment-341498894
retest this please
This is an automated message
nkurihar commented on issue #820: Added setting for anonymous user role
URL: https://github.com/apache/incubator-pulsar/pull/820#issuecomment-341319570
I also think:
* `authenticationEnabled` is redundant any more
* removal of `authenticationEnabled` should be done by another PR, and
yush1ga commented on a change in pull request #877: Namespace-isolation policy
should consider secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#discussion_r148449001
##
File path:
rdhabalia commented on a change in pull request #877: Namespace-isolation
policy should consider secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#discussion_r148449580
##
File path:
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341087955
retest this please
This is an automated message from the
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341087955
retest this please
This is an automated message from the
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341078323
Please let me know if there are any other good ideas :)
This
jai1 opened a new pull request #880: CPP Client - Athens Client header visibile
and remove C++11 features
URL: https://github.com/apache/incubator-pulsar/pull/880
Have removed C++11 features, made the header visible to work with
-fvisibility=hidden and added a type caste for
jai1 commented on a change in pull request #880: CPP Client - Athens Client
header visibile and remove C++11 features
URL: https://github.com/apache/incubator-pulsar/pull/880#discussion_r148693115
##
File path: pulsar-client-cpp/lib/auth/athenz/ZTSClient.cc
##
@@ -143,7
rdhabalia commented on issue #877: Namespace-isolation policy should consider
secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#issuecomment-341575006
retest this please
This is an automated message
rdhabalia commented on issue #877: Namespace-isolation policy should consider
secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#issuecomment-341575006
retest this please
This is an automated message
merlimat commented on a change in pull request #879: Use 127.0.0.1 in
standalone and clean the cookie in case of conflicts
URL: https://github.com/apache/incubator-pulsar/pull/879#discussion_r148689639
##
File path:
rdhabalia closed pull request #877: Namespace-isolation policy should consider
secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
rdhabalia opened a new issue #878: Intermittent test failure:
org.apache.pulsar.client.api.DispatcherBlockConsumerTest.testBlockBrokerDispatching
URL: https://github.com/apache/incubator-pulsar/issues/878
rdhabalia commented on issue #877: Namespace-isolation policy should consider
secondary brokers
URL: https://github.com/apache/incubator-pulsar/pull/877#issuecomment-341587596
retest this please
This is an automated message
jerrypeng opened a new pull request #881: updating Storm version in Pulsar
URL: https://github.com/apache/incubator-pulsar/pull/881
### Motivation
Currently pulsar-storm connectors are using Storm 0.9.5, which is a very old
version of Storm. Updating the Storm dependency to 1.0.5.
merlimat commented on issue #894: Guarantee that messages are encrypted
URL:
https://github.com/apache/incubator-pulsar/issues/894#issuecomment-343260574
> Add encrypted field to CommandProducer
Is there any plan to ensure the producer is effectively encripting all the
messages?
rdhabalia opened a new pull request #896: Introduce Failure-domain and
Anti-affinity-namespace group
URL: https://github.com/apache/incubator-pulsar/pull/896
### Motivation
As mentioned in
saandrews commented on issue #894: Guarantee that messages are encrypted
URL:
https://github.com/apache/incubator-pulsar/issues/894#issuecomment-343282506
Without checking every message metadata, producer may still publish
unencrypted messages.
We could fail the publish at the
merlimat closed pull request #895: Add debug logs for LoadManager and cleanup
unncessary logs
URL: https://github.com/apache/incubator-pulsar/pull/895
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
nkurihar commented on issue #894: Guarantee that messages are encrypted
URL:
https://github.com/apache/incubator-pulsar/issues/894#issuecomment-343323277
> Is there any plan to ensure the producer is effectively encripting all the
messages? Or should we just check at the producer creation
nkurihar closed pull request #892: Fix ReaderHandler in WebSocket Proxy
URL: https://github.com/apache/incubator-pulsar/pull/892
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
nkurihar commented on issue #892: Fix ReaderHandler in WebSocket Proxy
URL: https://github.com/apache/incubator-pulsar/pull/892#issuecomment-342901877
?
This is an automated message from the Apache Git Service.
To respond to
yush1ga opened a new issue #893: Avoid confliction of subscription names for
multiple tenants
URL: https://github.com/apache/incubator-pulsar/issues/893
A topic of Pulsar can be used by multiple tenants.
They have to be careful not to make a subscription name conflict.
I propose
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341392798
@merlimat
> Should we also document it somewhere on how to configure it?
I have modified Monitoring.md.
>
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341392970
@maskit I have fixed `conf/pulsar_env.sh` etc.
The conflict of the ports will be able to be avoided if users set
maskit commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341627986
@massakam I think changing default port numbers for stats servers is
reasonable since we use different port numbers (2181 and
merlimat opened a new pull request #887: Reduce the default per-thread retained
objects in netty Recycler
URL: https://github.com/apache/incubator-pulsar/pull/887
### Motivation
By default, netty recyclers can accumulate up to 32K messages on each
thread's queues. This can result
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341862977
retest this please
This is an automated message from the
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341862977
retest this please
This is an automated message from the
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341865904
retest this please
This is an automated message from the
massakam commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341865904
retest this please
This is an automated message from the
rdhabalia commented on a change in pull request #883: Do not used Pooled
allocator for stats buffers
URL: https://github.com/apache/incubator-pulsar/pull/883#discussion_r148893131
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
merlimat commented on a change in pull request #883: Do not used Pooled
allocator for stats buffers
URL: https://github.com/apache/incubator-pulsar/pull/883#discussion_r148897112
##
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
merlimat closed pull request #879: Use 127.0.0.1 in standalone and clean the
cookie in case of conflicts
URL: https://github.com/apache/incubator-pulsar/pull/879
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake
rdhabalia opened a new pull request #884: Restrict partitioned-metadata
rest-api access for cpp-client older than 1.21
URL: https://github.com/apache/incubator-pulsar/pull/884
### Motivation
As per #836 CPP-client older than 1.21 should not allow to create
producers/consumers for
merlimat commented on issue #879: Use 127.0.0.1 in standalone and clean the
cookie in case of conflicts
URL: https://github.com/apache/incubator-pulsar/pull/879#issuecomment-341812075
retest this please
This is an automated
rdhabalia commented on a change in pull request #882: Use thread local to
allocate temp byte[] instead of allocator
URL: https://github.com/apache/incubator-pulsar/pull/882#discussion_r148899061
##
File path:
merlimat commented on a change in pull request #882: Use thread local to
allocate temp byte[] instead of allocator
URL: https://github.com/apache/incubator-pulsar/pull/882#discussion_r148904088
##
File path:
rdhabalia commented on a change in pull request #882: Use thread local to
allocate temp byte[] instead of allocator
URL: https://github.com/apache/incubator-pulsar/pull/882#discussion_r148906436
##
File path:
rdhabalia commented on a change in pull request #882: Use thread local to
allocate temp byte[] instead of allocator
URL: https://github.com/apache/incubator-pulsar/pull/882#discussion_r148906436
##
File path:
merlimat opened a new pull request #883: Do not used Pooled allocator for stats
buffers
URL: https://github.com/apache/incubator-pulsar/pull/883
### Motivation
To serialize the stats returned by the broker, we are using 2 heap based
buffers coming from an allocator.
Since
rdhabalia commented on issue #884: Restrict partitioned-metadata rest-api
access for cpp-client older than 1.21
URL: https://github.com/apache/incubator-pulsar/pull/884#issuecomment-341816021
@merlimat @saandrews @jai1 can you check if this will be enough to prevent
old-cpp client using
rdhabalia opened a new pull request #885: Cleanup unsused ApiVersionFilter
URL: https://github.com/apache/incubator-pulsar/pull/885
### Motivation
Broker can add validation on
rdhabalia commented on issue #883: Do not used Pooled allocator for stats
buffers
URL: https://github.com/apache/incubator-pulsar/pull/883#issuecomment-341828807
retest this please
This is an automated message from the
rdhabalia opened a new issue #886: Intermittent test failure:
DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAndRedelivery
URL: https://github.com/apache/incubator-pulsar/issues/886
rdhabalia commented on issue #885: Cleanup unsused ApiVersionFilter
URL: https://github.com/apache/incubator-pulsar/pull/885#issuecomment-341835496
@saandrews I have verified that we are not using this feature and we have
`clientLibraryVersionCheckEnabled=false` in all brokers. Also
merlimat commented on issue #881: updating Storm version in Pulsar
URL: https://github.com/apache/incubator-pulsar/pull/881#issuecomment-341841484
@revans2 can you take a look as well and confirm about the tick tuple?
This is
maskit commented on issue #876: Separate ports used by global and local
zookeeper
URL: https://github.com/apache/incubator-pulsar/pull/876#issuecomment-341874547
Then let's resolve the issue with this minimal changes. We can add the new
properties later.
revans2 commented on issue #881: updating Storm version in Pulsar
URL: https://github.com/apache/incubator-pulsar/pull/881#issuecomment-342173192
@merlimat,
@jerrypeng is right that tick tuples are generally configured on a per
component basis. It is possible for someone to set it
jai1 commented on issue #896: Introduce Failure-domain and
Anti-affinity-namespace group
URL: https://github.com/apache/incubator-pulsar/pull/896#issuecomment-350126613
retest this please
This is an automated message
merlimat commented on issue #941: Upgrade Jackson version to latest patch (or
later minor version)
URL:
https://github.com/apache/incubator-pulsar/issues/941#issuecomment-349419595
Thanks for pointing out @cowtowncoder, coming from Jackson maintainer, we'll
take the advice seriously! :)
cowtowncoder commented on issue #941: Upgrade Jackson version to latest patch
(or later minor version)
URL:
https://github.com/apache/incubator-pulsar/issues/941#issuecomment-349424159
@merlimat No prob -- let me know if I can help. I have some vested interest
here too, many co-workers
merlimat closed pull request #938: Handle and log uncaught exception
URL: https://github.com/apache/incubator-pulsar/pull/938
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
merlimat closed pull request #940: Remove some netty artifacts from bin package
since they're already included in netty-all
URL: https://github.com/apache/incubator-pulsar/pull/940
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed
merlimat commented on issue #934: Avoid dead-lock on broker service when broker
failed to load managed-ledger
URL: https://github.com/apache/incubator-pulsar/pull/934#issuecomment-349437629
@rdhabalia Should we merge to 1.21 branch?
rdhabalia commented on issue #934: Avoid dead-lock on broker service when
broker failed to load managed-ledger
URL: https://github.com/apache/incubator-pulsar/pull/934#issuecomment-349440143
I think it's very likely to happen but it's small fix and will not create
any issue for 1.21 so,
rdhabalia closed pull request #936: Issue #935: Included Kubernetes deployment
files in src package
URL: https://github.com/apache/incubator-pulsar/pull/936
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
merlimat commented on issue #930: Issue #929: Perform async DNS resolution each
time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#issuecomment-349437276
@rdhabalia Please take a look. Also, since the 1.21 RC is still on hold,
should we consider fix this in
merlimat commented on issue #940: Remove some netty artifacts from bin package
since they're already included in netty-all
URL: https://github.com/apache/incubator-pulsar/pull/940#issuecomment-349420434
retest this please
rdhabalia commented on issue #930: Issue #929: Perform async DNS resolution
each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#issuecomment-349439310
> Please take a look. Also, since the 1.21 RC is still on hold, should we
consider fix this in 1.21?
jai1 closed pull request #932: Added more log messages for SLA Namespace
acquisition
URL: https://github.com/apache/incubator-pulsar/pull/932
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
lucperkins opened a new pull request #939: Fix broken sidebar links
URL: https://github.com/apache/incubator-pulsar/pull/939
This PR fixes some 404s introduced via changes in the sidebar URL structure.
This is an automated
merlimat opened a new pull request #940: Remove some netty artifacts from bin
package since they're already included in netty-all
URL: https://github.com/apache/incubator-pulsar/pull/940
### Motivation
The binary package is including additional netty jars with different
versions,
cowtowncoder opened a new issue #941: Upgrade Jackson version to latest patch
(or later minor version)
URL: https://github.com/apache/incubator-pulsar/issues/941
This is more of a minor request for maintenance, not bug per se, but I
noticed that the project has a dependency to rather old
jiazhai commented on issue #950: Issue 924: Provide a json file for Marathon
app groups to run Pulsar on DCOS
URL: https://github.com/apache/incubator-pulsar/pull/950#issuecomment-350271335
@sijie.Iit just need one cli command to do the deploy `dcos marathon group
add PulsarGroups.json
jiazhai commented on issue #950: Issue 924: Provide a json file for Marathon
app groups to run Pulsar on DCOS
URL: https://github.com/apache/incubator-pulsar/pull/950#issuecomment-350271335
@sijie.Iit just need one cli command to do the deploy `dcos marathon group
add PulsarGroups.json
rdhabalia opened a new pull request #952: Reduce duplicate string allocation
for GC improvements
URL: https://github.com/apache/incubator-pulsar/pull/952
### Motivation
If broker loads 100K topics with replication enabled for them, then we see
around 3M of String objects presents
jai1 commented on issue #952: Reduce duplicate string allocation for GC
improvements
URL: https://github.com/apache/incubator-pulsar/pull/952#issuecomment-350360487
retest this please
This is an automated message from the
omarrayward opened a new issue #935: Missing Kubernetes files in v 1.20.0
URL: https://github.com/apache/incubator-pulsar/issues/935
Expected behavior
Whenever v 1.20.0 is downloaded, ".yaml" files should appear in "kubernetes"
folder
Actual behavior
Only
ivankelly opened a new issue #933: PIP-9: Topic Compaction
URL: https://github.com/apache/incubator-pulsar/issues/933
Top level issue for pulsar topic compaction.
To read the proposal see:
https://github.com/ivankelly/incubator-pulsar-wiki/blob/pip-9/PIP-9:-Topic-Compaction.md
rdhabalia closed pull request #934: Avoid dead-lock on broker service when
broker failed to load managed-ledger
URL: https://github.com/apache/incubator-pulsar/pull/934
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the
rdhabalia commented on issue #934: Avoid dead-lock on broker service when
broker failed to load managed-ledger
URL: https://github.com/apache/incubator-pulsar/pull/934#issuecomment-348743668
> I would say we shouldn't block 1.21 to wait for this fix though.
Yes, my bad. By mistake I
lovelle commented on a change in pull request #942: Bugfix: duplicate messages
for PartitionedConsumers.
URL: https://github.com/apache/incubator-pulsar/pull/942#discussion_r155335083
##
File path:
lovelle commented on issue #942: Bugfix: duplicate messages for
PartitionedConsumers.
URL: https://github.com/apache/incubator-pulsar/pull/942#issuecomment-349857261
Fixed compilation error, sorry.
This is an automated
sijie opened a new pull request #947: Remove `apache-rat:check` from travis ci
URL: https://github.com/apache/incubator-pulsar/pull/947
### Motivation
Be able to use travis to verify builds
### Modifications
Remove `apache-rat:check`.
### Result
Travis CI
merlimat closed pull request #948: Fix some typos under k8s dir
URL: https://github.com/apache/incubator-pulsar/pull/948
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
merlimat closed pull request #947: Remove `apache-rat:check` from travis ci
URL: https://github.com/apache/incubator-pulsar/pull/947
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a
zhaijack opened a new pull request #948: Fix some typos under k8s dir
URL: https://github.com/apache/incubator-pulsar/pull/948
### Motivation
some file under dir k8s has some typos
### Modifications
1, fix some typos
2, fix containerPort of grafana
### Result
typos
merlimat commented on issue #938: Handle and log uncaught exception
URL: https://github.com/apache/incubator-pulsar/pull/938#issuecomment-349493757
Merged in 1.21 branch as well
This is an automated message from the Apache
merlimat commented on issue #938: Handle and log uncaught exception
URL: https://github.com/apache/incubator-pulsar/pull/938#issuecomment-349493757
Merged in 1.21 branch as well
This is an automated message from the Apache
merlimat commented on issue #939: Fix broken sidebar links
URL: https://github.com/apache/incubator-pulsar/pull/939#issuecomment-349489805
retest this please
This is an automated message from the Apache Git Service.
To
merlimat commented on issue #939: Fix broken sidebar links
URL: https://github.com/apache/incubator-pulsar/pull/939#issuecomment-349489805
retest this please
This is an automated message from the Apache Git Service.
To
merlimat commented on issue #939: Fix broken sidebar links
URL: https://github.com/apache/incubator-pulsar/pull/939#issuecomment-349503705
retest this please
This is an automated message from the Apache Git Service.
To
rdhabalia commented on issue #930: Issue #929: Perform async DNS resolution
each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#issuecomment-349506872
> I'm not sure yet how to properly unit test this change, suggestions
welcome.
It would be
rdhabalia commented on issue #930: Issue #929: Perform async DNS resolution
each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#issuecomment-349506872
> I'm not sure yet how to properly unit test this change, suggestions
welcome.
It would be
massakam opened a new pull request #943: Start receiving messages after
WebSocket session established
URL: https://github.com/apache/incubator-pulsar/pull/943
### Motivation
In rare cases, WebSocket client that start consuming can not receive any
messages from WebSocket Proxy even
rdhabalia commented on a change in pull request #930: Issue #929: Perform async
DNS resolution each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#discussion_r155129637
##
File path:
rdhabalia commented on a change in pull request #930: Issue #929: Perform async
DNS resolution each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#discussion_r155128216
##
File path:
rdhabalia commented on a change in pull request #930: Issue #929: Perform async
DNS resolution each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#discussion_r155125678
##
File path:
merlimat commented on a change in pull request #930: Issue #929: Perform async
DNS resolution each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#discussion_r155130804
##
File path:
lovelle opened a new pull request #942: Bugfix: duplicate messages for
PartitionedConsumers.
URL: https://github.com/apache/incubator-pulsar/pull/942
__Description:__
When UnAckedMessageTracker is active and consumer is not
on receive call, all messages which were redelivered
massakam commented on issue #943: Start receiving messages after WebSocket
session established
URL: https://github.com/apache/incubator-pulsar/pull/943#issuecomment-349544576
retest this please
This is an automated message
merlimat commented on a change in pull request #930: Issue #929: Perform async
DNS resolution each time attempting connect?
URL: https://github.com/apache/incubator-pulsar/pull/930#discussion_r155130901
##
File path:
401 - 500 of 10667 matches
Mail list logo