ctorConfiguration and then pass it to the runner
instead of a Properties class.
--------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
ink
passing ConnectorConfiguration to the runner instead of a Properties class is a
good idea. Should we move some of that common config (base classes) in a
separate module?
--------
This is an automated message from the Apache Git Servi
merlimat closed pull request #694: Fix broker links due to invalid package
URL: https://github.com/apache/incubator-pulsar/pull/694
This is an automated message from the Apache Git Service.
To respond to the message, please
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
rdhabalia closed pull request #693: remove redundant dependencies from modules
URL: https://github.com/apache/incubator-pulsar/pull/693
This is an automated message from the Apache Git Service.
To respond to the message
it will not be used by
the library.
### Result
Nar plugin will not log the warning : `no system package specified; unable
to generate NarSystem class`
This is an automated message from the Apache Git Service
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
nch
still uses netty-4.0. Hopefully it's easy to resolve here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For quer
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
65e02-82bd-11e7-91af-08c9b42f4b17.png)
System configuration
N/A
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
/A
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
maskit commented on issue #692: Link for Message object is dead
URL:
https://github.com/apache/incubator-pulsar/issues/692#issuecomment-322734372
Confirmed. Thanks.
This is an automated message from the Apache Git Service
/A
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards
/A
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us
to also rate limit the
delivery from cache (that might help for topics with many subscriptions)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
quot;
Review comment:
is it writing on `logs/...` by default?
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries
g dots can
contain up to 222 characters, but each dot-separated component can be no longer
than 63 characters.
Bucket names cannot be represented as an IP address in dotted-decimal
notation (for example, 192.168.5.4).
Bucket names cannot begin with the "goog" prefix.
Buck
ease notes.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Wi
`Guava->Lists`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
g"
Review comment:
Here we used to have `${pulsar.log.dir}/${pulsar.log.file}`
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment
* Corrected usages of Recycler to avoid deprecated methods
* Converted usages of `ByteBuf.order()` to avoid deprecated methods
Fix #686
This is an automated message from the Apache Git Service.
To respond to the message
e}
Actually, in log4j2
[system-properties-lookup](https://logging.apache.org/log4j/2.0/manual/lookups.html#SystemPropertiesLookup)
happens with prefix `sys:`. It doesn't work if I remove that prefix.
--------
This is an a
clear what won't
change on 1.x releases.
yes, we can decide if we want to take as part of 1.20 or later releases with
proper notice in documentation. @merlimat any thought on it?
This is an automated message from the Apac
();
+if (pending >= maxPendingMessages) {
+// Resume delivery
+receiveMessage();
+}
}
```
This is an automated message from the Apache Git Service.
To respond to the me
ice.getExecutor().execute(() -> receiveMessage());
+} else {
+// Resume delivery
+receiveMessage();
Review comment:
yes, this would control message-delivery to the client.
----
This is an
to avoid running new version without existing
custom rules? It would be a good safety.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to
### System configuration
N/A
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
merlimat commented on a change in pull request #680: Upgrade to log4j2
dependency and configuration
URL: https://github.com/apache/incubator-pulsar/pull/680#discussion_r132805383
##
File path: conf/log4j2.xml
##
@@ -0,0 +1,70 @@
+
+
+
+
+
+
+
+
clearer for someone for where to change it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
:testCompile (default-testCompile) @
managed-ledger ---
[INFO] Compiling 30 source files to
/Users/masakazu/git/pulsar/managed-ledger/target/test-classes
[WARNING]
/Users/masakazu/git/pulsar/managed-ledger/src/test/java/org/apache/zookeeper/MockZooKeeper.java:[81,23]
ReflectionFactory is internal
maskit commented on issue #678: Fixed Maven test jars warnings
URL: https://github.com/apache/incubator-pulsar/pull/678#issuecomment-321967443
retest this please
This is an automated message from the Apache Git Service
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
c51eaad9745d36d737b30d645fa1db753ae87246
**OS**: macOS 10.12
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service
---
[WARNING] JAR will be empty - no content was marked for inclusion!
[INFO] Building jar: /Users/masakazu/git/pulsar/target/pulsar-tests.jar
```
```
[INFO] --- maven-jar-plugin:3.0.0:test-jar (default) @ distribution ---
[WARNING] JAR will be empty - no content was marked for inclusion
maskit commented on issue #685: Some JAR files will be empty
URL:
https://github.com/apache/incubator-pulsar/issues/685#issuecomment-321967732
#678 fixes this.
This is an automated message from the Apache Git Service
merlimat closed pull request #677: Removed unnecessary Copyright notices in
NOTICE file for bin distribution
URL: https://github.com/apache/incubator-pulsar/pull/677
This is an automated message from the Apache Git Service
merlimat closed pull request #678: Fixed Maven test jars warnings
URL: https://github.com/apache/incubator-pulsar/pull/678
This is an automated message from the Apache Git Service.
To respond to the message, please log
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git
merlimat closed issue #685: Some JAR files will be empty
URL: https://github.com/apache/incubator-pulsar/issues/685
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
merlimat closed issue #684: Unused exclusion pattern
URL: https://github.com/apache/incubator-pulsar/issues/684
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub
ate()`
https://netty.io/4.1/api/io/netty/buffer/ByteBuf.html#retainedSlice--
> [WARNING]
/Users/masakazu/git/pulsar/pulsar-common/src/main/java/io/netty/buffer/RecyclableSlicedByteBuf.java:[69,37]
[deprecation] DuplicatedByteBuf in io.netty.buffer has been deprecated
> Also, I'm cu
api/AuthenticationFactory.java#L44-L53
This change breaks the compatibility.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries ab
.
Should we land this on 1.20? We should probably make it clear what won't
change on 1.x releases.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
Support
for double-quotation is much easier to use than URL encoding.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
tml#retainedSlice--
That doesn't sound like a small change. Let's do it separately.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the speci
maskit opened a new issue #686: DuplicatedByteBuf is deprecated
URL: https://github.com/apache/incubator-pulsar/issues/686
Expected behavior
No warnings during build.
Actual behavior
```
[WARNING]
/Users/masakazu/git/pulsar/pulsar-common/src/main/java/io/netty
maskit commented on issue #679: Refactored usages of deprecated classes
URL: https://github.com/apache/incubator-pulsar/pull/679#issuecomment-322032163
retest this please
This is an automated message from the Apache Git
#issuecomment-321988130
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact
jai1 closed pull request #700: Websocket Client - Making ServiceConfiguration
extendable
URL: https://github.com/apache/incubator-pulsar/pull/700
This is an automated message from the Apache Git Service.
To respond
,
```
Also, We will deprecate ``privateKeyPath`` field.
If there is anything that concerns you, please tell me.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use
?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
not be merged ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@inf
plugins.
For example, we need `athensDomainNames` for athens plugin used in yahoo.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
tobuf`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
tobuf` will look more
simpler. will change it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this se
rdhabalia closed pull request #706: Add missing lib instrunction for
pulsar-ml-admin tool
URL: https://github.com/apache/incubator-pulsar/pull/706
This is an automated message from the Apache Git Service.
To respond
merlimat closed issue #707: Server error when unloading namespace
URL: https://github.com/apache/incubator-pulsar/issues/707
This is an automated message from the Apache Git Service.
To respond to the message, please log
merlimat closed pull request #711: Fix lookup for non-persistent topic based on
correct destination-domain
URL: https://github.com/apache/incubator-pulsar/pull/711
This is an automated message from the Apache Git Service
for smaller screens by adding a Bootstrap
`hidden-md-down` class to the image.
### Result
The logo will not appear on smaller screens.
This is an automated message from the Apache Git Service.
To respond to the message
maskit commented on issue #698: Links for client libraries are dead
URL:
https://github.com/apache/incubator-pulsar/issues/698#issuecomment-324303545
Thanks.
This is an automated message from the Apache Git Service
maskit closed issue #697: Link for C++ client library page is dead
URL: https://github.com/apache/incubator-pulsar/issues/697
This is an automated message from the Apache Git Service.
To respond to the message, please log
maskit closed issue #698: Links for client libraries are dead
URL: https://github.com/apache/incubator-pulsar/issues/698
This is an automated message from the Apache Git Service.
To respond to the message, please log
maskit commented on issue #696: Link for Clusters and Brokers guide is dead
URL:
https://github.com/apache/incubator-pulsar/issues/696#issuecomment-324303806
Thanks.
This is an automated message from the Apache Git Service
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
}).exceptionally(ex -> {
+status = Status.Failed;
+log.warn("[{}] Failed to enable deduplication:
{}", topic.getName(), ex.getMessage());
+future.completeExceptionally(ex);
Review comment:
added
dPayload.release();
Review comment:
> In any case it won't be a "leak"
Yes, but if we don't recycle `EntryImpl` then don't we see leak with
netty-detection report and it will keep creating new objects and will go out of
memory.?
-----
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-Deduplication)
implementation.
Exposing sequence id in the `Producer` and `MessageBuilder` interfaces.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above
ion("");
Review comment:
Tried to do manual partitions management in the Producer end, but it gets
complicated to deal with the Kafka `Partitioner` interface. The trick is that
relies on a `Cluster` view which is overly Kafka specific.
I'll leave it for later if
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
msg.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
saandrews closed pull request #731: End to End Encryption Support - Java client
URL: https://github.com/apache/incubator-pulsar/pull/731
This is an automated message from the Apache Git Service.
To respond to the message
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
entries, since most use case won't have more
than one key.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queri
lean keyGenNeeded) {
+
+encryptedDataKeyMap = new ConcurrentHashMap<String, byte[]>();
+dataKeyCache = CacheBuilder.newBuilder().expireAfterAccess(6,
TimeUnit.HOURS)
Review comment:
We would require few secs/mins more than 4hrs for ideal use case.
-----
collides.
When it
+// retruns a different key decryption fails. At this point, we
would
+// call decryptDataKey to refresh the cache and come here
again to decrypt.
+decryptedData = decryptData(storedSecretKey, msgMetadata,
payload);
Review comm
-compact` artifact will be a
drop-in replacement for `org.apache.kafka:kafka-clients`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
merlimat commented on issue #761: Kafka client Java API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/761#issuecomment-329991089
retest this please
This is an automated message from the Apache Git Service
merlimat closed pull request #753: Kafka client Java API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/753
This is an automated message from the Apache Git Service.
To respond to the message, please log
anything :).
I've reverted the Jenkins config and the build got triggered again:
https://builds.apache.org/job/pulsar-pull-request/jobConfigHistory/
This is an automated message from the Apache Git Service.
To respond
merlimat closed pull request #761: Kafka client Java API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/761
This is an automated message from the Apache Git Service.
To respond to the message, please log
-compact` artifact will be a
drop-in replacement for `org.apache.kafka:kafka-clients`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
merlimat commented on issue #761: Kafka client Java API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/761#issuecomment-330005750
retest this please
This is an automated message from the Apache Git Service
specify the sequence id of a
message. This may be related to some application specific property
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go
rdhabalia commented on issue #761: Kafka client Java API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/761#issuecomment-329992512
retest this please
This is an automated message from the Apache Git Service
merlimat commented on issue #761: Kafka client Java API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/761#issuecomment-329998702
retest this please
This is an automated message from the Apache Git Service
merlimat commented on issue #761: Kafka client Java API wrapper
URL: https://github.com/apache/incubator-pulsar/pull/761#issuecomment-329998702
retest this please
This is an automated message from the Apache Git Service
from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
his is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
1 - 100 of 780 matches
Mail list logo
