[GitHub] rdhabalia commented on a change in pull request #2104: Remove dependencies exclusions for org.apache.httpcomponents:httpclient

2018-07-06 Thread GitBox
rdhabalia commented on a change in pull request #2104: Remove dependencies 
exclusions for org.apache.httpcomponents:httpclient
URL: https://github.com/apache/incubator-pulsar/pull/2104#discussion_r200752973
 
 

 ##
 File path: pom.xml
 ##
 @@ -188,12 +188,6 @@ flexible messaging model and an intuitive client 
API.
 org.apache.httpcomponents
 httpclient
 4.5.5
 
 Review comment:
   I misread it, I thought this change was made in pulsar-client-pom.xml.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] rdhabalia commented on a change in pull request #2104: Remove dependencies exclusions for org.apache.httpcomponents:httpclient

2018-07-06 Thread GitBox
rdhabalia commented on a change in pull request #2104: Remove dependencies 
exclusions for org.apache.httpcomponents:httpclient
URL: https://github.com/apache/incubator-pulsar/pull/2104#discussion_r200750533
 
 

 ##
 File path: pom.xml
 ##
 @@ -188,12 +188,6 @@ flexible messaging model and an intuitive client 
API.
 org.apache.httpcomponents
 httpclient
 4.5.5
 
 Review comment:
   as this dependency already part of parent-dep-management so, should we 
remove version as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services