lucperkins commented on a change in pull request #1585: Default schemas URL: https://github.com/apache/incubator-pulsar/pull/1585#discussion_r181890923
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/schemas/StringSchema.java ########## @@ -0,0 +1,54 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.api.schemas; + +import org.apache.pulsar.client.api.Schema; +import org.apache.pulsar.common.schema.SchemaInfo; +import org.apache.pulsar.common.schema.SchemaType; + +import java.nio.charset.Charset; +import java.nio.charset.StandardCharsets; + +public class StringSchema implements Schema<String> { + private final Charset charset; + private static final Charset DEFAULT_CHARSET = StandardCharsets.UTF_8; + + public StringSchema() { + this.charset = DEFAULT_CHARSET; + } + + public StringSchema(Charset charset) { + this.charset = charset; + } + + public byte[] encode(String message) { + return message.getBytes(charset); + } + + public String decode(byte[] bytes) { + return new String(bytes, charset); + } + + public SchemaInfo getSchemaInfo() { Review comment: @mgodave This is one area where I'll need your input ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
