[GitHub] merlimat commented on a change in pull request #689: Netty 4.1

merlimat commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153672292 ## File path: pulsar-common/src/main/java/org/apache/pulsar/common/util/protobuf/ByteBufCodedOutputStream.java ## @@ -261,7 +260,6

[GitHub] merlimat commented on a change in pull request #689: Netty 4.1

merlimat commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153646828 ## File path: pulsar-common/src/test/java/org/apache/pulsar/common/api/DoubleByteBufTest.java ## @@ -50,5 +50,22 @@ public void tes

[GitHub] merlimat commented on a change in pull request #689: Netty 4.1

merlimat commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153646724 ## File path: build/docker/protobuf.patch ## @@ -161,30 +167,30 @@ index 4c087db..cd18e28 100644 "classname", ClassName(de

[GitHub] merlimat commented on a change in pull request #689: Netty 4.1

merlimat commented on a change in pull request #689: Netty 4.1 URL: https://github.com/apache/incubator-pulsar/pull/689#discussion_r153646222 ## File path: pom.xml ## @@ -125,7 +125,7 @@ flexible messaging model and an intuitive client API. org.asynchttpcl