[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-17 Thread GitBox 
merlimat commented on issue #1089: PIP-12 Introduce builder for creating 
Producer Consumer Reader
URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-366455235
 
 
   Rebased to fix tls test certificates issue


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-16 Thread GitBox 
merlimat commented on issue #1089: PIP-12 Introduce builder for creating 
Producer Consumer Reader
URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-366392235
 
 
   retest this please


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-14 Thread GitBox 
merlimat commented on issue #1089: PIP-12 Introduce builder for creating 
Producer Consumer Reader
URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-365505550
 
 
   >  Once we have subscription for topics and pattern, we need add them in.
   
   Yes, the idea was to have different ways to specify: 
   ```java
   // Single topic
   client.newConsumer().topic(MY_TOPIC).subscriptioName(SUB).build();
   
   // List of topics
   List myList = ...;
   client.newConsumer().topics(myList).subscriptioName(SUB).build();
   
   // Regex
   client.newConsumer().topicsRegex("test.*").subscriptioName(SUB).build();
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-13 Thread GitBox 
merlimat commented on issue #1089: PIP-12 Introduce builder for creating 
Producer Consumer Reader
URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-365505550
 
 
   >  Once we have subscription for topics and pattern, we need add them in.
   
   Yes, the idea was to have different ways to specify: 
   ```java
   // Single topic
   client.newConsumer.topic(MY_TOPIC).subscriptioName(SUB).build();
   
   // List of topics
   List myList = ...;
   client.newConsumer.topics(myList).subscriptioName(SUB).build();
   
   // Regex
   client.newConsumer.topicsRegex("test.*").subscriptioName(SUB).build();
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] merlimat commented on issue #1089: PIP-12 Introduce builder for creating Producer Consumer Reader

2018-02-13 Thread GitBox 
merlimat commented on issue #1089: PIP-12 Introduce builder for creating 
Producer Consumer Reader
URL: https://github.com/apache/incubator-pulsar/pull/1089#issuecomment-365505133
 
 
   This is ready for review. Once this is finalized and merged, I'll start 
converting all the code to use new API.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services