[GitHub] rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function

2018-07-19 Thread GitBox
rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function URL: https://github.com/apache/incubator-pulsar/pull/2200#issuecomment-406442736 > otherwise we keep finding issues or improvements to do and we never actually cut the release :). alright.

[GitHub] rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function

2018-07-19 Thread GitBox
rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function URL: https://github.com/apache/incubator-pulsar/pull/2200#issuecomment-406422509 > I think we used to have subscription type but we removed it sometime ago. umm.. then how can we maintain the

[GitHub] rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function

2018-07-19 Thread GitBox
rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function URL: https://github.com/apache/incubator-pulsar/pull/2200#issuecomment-406420204 retest this please This is an automated message

[GitHub] rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function

2018-07-19 Thread GitBox
rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function URL: https://github.com/apache/incubator-pulsar/pull/2200#issuecomment-406388383 @sijie I think we should consider it for 2.1.0 because it will be required if someone wants to use sink with

[GitHub] rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function

2018-07-19 Thread GitBox
rdhabalia commented on issue #2200: support subscription-type to be passed in sink-function URL: https://github.com/apache/incubator-pulsar/pull/2200#issuecomment-406171768 retest this please This is an automated message