[GitHub] sijie commented on issue #2180: Cleanup Arquillian consolidate projects

2018-07-20 Thread GitBox
sijie commented on issue #2180: Cleanup Arquillian consolidate projects
URL: https://github.com/apache/incubator-pulsar/pull/2180#issuecomment-406519492
 
 
   we don't have to put everything into one module if dependencies management 
because problematic.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2180: Cleanup Arquillian consolidate projects

2018-07-20 Thread GitBox
sijie commented on issue #2180: Cleanup Arquillian consolidate projects
URL: https://github.com/apache/incubator-pulsar/pull/2180#issuecomment-406519368
 
 
   @aahmed-se : a different netty version is coming from datastax client. you 
can try to exclud it from datastax. if exclusion doesn't work, then I would 
suggest moving connectors test into its own module.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2180: Cleanup Arquillian consolidate projects

2018-07-20 Thread GitBox
sijie commented on issue #2180: Cleanup Arquillian consolidate projects
URL: https://github.com/apache/incubator-pulsar/pull/2180#issuecomment-406511898
 
 
   @aahmed-se 
   
   you need to change pulsar-client to pulsar-client-original. pulsar-client is 
a shaded version, it will be conflicting with managed-ledger-original on 
pulsar-common.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2180: Cleanup Arquillian consolidate projects

2018-07-19 Thread GitBox
sijie commented on issue #2180: Cleanup Arquillian consolidate projects
URL: https://github.com/apache/incubator-pulsar/pull/2180#issuecomment-406185295
 
 
   @aahmed-se can you attach those exceptions in this PR?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] sijie commented on issue #2180: Cleanup Arquillian consolidate projects

2018-07-19 Thread GitBox
sijie commented on issue #2180: Cleanup Arquillian consolidate projects
URL: https://github.com/apache/incubator-pulsar/pull/2180#issuecomment-406171993
 
 
   @aahmed-se what are shading issues? what errors have you been observed?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services