srkukarni commented on a change in pull request #1708: Refactor functions to
use Sink interface
URL: https://github.com/apache/incubator-pulsar/pull/1708#discussion_r185565400
##########
File path:
pulsar-connect/core/src/main/java/org/apache/pulsar/connect/core/Sink.java
##########
@@ -45,5 +45,5 @@
* @param value output value
* @return Completable future fo async publish request
*/
- CompletableFuture<Void> write(T value);
-}
\ No newline at end of file
+ CompletableFuture<Void> write(T value) throws Exception;
Review comment:
+1 on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
