srkukarni commented on a change in pull request #2409: Added HDFS Sink URL: https://github.com/apache/incubator-pulsar/pull/2409#discussion_r213060424
########## File path: pulsar-io/hdfs/src/main/java/org/apache/pulsar/io/hdfs/AbstractHdfsConfig.java ########## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.io.hdfs; + +import java.io.Serializable; + +import lombok.Data; +import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; +import lombok.experimental.Accessors; + +import org.apache.commons.lang.StringUtils; + +/** + * Configuration object for all HDFS components. + */ +@Data +@Setter +@Getter +@EqualsAndHashCode +@ToString +@Accessors(chain = true) +public abstract class AbstractHdfsConfig implements Serializable { + + private static final long serialVersionUID = 1L; + + /** + * A file or comma separated list of files which contains the Hadoop file system configuration. + * Without this, Hadoop will search the classpath for a 'core-site.xml' and 'hdfs-site.xml' file + * or will revert to a default configuration. + */ + private String hdfsConfigResources; + + /** + * The HDFS directory from which files should be read from or written to. + */ + private String directory; + + /** + * The character encoding for the files, e.g. UTF-8, ASCII, etc. + */ + private String encoding; + + /** + * The compression codec used to compress/de-compress the files on HDFS. + */ + private Compression compression; + + /** + * The Kerberos user principal account to use for authentication. + */ + private String kerberosUserPrincipal; + + /** + * The full pathname to the Kerberos keytab file to use for authentication. + */ + private String keytab; + + public void validate() { + if (StringUtils.isEmpty(hdfsConfigResources) || StringUtils.isEmpty(directory)) { Review comment: The comments for hdfsConfigResources indicate that if this is unset we look into certain places. Thus it looks like this check shouldnt be there? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
