Repository: qpid-proton Updated Branches: refs/heads/master c36a1a711 -> 90dbf46cc
PROTON-1910: [go] fix faulty message test Project: http://git-wip-us.apache.org/repos/asf/qpid-proton/repo Commit: http://git-wip-us.apache.org/repos/asf/qpid-proton/commit/d8cebe49 Tree: http://git-wip-us.apache.org/repos/asf/qpid-proton/tree/d8cebe49 Diff: http://git-wip-us.apache.org/repos/asf/qpid-proton/diff/d8cebe49 Branch: refs/heads/master Commit: d8cebe494cac78ba6959ada4af2b3fc8e958769d Parents: 674e023 Author: Alan Conway <acon...@redhat.com> Authored: Fri Oct 12 09:25:38 2018 -0400 Committer: Alan Conway <acon...@redhat.com> Committed: Tue Oct 23 20:04:07 2018 -0400 ---------------------------------------------------------------------- go/src/qpid.apache.org/amqp/message.go | 4 ++-- go/src/qpid.apache.org/amqp/message_test.go | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/d8cebe49/go/src/qpid.apache.org/amqp/message.go ---------------------------------------------------------------------- diff --git a/go/src/qpid.apache.org/amqp/message.go b/go/src/qpid.apache.org/amqp/message.go index e96b331..0589d67 100644 --- a/go/src/qpid.apache.org/amqp/message.go +++ b/go/src/qpid.apache.org/amqp/message.go @@ -117,7 +117,7 @@ type Message interface { ReplyToGroupId() string SetReplyToGroupId(string) - // Property map set by the application to be carried with the message. + // Properties set by the application to be carried with the message. // Values must be simple types (not maps, lists or sequences) ApplicationProperties() map[string]interface{} SetApplicationProperties(map[string]interface{}) @@ -151,7 +151,7 @@ type Message interface { // Marshal a Go value into the message body, synonym for SetBody() Marshal(interface{}) - // Unmarshal the message body into the value pointed to by v. See amqp.Unmarshal() + // Unmarshal the message body, using amqp.Unmarshal() Unmarshal(interface{}) // Encode encodes the message as AMQP data. If buffer is non-nil and is large enough http://git-wip-us.apache.org/repos/asf/qpid-proton/blob/d8cebe49/go/src/qpid.apache.org/amqp/message_test.go ---------------------------------------------------------------------- diff --git a/go/src/qpid.apache.org/amqp/message_test.go b/go/src/qpid.apache.org/amqp/message_test.go index 321a9a0..9899bd5 100644 --- a/go/src/qpid.apache.org/amqp/message_test.go +++ b/go/src/qpid.apache.org/amqp/message_test.go @@ -39,6 +39,9 @@ func roundTrip(m Message) error { func TestDefaultMessage(t *testing.T) { m := NewMessage() + if err := roundTrip(m); err != nil { + t.Error(err) + } mv := reflect.ValueOf(m) // Check defaults for _, x := range []struct { @@ -75,9 +78,6 @@ func TestDefaultMessage(t *testing.T) { t.Errorf("%s: %s", x.method, err) } } - if err := roundTrip(m); err != nil { - t.Error(err) - } if err := checkEqual("Message{}", m.String()); err != nil { t.Error(err) } --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@qpid.apache.org For additional commands, e-mail: commits-h...@qpid.apache.org
