Author: astitcher Date: Wed Mar 4 04:22:50 2009 New Revision: 749894 URL: http://svn.apache.org/viewvc?rev=749894&view=rev Log: QPID-1710 Removed unnecessary nonportable internal API
Modified: qpid/trunk/qpid/cpp/src/qpid/sys/Socket.h qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp qpid/trunk/qpid/cpp/src/qpid/sys/posix/Socket.cpp qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.cpp qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h Modified: qpid/trunk/qpid/cpp/src/qpid/sys/Socket.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/Socket.h?rev=749894&r1=749893&r2=749894&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/sys/Socket.h (original) +++ qpid/trunk/qpid/cpp/src/qpid/sys/Socket.h Wed Mar 4 04:22:50 2009 @@ -27,8 +27,6 @@ #include <string> -struct sockaddr; - namespace qpid { namespace sys { @@ -93,7 +91,7 @@ /** Accept a connection from a socket that is already listening * and has an incoming connection */ - Socket* accept(struct sockaddr *addr, socklen_t *addrlen) const; + Socket* accept() const; // TODO The following are raw operations, maybe they need better wrapping? int read(void *buf, size_t count) const; Modified: qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp?rev=749894&r1=749893&r2=749894&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/sys/posix/AsynchIO.cpp Wed Mar 4 04:22:50 2009 @@ -123,7 +123,7 @@ // TODO: Currently we ignore the peers address, perhaps we should // log it or use it for connection acceptance. try { - s = socket.accept(0, 0); + s = socket.accept(); if (s) { acceptedCallback(*s); } else { Modified: qpid/trunk/qpid/cpp/src/qpid/sys/posix/Socket.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/posix/Socket.cpp?rev=749894&r1=749893&r2=749894&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/sys/posix/Socket.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/sys/posix/Socket.cpp Wed Mar 4 04:22:50 2009 @@ -189,9 +189,9 @@ return ntohs(name.sin_port); } -Socket* Socket::accept(struct sockaddr *addr, socklen_t *addrlen) const +Socket* Socket::accept() const { - int afd = ::accept(impl->fd, addr, addrlen); + int afd = ::accept(impl->fd, 0, 0); if ( afd >= 0) return new Socket(new IOHandlePrivate(afd)); else if (errno == EAGAIN) Modified: qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.cpp?rev=749894&r1=749893&r2=749894&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslIo.cpp Wed Mar 4 04:22:50 2009 @@ -90,7 +90,7 @@ // TODO: Currently we ignore the peers address, perhaps we should // log it or use it for connection acceptance. try { - s = socket.accept(0, 0); + s = socket.accept(); if (s) { acceptedCallback(*s); } else { Modified: qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp?rev=749894&r1=749893&r2=749894&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp (original) +++ qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.cpp Wed Mar 4 04:22:50 2009 @@ -201,9 +201,9 @@ return ntohs(name.sin_port); } -SslSocket* SslSocket::accept(struct sockaddr *addr, socklen_t *addrlen) const +SslSocket* SslSocket::accept() const { - int afd = ::accept(impl->fd, addr, addrlen); + int afd = ::accept(impl->fd, 0, 0); if ( afd >= 0) { return new SslSocket(new IOHandlePrivate(afd), prototype); } else if (errno == EAGAIN) { Modified: qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h?rev=749894&r1=749893&r2=749894&view=diff ============================================================================== --- qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h (original) +++ qpid/trunk/qpid/cpp/src/qpid/sys/ssl/SslSocket.h Wed Mar 4 04:22:50 2009 @@ -64,7 +64,7 @@ * Accept a connection from a socket that is already listening * and has an incoming connection */ - SslSocket* accept(struct sockaddr *addr, socklen_t *addrlen) const; + SslSocket* accept() const; // TODO The following are raw operations, maybe they need better wrapping? int read(void *buf, size_t count) const; --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:commits-subscr...@qpid.apache.org