Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-07 Thread via GitHub
Willhow-Gao commented on PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#issuecomment-2097679990 > 合并一下 develop 重新提交一下,develop 有一些单测的修复 merge develop了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-07 Thread via GitHub
lizhimins commented on PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#issuecomment-2097669930 合并一下 develop 重新提交一下,develop 有一些单测的修复 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-06 Thread via GitHub
codecov-commenter commented on PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#issuecomment-2097288402 ## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/8091?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-06 Thread via GitHub
Willhow-Gao commented on code in PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#discussion_r1591234961 ## client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java: ## @@ -0,0 +1,85 @@ +package

Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-06 Thread via GitHub
Willhow-Gao commented on code in PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#discussion_r1590491448 ## client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java: ## @@ -0,0 +1,85 @@ +package

Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-05 Thread via GitHub
Willhow-Gao commented on code in PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#discussion_r1590491448 ## client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java: ## @@ -0,0 +1,85 @@ +package

Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-05 Thread via GitHub
RongtongJin commented on PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#issuecomment-2095093396 Error: /home/runner/work/rocketmq/rocketmq/client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java:1: Line does not match expected header

Re: [PR] [ISSUE #8090]1.optimize isSetEqual method and add Unit tests; 2.fix a… [rocketmq]

2024-05-05 Thread via GitHub
RongtongJin commented on code in PR #8091: URL: https://github.com/apache/rocketmq/pull/8091#discussion_r1590483117 ## client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImplTest.java: ## @@ -0,0 +1,85 @@ +package