[ 
https://issues.apache.org/jira/browse/ROL-2138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865528#comment-16865528
 ] 

Aditya Sharma edited comment on ROL-2138 at 6/17/19 11:29 AM:
--------------------------------------------------------------

Hi [~sebb] ,

I have updated the PR. Please verify, if fine I will cherry-pick changes for 
5.2.x

Improved the statement for Notice as discussed.

Improved statements as described standard.

Removed the notices for subdependencies.

Added License text in license file where applicable

 


was (Author: aditya.sharma):
Hi [~sebb] ,

I have updated the PR. Please verify, if fine I will cherry-pick changes for 
5.2.x

> NOTICE file does not have standard content
> ------------------------------------------
>
>                 Key: ROL-2138
>                 URL: https://issues.apache.org/jira/browse/ROL-2138
>             Project: Apache Roller
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Aditya Sharma
>            Priority: Critical
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The NOTICE file in the 5.2.2 release does not have the standard format [1] 
> for a NOTICE file
> It does not have the standard header.
> It also contains material which should not be present.
> Note that the NOTICE and LICENSE files must only include details of software 
> which is actually included in the bundle to which they relate. In this case, 
> the binary bundle contains 3rd party (and other ASF) software, so the NOTICE 
> and LICENSE files should be different.
> Furthermore, the text of all relevant licenses must be included in the 
> bundle; links to external licenses are not sufficient. The license text can 
> either be appended to the LICENSE file, or included in separate files linked 
> from the LICENSE file.
> [1] 
> http://www.apache.org/dev/licensing-howto.html#assembling-license-and-notice



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to