[royale-asjs] branch develop updated: Jewel Validator: Extract create/destroy error border to separate method

[piotrz]

This is an automated email from the ASF dual-hosted git repository.

piotrz pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 1d282e8  Jewel Validator: Extract create/destroy error border to 
separate method
1d282e8 is described below

commit 1d282e8d4e16e67d176f6b3009f7115e46f546cc
Author: Piotr Zarzycki <piotrzarzyck...@gmail.com>
AuthorDate: Thu Sep 2 15:05:08 2021 +0200

    Jewel Validator: Extract create/destroy error border to separate method
---
 .../royale/jewel/beads/validators/Validator.as     | 32 +++++++++++++++-------
 1 file changed, 22 insertions(+), 10 deletions(-)

diff --git 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/validators/Validator.as
 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/validators/Validator.as
index a3e5cdd..3e2fb64 100644
--- 
a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/validators/Validator.as
+++ 
b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/validators/Validator.as
@@ -383,15 +383,20 @@ package org.apache.royale.jewel.beads.validators
 
                        COMPILE::JS
                        {
-                       window.addEventListener('resize', repositionHandler, 
false);
-                       window.addEventListener('scroll', repositionHandler, 
true);
-                       repositionHandler();
+                               window.addEventListener('resize', 
repositionHandler, false);
+                               window.addEventListener('scroll', 
repositionHandler, true);
+                               repositionHandler();
+
+                               createErrorBorder();
                        }
+               }
 
-                       COMPILE::JS
+               COMPILE::JS
+               protected function createErrorBorder():void
+               {
+                       if (!hostClassList.contains("errorBorder"))
                        {
-                               if (!hostClassList.contains("errorBorder"))
-                                       hostClassList.add("errorBorder");
+                               hostClassList.add("errorBorder");
                        }
                }
 
@@ -498,21 +503,28 @@ package org.apache.royale.jewel.beads.validators
         {
                        COMPILE::JS
                        {
-                       window.removeEventListener('resize', repositionHandler, 
false);
-                       window.removeEventListener('scroll', repositionHandler, 
true);
+                               window.removeEventListener('resize', 
repositionHandler, false);
+                               window.removeEventListener('scroll', 
repositionHandler, true);
                        }
             if (_errorTip) {
                                
IEventDispatcher(_host.popUpParent).removeEventListener("cleanValidationErrors",
 destroyErrorTip);
                 _host.popUpParent.removeElement(_errorTip);
                                _errorTip = null;
                        }
+
                        COMPILE::JS
                        {
+                               destroyErrorBorder();
+                       }
+        }
+
+               COMPILE::JS
+               protected function destroyErrorBorder():void
+               {
                        if (hostClassList && 
hostClassList.contains("errorBorder"))
                        {
                                hostClassList.remove("errorBorder");
                        }
-                       }
-        }
+               }
        }
 }