This is an automated email from the ASF dual-hosted git repository. piotrz pushed a commit to branch develop in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push: new 5b69700c38 Jewel: Fix issue in DateChooser where Buttons next/previous without setup text property were sized incorrectly 5b69700c38 is described below commit 5b69700c38bb7bdc3a5ae9f0882d95c5457ce59d Author: Piotr Zarzycki <piotrzarzyck...@gmail.com> AuthorDate: Mon Jan 15 14:44:04 2024 +0100 Jewel: Fix issue in DateChooser where Buttons next/previous without setup text property were sized incorrectly - Text properties on buttons shouldn't be needed in case of DateChooser. I have added min/max width/height for buttons next/prev - Remove in DateField redundant setup of text on Button --- frameworks/projects/Jewel/src/main/resources/defaults.css | 4 ++++ .../royale/org/apache/royale/jewel/beads/views/DateChooserView.as | 2 -- .../main/royale/org/apache/royale/jewel/beads/views/DateFieldView.as | 1 - frameworks/projects/Jewel/src/main/sass/components/_datechooser.sass | 3 +++ 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/frameworks/projects/Jewel/src/main/resources/defaults.css b/frameworks/projects/Jewel/src/main/resources/defaults.css index 05e417b80f..259886a350 100644 --- a/frameworks/projects/Jewel/src/main/resources/defaults.css +++ b/frameworks/projects/Jewel/src/main/resources/defaults.css @@ -646,6 +646,10 @@ j|VirtualDataGridColumnList { .jewel.datechooser .jewel.table .jewel.tableheadercell.buttonsRow .viewSelector::after { content: " "; } +.jewel.datechooser .jewel.table .jewel.tableheadercell.buttonsRow .previousButton, .jewel.datechooser .jewel.table .jewel.tableheadercell.buttonsRow .nextButton { + min-width: 40px; + min-height: 40px; +} .jewel.datechooser .jewel.table .jewel.tableheadercell.buttonsRow .previousButton::after, .jewel.datechooser .jewel.table .jewel.tableheadercell.buttonsRow .nextButton::after { content: " "; position: absolute; diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateChooserView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateChooserView.as index ee0068f0b8..38a920b02f 100644 --- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateChooserView.as +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateChooserView.as @@ -158,11 +158,9 @@ package org.apache.royale.jewel.beads.views _viewSelector.className = "viewSelector"; _previousButton = new Button(); - _previousButton.text = "<"; _previousButton.className = "previousButton"; _nextButton = new Button(); - _nextButton.text = ">"; _nextButton.className = "nextButton"; _table = new DateChooserTable(); diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateFieldView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateFieldView.as index aebdf22d28..bd17951a83 100644 --- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateFieldView.as +++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/DateFieldView.as @@ -153,7 +153,6 @@ package org.apache.royale.jewel.beads.views COMPILE::JS { _button.element.setAttribute('tabindex', -1); } - _button.text = "↓"; getHost().addElement(_button); COMPILE::SWF { diff --git a/frameworks/projects/Jewel/src/main/sass/components/_datechooser.sass b/frameworks/projects/Jewel/src/main/sass/components/_datechooser.sass index 7dc894e612..a620cdb292 100644 --- a/frameworks/projects/Jewel/src/main/sass/components/_datechooser.sass +++ b/frameworks/projects/Jewel/src/main/sass/components/_datechooser.sass @@ -41,6 +41,9 @@ $datechooser-tableitem-size: 38px .viewSelector::after content: ' ' + .previousButton, .nextButton + min-width: 40px + min-height: 40px .previousButton::after, .nextButton::after content: ' ' position: absolute