ajothomas merged PR #1649:
URL: https://github.com/apache/samza/pull/1649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ajothomas opened a new pull request, #1649:
URL: https://github.com/apache/samza/pull/1649
This PR has all website/doc related changes w.r.t to samza 1.8.0 release.
Since we did not add anything for 1.7.0 release, this PR adds a release.md and
download links for 1.7.0 release.
--
This
li-afaris commented on PR #1647:
URL: https://github.com/apache/samza/pull/1647#issuecomment-1382703530
Good catch. I updated publish-site.sh and tested the best that I could as I
don't have SVN write access. Let me know if it doesn't work correctly. Thanks
--
This is an automated
li-afaris commented on PR #1204:
URL: https://github.com/apache/samza/pull/1204#issuecomment-1381196091
This can probably be closed "won't-fix" as Jekyll 4.3.1 is in the dependency
tree from pull request #1647. The following is from `./gradlew
docs:dependencies`
```
gems
+---
li-afaris commented on PR #1621:
URL: https://github.com/apache/samza/pull/1621#issuecomment-1381195077
This can probably be closed "won't-fix" as ffi was upgraded to 1.15.5 from
pull request #1647. The following is from `./gradlew docs:dependencies`
```
gems
+---
li-afaris commented on PR #1623:
URL: https://github.com/apache/samza/pull/1623#issuecomment-1381194149
This can probably be closed "won't-fix" as JSON 2.6.3 is in the dependency
tree from pull request #1647. The following is from `./gradlew
docs:dependencies`
```
gems
+---
li-afaris commented on PR #1624:
URL: https://github.com/apache/samza/pull/1624#issuecomment-1381193456
This can probably be closed "won't-fix" as redcarpet was replaced with
Kramdown from pull request #1647 and is no longer used.
--
This is an automated message from the Apache Git
li-afaris commented on PR #1632:
URL: https://github.com/apache/samza/pull/1632#issuecomment-1381192497
This can probably be closed "won't-fix" as addressable 2.8.1 is in the
dependency tree from pull request #1647. The following is from `./gradlew
docs:dependencies`
```
gems
li-afaris commented on code in PR #1647:
URL: https://github.com/apache/samza/pull/1647#discussion_r1068741225
##
docs/meetups/index.html:
##
@@ -21,7 +21,7 @@
-->
-{% assign sorted = (site.meetups | sort: 'date') | reverse %}
+{% assign sorted = site.meetups |
li-afaris commented on code in PR #1647:
URL: https://github.com/apache/samza/pull/1647#discussion_r1068741065
##
docs/talks/index.html:
##
@@ -21,7 +21,7 @@
-->
-{% assign sorted = (site.talks | sort: 'date') | reverse %}
+{% assign sorted = site.talks | sort:
mynameborat commented on code in PR #1647:
URL: https://github.com/apache/samza/pull/1647#discussion_r1068483167
##
docs/meetups/index.html:
##
@@ -21,7 +21,7 @@
-->
-{% assign sorted = (site.meetups | sort: 'date') | reverse %}
+{% assign sorted = site.meetups |
mynameborat merged PR #1648:
URL: https://github.com/apache/samza/pull/1648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mynameborat commented on PR #1648:
URL: https://github.com/apache/samza/pull/1648#issuecomment-1376380697
@shekhars-li can you run the build locally/publish another dummy commit to
trigger the checks again?
--
This is an automated message from the Apache Git Service.
To respond to the
shekhars-li opened a new pull request, #1648:
URL: https://github.com/apache/samza/pull/1648
What: Updated RocksDB to version 7.8.3
Why: This version reduces the write compaction by aligning compaction output
file boundaries. More details can be found in [this blog
li-afaris commented on PR #1647:
URL: https://github.com/apache/samza/pull/1647#issuecomment-1372953087
FYI: Removing the Jekyll incremental build flag resolved the file name
differences I found in the previous comment.
--
This is an automated message from the Apache Git Service.
To
amf3 commented on PR #1647:
URL: https://github.com/apache/samza/pull/1647#issuecomment-1371765244
I found the following differences after generating documents with Jekyll
using both MRI Ruby & Jruby. Input was generated by running find on the _site
directory and saving the output to a
li-afaris commented on PR #1647:
URL: https://github.com/apache/samza/pull/1647#issuecomment-1361904668
> I'm open to suggestions for improving confidence relating to the Jekyll
plugin changes.
One thing I thought of was to list & compare the generated file names in
_site. I found
li-afaris commented on PR #1647:
URL: https://github.com/apache/samza/pull/1647#issuecomment-1360645861
I'm not sure why the last commit (ccb932d) failed testing when the previous
one (651a1bc) worked. You can see the diff by clicking the ccb932d link above.
Is the
li-afaris opened a new pull request, #1647:
URL: https://github.com/apache/samza/pull/1647
# Summary
This change moves Jekyll dependency management into Gradle. Contributors
will no longer be required to install ruby & Jekyll by hand.
# Changes
* Gemfiles no longer manage
xinyuiscool merged PR #1646:
URL: https://github.com/apache/samza/pull/1646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ajothomas opened a new pull request, #1646:
URL: https://github.com/apache/samza/pull/1646
Add Ajo Thomas to committers list and GPG keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dxichen merged PR #1645:
URL: https://github.com/apache/samza/pull/1645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dxichen opened a new pull request, #1645:
URL: https://github.com/apache/samza/pull/1645
Currently if a restore factory is missing due to a misconfiguration we exit
due to a NPE
```
2022-12-13 18:23:07.794 [main] SamzaContainer [ERROR] Caught exception/error
while initializing
dxichen merged PR #1644:
URL: https://github.com/apache/samza/pull/1644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shekhars-li opened a new pull request, #1644:
URL: https://github.com/apache/samza/pull/1644
Bug
- We introduced blob store backed for state backup and restore in [this
commit](https://github.com/apache/samza/commit/7cc4eaa96fff244f6dce9c18af804917db7c3b2b).
- `StateBackendFactory`
shanthoosh merged PR #1641:
URL: https://github.com/apache/samza/pull/1641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shanthoosh commented on PR #1641:
URL: https://github.com/apache/samza/pull/1641#issuecomment-1317938599
Thanks for adding the tests @jia-gao . After going through the linkedin
documents and JIRA tickets, it seems like we are just proceeding with the
approach finalized as a part of the
jia-gao commented on PR #1641:
URL: https://github.com/apache/samza/pull/1641#issuecomment-1317936984
> validating
> @jia-gao As discussed offline, it would be great if we can add a unit-test
for validating these changes in this patch.
Added unit tests
--
This is
xinyuiscool merged PR #1642:
URL: https://github.com/apache/samza/pull/1642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ajothomas commented on code in PR #1642:
URL: https://github.com/apache/samza/pull/1642#discussion_r1024611620
##
samza-core/src/main/java/org/apache/samza/drain/DrainUtils.java:
##
@@ -54,44 +74,34 @@ private DrainUtils() {
* @return generated uuid for the
shanthoosh commented on PR #1641:
URL: https://github.com/apache/samza/pull/1641#issuecomment-1317817165
@jia-gao As discussed offline, it would be great if we can add a unit-test
for validating these changes in this patch.
--
This is an automated message from the Apache Git Service.
To
ajothomas commented on code in PR #1642:
URL: https://github.com/apache/samza/pull/1642#discussion_r1024598787
##
samza-api/src/main/java/org/apache/samza/drain/DrainMode.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
xinyuiscool commented on code in PR #1642:
URL: https://github.com/apache/samza/pull/1642#discussion_r1024576429
##
samza-api/src/main/java/org/apache/samza/drain/DrainMode.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
ajothomas closed pull request #1643: SAMZA-2770: [Pipeline Drain] Enable drain
monitor by default
URL: https://github.com/apache/samza/pull/1643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ajothomas opened a new pull request, #1643:
URL: https://github.com/apache/samza/pull/1643
# Summary
Drain monitor had been turned off by default. The idea was to turn it on
after testing the pipeline drain feature.
# Changes
- Set `DRAIN_MONITOR_ENABLED_DEFAULT` to true in
ajothomas opened a new pull request, #1642:
URL: https://github.com/apache/samza/pull/1642
# Summary
The current `DrainNotification` is a concrete class tasked with signaling
samza engine to clear intermediate state. It is currently inextensible and any
changes to the class in the
jia-gao commented on code in PR #1641:
URL: https://github.com/apache/samza/pull/1641#discussion_r1024297945
##
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java:
##
@@ -46,7 +43,6 @@ public class StreamAppenderMetrics extends MetricsBase {
alnzng commented on code in PR #1641:
URL: https://github.com/apache/samza/pull/1641#discussion_r1021917783
##
samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppenderMetrics.java:
##
@@ -46,7 +43,6 @@ public class StreamAppenderMetrics extends MetricsBase {
jia-gao commented on PR #1641:
URL: https://github.com/apache/samza/pull/1641#issuecomment-1314166098
> Is the default support to prevent recursion not available when this change
was introduced or did we upgrade to newer version of log4j that adds this
prevention at the framework layer?
mynameborat merged PR #1637:
URL: https://github.com/apache/samza/pull/1637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ajothomas commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1018537087
##
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java:
##
@@ -106,7 +110,10 @@ public void run() {
callback.failure(new
ajothomas commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1018502824
##
samza-core/src/main/java/org/apache/samza/config/TaskConfig.java:
##
@@ -90,6 +90,13 @@ public class TaskConfig extends MapConfig {
// timeout for triggering a
ajothomas commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1018501997
##
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java:
##
@@ -106,7 +110,10 @@ public void run() {
callback.failure(new
ajothomas commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1018500682
##
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java:
##
@@ -127,4 +127,14 @@ public List
updateCallback(TaskCallbackImpl callback) {
xinyuiscool merged PR #1640:
URL: https://github.com/apache/samza/pull/1640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mynameborat commented on code in PR #1640:
URL: https://github.com/apache/samza/pull/1640#discussion_r1017221725
##
samza-core/src/main/java/org/apache/samza/config/ApplicationConfig.java:
##
@@ -46,6 +46,11 @@ public enum ApplicationMode {
BATCH
}
+ public enum
mynameborat commented on PR #1641:
URL: https://github.com/apache/samza/pull/1641#issuecomment-1307762089
Is the default support to prevent recursion not available when this change
was introduced or did we upgrade to newer version of log4j that adds this
prevention at the framework layer?
jia-gao opened a new pull request, #1641:
URL: https://github.com/apache/samza/pull/1641
Issue:
We have observed logging data loss happen in StreamAppender
The RC is that current implementation of the
mynameborat commented on code in PR #1640:
URL: https://github.com/apache/samza/pull/1640#discussion_r1016065159
##
samza-core/src/main/java/org/apache/samza/container/RunLoopFactory.java:
##
@@ -69,6 +69,8 @@ public static Runnable
createRunLoop(scala.collection.immutable.Map
ajothomas opened a new pull request, #1640:
URL: https://github.com/apache/samza/pull/1640
# Summary
`ApplicationUtil.isHighLevelApiJob` doesn't work for cases where
`SamzaApplication` could have been created as an anonymous class and lambdas
# Cause
Anonymous class names and
mynameborat merged PR #1636:
URL: https://github.com/apache/samza/pull/1636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
alnzng commented on PR #1636:
URL: https://github.com/apache/samza/pull/1636#issuecomment-1306372678
@mynameborat I have fixed the check issue(checksytle issue) and resolved all
the comments. Can you please check? Thanks.
--
This is an automated message from the Apache Git Service.
To
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015983431
##
samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
mynameborat commented on PR #1636:
URL: https://github.com/apache/samza/pull/1636#issuecomment-1306336433
Looks good to me mostly. Can you close out the conversations that have been
resolved and respond to the comments that are pending.
Also, fix the latest checks so that I can merge
mynameborat commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015978318
##
samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015958371
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015949373
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lakshmi-manasa-g commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015754291
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015751569
##
samza-core/src/main/java/org/apache/samza/container/host/ProcessCPUStatistics.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015714131
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015713429
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lakshmi-manasa-g commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015642158
##
samza-core/src/main/java/org/apache/samza/container/host/SystemStatisticsGetter.java:
##
@@ -30,4 +30,11 @@ public interface SystemStatisticsGetter {
*
lakshmi-manasa-g commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1015641830
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014527935
##
samza-core/src/main/java/org/apache/samza/container/host/PosixCommandBasedStatisticsGetter.java:
##
@@ -85,4 +86,10 @@ public SystemMemoryStatistics
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014528695
##
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala:
##
@@ -49,6 +49,7 @@ class SamzaContainerMetrics(
val executorWorkFactor =
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014528695
##
samza-core/src/main/scala/org/apache/samza/container/SamzaContainerMetrics.scala:
##
@@ -49,6 +49,7 @@ class SamzaContainerMetrics(
val executorWorkFactor =
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014527935
##
samza-core/src/main/java/org/apache/samza/container/host/PosixCommandBasedStatisticsGetter.java:
##
@@ -85,4 +86,10 @@ public SystemMemoryStatistics
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014527343
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014525707
##
samza-core/src/main/java/org/apache/samza/container/host/SystemStatisticsGetter.java:
##
@@ -30,4 +30,11 @@ public interface SystemStatisticsGetter {
* @return
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014525560
##
samza-core/src/main/java/org/apache/samza/container/host/SystemStatistics.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014525279
##
samza-core/src/main/java/org/apache/samza/container/host/StatisticsMonitorImpl.java:
##
@@ -117,23 +118,23 @@ public void run() {
}
private void
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014524771
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014523821
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014523336
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
alnzng commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014522272
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
mynameborat commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1013440757
##
samza-core/src/main/java/org/apache/samza/container/host/DefaultSystemStatisticsGetter.java:
##
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software
lakshmi-manasa-g commented on code in PR #1636:
URL: https://github.com/apache/samza/pull/1636#discussion_r1014326963
##
samza-core/src/main/java/org/apache/samza/container/host/OshiBasedStatisticsGetter.java:
##
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software
alnzng commented on PR #1638:
URL: https://github.com/apache/samza/pull/1638#issuecomment-1303916282
thanks for merging it @mynameborat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mynameborat merged PR #1638:
URL: https://github.com/apache/samza/pull/1638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mynameborat commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1013403151
##
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java:
##
@@ -106,7 +110,10 @@ public void run() {
callback.failure(new
xinyuiscool merged PR #1639:
URL: https://github.com/apache/samza/pull/1639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ajothomas commented on code in PR #1639:
URL: https://github.com/apache/samza/pull/1639#discussion_r1013123821
##
samza-test/src/test/java/org/apache/samza/test/drain/DrainHighLevelApiIntegrationTest.java:
##
@@ -74,20 +74,30 @@ public void describe(StreamApplicationDescriptor
ajothomas commented on code in PR #1639:
URL: https://github.com/apache/samza/pull/1639#discussion_r1013123456
##
samza-core/src/main/java/org/apache/samza/container/RunLoop.java:
##
@@ -875,49 +876,40 @@ private boolean shouldDrain() {
return false;
}
-
ajothomas commented on code in PR #1639:
URL: https://github.com/apache/samza/pull/1639#discussion_r1013123301
##
samza-core/src/main/java/org/apache/samza/container/RunLoop.java:
##
@@ -875,49 +876,40 @@ private boolean shouldDrain() {
return false;
}
-
ajothomas commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1012008633
##
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java:
##
@@ -76,7 +76,7 @@ List update(TaskCallbackImpl cb) {
private final TaskCallbacks
xinyuiscool commented on code in PR #1639:
URL: https://github.com/apache/samza/pull/1639#discussion_r1010901435
##
samza-test/src/test/java/org/apache/samza/test/drain/DrainHighLevelApiIntegrationTest.java:
##
@@ -74,20 +74,30 @@ public void
ajothomas opened a new pull request, #1639:
URL: https://github.com/apache/samza/pull/1639
# Symptoms and Cause:
There were a few issues with the processing of drain messages that this PR
attempts to fix. The following issues were encountered during the end-to-end
testing with test
alnzng opened a new pull request, #1638:
URL: https://github.com/apache/samza/pull/1638
# Symptom
No data was emitted for the metric `container-active-threads`
# Cause
This PR(#1501 ) removed the logic to emit data for metric accidently:
mynameborat commented on code in PR #1637:
URL: https://github.com/apache/samza/pull/1637#discussion_r1010012333
##
samza-core/src/main/java/org/apache/samza/task/TaskCallbackManager.java:
##
@@ -76,7 +76,7 @@ List update(TaskCallbackImpl cb) {
private final TaskCallbacks
ajothomas opened a new pull request, #1637:
URL: https://github.com/apache/samza/pull/1637
# Improvement:
This PR is a part of the Pipeline Drain work and aims to provide a way to
specify a task callback timeout to be used for pipeline drain. The standard
`task.callback.timeout.ms`
Treydone commented on PR #1633:
URL: https://github.com/apache/samza/pull/1633#issuecomment-1297695724
Sorry, I can't build the site locally... Even from the master branch with
the command `bundle exec jekyll build,` I got an error
```
jekyll 3.4.5 | Error: No header received
mynameborat commented on PR #1635:
URL: https://github.com/apache/samza/pull/1635#issuecomment-1292317691
We will revisit this when we have Samza Beam portable support in oSS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mynameborat closed pull request #1635: SAMZA-2763: Support worker JVM opts for
Samza Beam portable mode
URL: https://github.com/apache/samza/pull/1635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alnzng opened a new pull request, #1636:
URL: https://github.com/apache/samza/pull/1636
# Symptom
We have observed that some use cases used quasar(TensorFlow framework) to do
model inference and this framework spawn child processes(non-JVM) to run
TensorFlow serving. These child
mynameborat opened a new pull request, #1635:
URL: https://github.com/apache/samza/pull/1635
**Summary**: Support JVM options for worker process in Samza Beam portable
mode
**Description**: With portable mode support for Samza Beam, we want to tune
and configure the JVM options for
sborya merged PR #1634:
URL: https://github.com/apache/samza/pull/1634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mynameborat commented on PR #1633:
URL: https://github.com/apache/samza/pull/1633#issuecomment-1281000897
can you publish the website locally to make sure the changes look as
expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
1 - 100 of 5696 matches
Mail list logo
