[ https://issues.apache.org/jira/browse/SAMZA-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335345#comment-16335345 ]
ASF GitHub Bot commented on SAMZA-1562: --------------------------------------- GitHub user jmakes opened a pull request: https://github.com/apache/samza/pull/412 SAMZA-1562: TaskStorageManager should delete any local store it canno… …t open. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jmakes/samza samza-1562 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/samza/pull/412.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #412 ---- commit f2a687c46846392d20eccba21ac385ba4758b836 Author: Jacob Maes <jmakes@...> Date: 2018-01-23T03:21:52Z SAMZA-1562: TaskStorageManager should delete any local store it cannot open. ---- > TaskStorageManager should delete any local store it cannot open. > ---------------------------------------------------------------- > > Key: SAMZA-1562 > URL: https://issues.apache.org/jira/browse/SAMZA-1562 > Project: Samza > Issue Type: Bug > Reporter: Jake Maes > Assignee: Jake Maes > Priority: Major > > If an exception occurs while validating/opening the local store, the > TaskStorageManager should delete the whole logged store directory. Otherwise > the task will never successfully run on that host again. > > Examples > {noformat} > .../Partition_349/000512.sst: No such file or directory > at > org.apache.samza.storage.kv.RocksDbKeyValueStore$.openDB(RocksDbKeyValueStore.scala:87) > at > org.apache.samza.storage.kv.RocksDbKeyValueStore.db$lzycompute(RocksDbKeyValueStore.scala:109) > at > org.apache.samza.storage.kv.RocksDbKeyValueStore.db(RocksDbKeyValueStore.scala:109) > at > org.apache.samza.storage.kv.RocksDbKeyValueStore.putAll(RocksDbKeyValueStore.scala:166) > at > org.apache.samza.storage.kv.KeyValueStorageEngine.restore(KeyValueStorageEngine.scala:129) > at > org.apache.samza.storage.TaskStorageManager$$anonfun$restoreStores$3.apply(TaskStorageManager.scala:256) > at > org.apache.samza.storage.TaskStorageManager$$anonfun$restoreStores$3.apply(TaskStorageManager.scala:250) > at > scala.collection.TraversableLike$WithFilter$$anonfun$foreach$1.apply(TraversableLike.scala:772) > at scala.collection.immutable.Map$Map3.foreach(Map.scala:154) > at > scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:771) > at > org.apache.samza.storage.TaskStorageManager.restoreStores(TaskStorageManager.scala:250) > at > org.apache.samza.storage.TaskStorageManager.init(TaskStorageManager.scala:81) > at > org.apache.samza.container.TaskInstance.startStores(TaskInstance.scala:116) > at > org.apache.samza.container.SamzaContainer$$anonfun$startStores$2.apply(SamzaContainer.scala:866) > at > org.apache.samza.container.SamzaContainer$$anonfun$startStores$2.apply(SamzaContainer.scala:864) > at scala.collection.Iterator$class.foreach(Iterator.scala:727) > at scala.collection.AbstractIterator.foreach(Iterator.scala:1157) > at scala.collection.MapLike$DefaultValuesIterable.foreach(MapLike.scala:206) > at > org.apache.samza.container.SamzaContainer.startStores(SamzaContainer.scala:864) > at org.apache.samza.container.SamzaContainer.run(SamzaContainer.scala:685) > at > org.apache.samza.runtime.LocalContainerRunner.run(LocalContainerRunner.java:104) > {noformat} > and > {noformat} > 2018-01-22 16:39:29.824 [main] SamzaContainer [ERROR] Caught exception/error > while initializing container. > java.lang.NullPointerException > at org.apache.samza.util.Util$.readDataFromFile(Util.scala:318) > at > org.apache.samza.storage.TaskStorageManager.org$apache$samza$storage$TaskStorageManager$$readOffsetFile(TaskStorageManager.scala:200) > at > org.apache.samza.storage.TaskStorageManager.isOffsetFileValid(TaskStorageManager.scala:163) > at > org.apache.samza.storage.TaskStorageManager.org$apache$samza$storage$TaskStorageManager$$isLoggedStoreValid(TaskStorageManager.scala:124) > at > org.apache.samza.storage.TaskStorageManager$$anonfun$cleanBaseDirs$2.apply(TaskStorageManager.scala:101) > at > org.apache.samza.storage.TaskStorageManager$$anonfun$cleanBaseDirs$2.apply(TaskStorageManager.scala:88) > at scala.collection.Iterator$class.foreach(Iterator.scala:727) > at scala.collection.AbstractIterator.foreach(Iterator.scala:1157) > at scala.collection.MapLike$DefaultKeySet.foreach(MapLike.scala:174) > at > org.apache.samza.storage.TaskStorageManager.cleanBaseDirs(TaskStorageManager.scala:88) > at > org.apache.samza.storage.TaskStorageManager.init(TaskStorageManager.scala:77) > at org.apache.samza.container.TaskInstance.startStores(TaskInstance.scala:116) > at > org.apache.samza.container.SamzaContainer$$anonfun$startStores$2.apply(SamzaContainer.scala:866) > at > org.apache.samza.container.SamzaContainer$$anonfun$startStores$2.apply(SamzaContainer.scala:864) > at scala.collection.Iterator$class.foreach(Iterator.scala:727) > at scala.collection.AbstractIterator.foreach(Iterator.scala:1157) > at scala.collection.MapLike$DefaultValuesIterable.foreach(MapLike.scala:206) > at > org.apache.samza.container.SamzaContainer.startStores(SamzaContainer.scala:864) > at org.apache.samza.container.SamzaContainer.run(SamzaContainer.scala:685) > at > org.apache.samza.runtime.LocalContainerRunner.run(LocalContainerRunner.java:104) > at > org.apache.samza.runtime.LocalContainerRunner.main(LocalContainerRunner.java:149) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)