[
https://issues.apache.org/jira/browse/SAMZA-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622837#comment-16622837
]
Yi Pan (Data Infrastructure) commented on SAMZA-1894:
-----------------------------------------------------
One more note: since SystemConfig and JavaSystemConfig are defined in
samza-core, a limited scope of repeated definitions in samza-api would be
acceptable. Other modules that directly depend on samza-core *MUST NOT*
repeated define those configure prefix and keys.
> Too many redundant definition of system configuration variables
> ---------------------------------------------------------------
>
> Key: SAMZA-1894
> URL: https://issues.apache.org/jira/browse/SAMZA-1894
> Project: Samza
> Issue Type: Improvement
> Reporter: Yi Pan (Data Infrastructure)
> Priority: Major
> Labels: newbie
>
> Quick git grep yields the following:
> {quote}
> yipan-mn1:samza_master yipan$ git grep 'systems\.%s\.samza.factory'
> samza-api/src/main/java/org/apache/samza/operators/descriptors/base/system/SystemDescriptor.java:
> private static final String FACTORY_CONFIG_KEY = "systems.%s.samza.factory";
> samza-aws/src/test/java/org/apache/samza/system/kinesis/TestKinesisSystemFactory.java:
> private static final String SYSTEM_FACTORY_REGEX =
> "systems.%s.samza.factory";
> samza-test/src/main/java/org/apache/samza/test/framework/system/CollectionStreamSystemSpec.java:
> * <li>"systems.%s.samza.factory" = {@link InMemorySystemFactory}</li>
> samza-test/src/main/java/org/apache/samza/test/framework/system/CollectionStreamSystemSpec.java:
> * <li>"jobs.job-name-and-id.systems.%s.samza.factory" = {@link
> InMemorySystemFactory}</li>
> samza-test/src/main/java/org/apache/samza/test/framework/system/CollectionStreamSystemSpec.java:
> private static final String SYSTEM_FACTORY = "systems.%s.samza.factory";
> samza-test/src/test/java/org/apache/samza/test/StandaloneTestUtils.java:
> private static final String SYSTEM_FACTORY_FORMAT_STRING =
> "systems.%s.samza.factory";
> samza-test/src/test/java/org/apache/samza/test/processor/TestZkLocalApplicationRunner.java:
> .put(String.format("systems.%s.samza.factory", systemName),
> TEST_SYSTEM_FACTORY)
> samza-tools/src/main/java/org/apache/samza/tools/benchmark/AbstractSamzaBench.java:
> protected static final String CFG_SYSTEM_FACTORY =
> "systems.%s.samza.factory";
> {quote}
> Most of the configure prefix and keys are already defined in JavaSystemConfig
> or SystemConfig. We should keep all those configure prefix and key
> definitions in a single class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
